192009 - null plugin installs itself into unexpected places

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

../../../../../config/nsinstall -R -m 755 libnullplugin.so ../../../../../dist/gre
../../../../../config/nsinstall -R -m 755 libnullplugin.so ../../../../../dist/lib
../../../../../config/nsinstall -R -m 755 libnullplugin.so ../../../../../dist/bin
../../../../../config/nsinstall -R libnullplugin.so ../../../../../dist/bin/plugins


the first three lines are not where the plugin should be

maybe the GRE_MODULE=1 line has something to do with this

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

ok, removing GRE_MODULE does no longer install it in dist/gre, but still in
dist/lib and dist/bin

Comment 2

[hacker formerly known as [e-mail]]

Here we go again.  The files listed in the GRE come from
embedding/config/{basebrowser-win,gre-win,gre-win-supp}.  The nullplugin is
listed there.  It doesn't need to be installed as a standard library in the dist
dirs though and to fix that you need to set NO_DIST_INSTALL and use a custom
rule to install it under bin/plugins. 

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

cls: er, this is a linux bug, no windows one, basebrowser-win and friends should
better not be used here.

Comment 4

[hacker formerly known as [e-mail]]

Err, I'm not the authoritative person to speak on the GRE but my understanding
is that it's XP so whatever's in the win32 GRE (minus win32 specific components)
should be in the unix GRE as well.

Comment 5

[Peter Lubczynski]

Attachment: patch v.1

This patch removes the nullplugin from the extra dirs on UNIX by adding
NO_DIST_INSTALL=1 like is already there on Windows.

Comment 6

[Peter Lubczynski]

Comment on attachment 113603 [details] [diff] [review]
patch v.1

requesting drivers approval for 1.3b: there is no need to copy the default
plugin all over the place, it just belongs in bin/plugins.

See bug 191021 for removing npnul32.dll from the Windows GRE directory.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 113603 [details] [diff] [review]
patch v.1

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 8

[Peter Lubczynski]

patch in trunk, marking FIXED

Comment 9

[bmartin]

Marking Verified Fixed.

Compared attached patch w/Checkin Log: 
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=Makefile.in&root=/cvsroot&subdir=mozilla/modules/plugin/samples/default/unix&command=DIFF_FRAMESET&rev1=1.27&rev2=1.28