Command updating far too slow, especially during focus

RESOLVED FIXED

Status

MailNews Core
Composition
RESOLVED FIXED
15 years ago
9 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: Jean-Francois Ducarroz)

Tracking

({perf})

Trunk
x86
Windows 95

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

18.71 KB, patch
Cavin Song
: review+
(not reading, please use seth@sspitzer.org instead)
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

15 years ago
By removing all knowledge of editing from message compose it is possible to get
a noticable (at least on my slow pc :-) speed improvement when opening or
tabbing in message compose. In fact, it's no longer necessary to suppress
command updating. I also tweaked the list of commands updated for the edit menu;
I added cmd_findPrev and removed cmd_rewrap which is already handled by the
focus. I've also removed the unnecessary cmd_insert in favour of
cmd_renderedHTMLEnabler.

I tested the code both with a new message and a reply to an existing message.

I got r=brade for the editor part of the patch over irc.
(Reporter)

Comment 1

15 years ago
Created attachment 113590 [details] [diff] [review]
Proposed patch
(Reporter)

Updated

15 years ago
Attachment #113590 - Flags: superreview?(sspitzer)
Attachment #113590 - Flags: review?(ducarroz)
(Assignee)

Updated

15 years ago
Attachment #113590 - Flags: review?(ducarroz) → review?(cavin)

Comment 2

15 years ago
Comment on attachment 113590 [details] [diff] [review]
Proposed patch

r=cavin.
Attachment #113590 - Flags: review?(cavin) → review+
Comment on attachment 113590 [details] [diff] [review]
Proposed patch

before sr, can you elaborate on what you tested?

did you test tabbing between addresses, subject, and body (and changing focus?)

and, in addition to what you've already done ("new message and a reply to an
existing message"), make sure you've tested the cached compose window.

(are you on linux or win32?  if linux, the cached compose window isn't enabled
by default for you)
http://www.mozilla.org/mailnews/arch/compose/cached.html

see also
http://www.mozilla.org/mailnews/arch/compose/testing.html

if you need help testing,  (since you might be on linux) let me know.

I'm nervous about regressing the compose window.
(Reporter)

Comment 4

15 years ago
>did you test tabbing between addresses, subject, and body (and changing focus?)
Yes.

>and, in addition to what you've already done ("new message and a reply to an
>existing message"), make sure you've tested the cached compose window.
Will do.
(Reporter)

Comment 5

15 years ago
Silly me, I'd forgotton that I'd applied the patch to my win32 nightly...
Comment on attachment 113590 [details] [diff] [review]
Proposed patch

sr=sspitzer, since neil has been testing, and this is 1.4 alpha.

thanks neil!
Attachment #113590 - Flags: superreview?(sspitzer) → superreview+
(Reporter)

Comment 7

15 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Product: MailNews → Core
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.