192013 - Command updating far too slow, especially during focus

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[[e-mail]]

By removing all knowledge of editing from message compose it is possible to get
a noticable (at least on my slow pc :-) speed improvement when opening or
tabbing in message compose. In fact, it's no longer necessary to suppress
command updating. I also tweaked the list of commands updated for the edit menu;
I added cmd_findPrev and removed cmd_rewrap which is already handled by the
focus. I've also removed the unnecessary cmd_insert in favour of
cmd_renderedHTMLEnabler.

I tested the code both with a new message and a reply to an existing message.

I got r=brade for the editor part of the patch over irc.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Cavin Song]

Comment on attachment 113590 [details] [diff] [review]
Proposed patch

r=cavin.

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 113590 [details] [diff] [review]
Proposed patch

before sr, can you elaborate on what you tested?

did you test tabbing between addresses, subject, and body (and changing focus?)

and, in addition to what you've already done ("new message and a reply to an
existing message"), make sure you've tested the cached compose window.

(are you on linux or win32?  if linux, the cached compose window isn't enabled
by default for you)
http://www.mozilla.org/mailnews/arch/compose/cached.html

see also
http://www.mozilla.org/mailnews/arch/compose/testing.html

if you need help testing,  (since you might be on linux) let me know.

I'm nervous about regressing the compose window.

Comment 4

[[e-mail]]

>did you test tabbing between addresses, subject, and body (and changing focus?)
Yes.

>and, in addition to what you've already done ("new message and a reply to an
>existing message"), make sure you've tested the cached compose window.
Will do.

Comment 5

[[e-mail]]

Silly me, I'd forgotton that I'd applied the patch to my win32 nightly...

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 113590 [details] [diff] [review]
Proposed patch

sr=sspitzer, since neil has been testing, and this is 1.4 alpha.

thanks neil!

Comment 7

[[e-mail]]

Fix checked in.