1920176 - Google search code for Vivo deal

Status: RESOLVED FIXED

(Firefox for Android :: Search, task)

Description

[John Oberhauser]

Add Google search code for Vivo deal

code: firefox-b-vv

Include distribution ID, as this will be needed when porting this configuration over to the upcoming search-config-v2 integration.

Comment 1

[John Oberhauser]

Attachment: WIP: Bug 1920176 Adding google search codes for vivo deal

Comment 2

[John Oberhauser]

Attachment: Bug 1920176 Adding google search codes for vivo deal. Saving distribution Id in the browser store

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22b8552ac3f9
Adding google search codes for vivo deal.  Saving distribution Id in the browser store r=android-reviewers,amejiamarmol,gmalekpour

Comment 4

[tszentpeteri]

Backed out for causing fenix failures related to FirstSessionPingTest.checkAndSend().

• Backout link
• Push with failures
• Failure Log:

[task 2024-10-03T22:16:34.690Z] SUITE: org.mozilla.fenix.components.metrics.FirstSessionPingTest
[task 2024-10-03T22:16:34.690Z]   TEST: WHEN build version is more than R THEN installSourcePackage returns the set package name
[task 2024-10-03T22:16:35.189Z]   SUCCESS
[task 2024-10-03T22:16:35.190Z] 
[task 2024-10-03T22:16:35.190Z]   TEST: checkAndSend() triggers the ping if it wasn't marked as triggered
[task 2024-10-03T22:16:35.489Z]     Exception in thread "DefaultDispatcher-worker-3 @coroutine#550" io.mockk.MockKException: no answer found for BrowserStore(#1383).getState() among the configured answers: ()
[task 2024-10-03T22:16:35.490Z]     at io.mockk.impl.stub.MockKStub.defaultAnswer(MockKStub.kt:93)
[task 2024-10-03T22:16:35.490Z]     at io.mockk.impl.stub.MockKStub.answer(MockKStub.kt:44)
[task 2024-10-03T22:16:35.490Z]     at io.mockk.impl.recording.states.AnsweringState.call(AnsweringState.kt:16)
[task 2024-10-03T22:16:35.490Z]     at io.mockk.impl.recording.CommonCallRecorder.call(CommonCallRecorder.kt:53)
[task 2024-10-03T22:16:35.490Z]     at io.mockk.impl.stub.MockKStub.handleInvocation(MockKStub.kt:271)
[task 2024-10-03T22:16:35.490Z]     at io.mockk.impl.instantiation.JvmMockFactoryHelper$mockHandler$1.invocation(JvmMockFactoryHelper.kt:24)
[task 2024-10-03T22:16:35.490Z]     at io.mockk.proxy.jvm.advice.Interceptor.call(Interceptor.kt:21)
[task 2024-10-03T22:16:35.490Z]     at mozilla.components.lib.state.Store.getState(Store.kt:67)
[task 2024-10-03T22:16:35.490Z]     at org.mozilla.fenix.distributions.DistributionIdUtilKt.getDistributionId(DistributionIdUtil.kt:36)
[task 2024-10-03T22:16:35.490Z]     at org.mozilla.fenix.distributions.DistributionIdUtilKt.getDistributionId$default(DistributionIdUtil.kt:32)
[task 2024-10-03T22:16:35.490Z]     at org.mozilla.fenix.components.metrics.FirstSessionPing$triggerPing$1.invokeSuspend(FirstSessionPing.kt:71)
[task 2024-10-03T22:16:35.490Z]     at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
[task 2024-10-03T22:16:35.490Z]     at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:104)
[task 2024-10-03T22:16:35.490Z]     at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:111)
[task 2024-10-03T22:16:35.490Z]     at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:99)
[task 2024-10-03T22:16:35.490Z]     at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584)
[task 2024-10-03T22:16:35.490Z]     at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:811)
[task 2024-10-03T22:16:35.490Z]     at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:715)
[task 2024-10-03T22:16:35.490Z]     at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:702)
[task 2024-10-03T22:16:35.490Z]     Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [CoroutineId(550), "coroutine#550":StandaloneCoroutine{Cancelling}@7416dfbf, Dispatchers.IO]
[task 2024-10-03T22:16:40.590Z]   TEST-UNEXPECTED-FAIL | org.mozilla.fenix.components.metrics.FirstSessionPingTest.checkAndSend() triggers the ping if it wasn't marked as triggered | java.lang.AssertionError: Verification failed: call 1 of 1: FirstSessionPing(#1384).markAsTriggered$app_fenixDebug()) was not called.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74017e7cc602
Adding google search codes for vivo deal.  Saving distribution Id in the browser store r=android-reviewers,amejiamarmol,gmalekpour

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1917939, Bug 1920176) for causing fenix failures in DistributionIdUtilTest CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=74017e7cc602a32fff7613203630312728898be8&selectedTaskRun=HpJpHhmLSL6h4HN6LB7snw.0

Log: https://treeherder.mozilla.org/logviewer?job_id=477153412&repo=autoland&lineNumber=18047

Backout: https://hg.mozilla.org/integration/autoland/rev/6b61eed2f732def30e1213feeb8ecdcb15687254

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b642baa12b2
Adding google search codes for vivo deal.  Saving distribution Id in the browser store r=android-reviewers,amejiamarmol,gmalekpour

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6b642baa12b2

Comment 9

[John Oberhauser]

Attachment: Bug 1920176 Adding google search codes for vivo deal. Saving distribution Id in the browser store

Original Revision: https://phabricator.services.mozilla.com/D223856

Comment 10

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: No user impact. Only business related impact.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: QE testing happened in nightly
• Risk associated with taking this patch: minimal
• Explanation of risk level: Patches touch telemetry and add vendor specific google search codes. Unit tests and QA have shown no regressions.
• String changes made/needed: none
• Is Android affected?: yes

Comment 11

[John Oberhauser]

Attachment: Bug 1920176 Adding google search codes for vivo deal. Saving distribution Id in the browser store

Original Revision: https://phabricator.services.mozilla.com/D223856

Comment 12

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: None, only business impacts.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: QE was done in nightly
• Risk associated with taking this patch: minimal
• Explanation of risk level: Patches touch telemetry and add vendor specific google search codes. Unit tests and QA have shown no regressions.
• String changes made/needed: none
• Is Android affected?: yes

Comment 13

[John Oberhauser]

Attachment: Bug 1920176 Adding google search codes for vivo deal. Saving distribution Id in the browser store

Original Revision: https://phabricator.services.mozilla.com/D223856

Comment 14

[John Oberhauser]

Attachment: Bug 1920176 Adding google search codes for vivo deal. Saving distribution Id in the browser store

Original Revision: https://phabricator.services.mozilla.com/D223856

Comment 15

[John Oberhauser]

Attachment: Bug 1920176 Adding google search codes for vivo deal. Saving distribution Id in the browser store

Original Revision: https://phabricator.services.mozilla.com/D223856

Comment 16

[John Oberhauser]

Attachment: Bug 1920176 Adding google search codes for vivo deal. Saving distribution Id in the browser store

Original Revision: https://phabricator.services.mozilla.com/D223856

Comment 17

[John Oberhauser]

Attachment: Bug 1920176 Adding google search codes for vivo deal. Saving distribution Id in the browser store

Original Revision: https://phabricator.services.mozilla.com/D223856

Comment 18

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: No user impact. Only business related impact.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: QE testing happened in nightly
• Risk associated with taking this patch: minimal
• Explanation of risk level: Patches touch telemetry and add vendor specific google search codes. Unit tests and QA have shown no regressions.
• String changes made/needed: none
• Is Android affected?: yes

Comment 19

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/abae8deecb6b