1920436 - messages.listAttachments() fails to list forwarded messages, which do not have a content-disposition header

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[John Bieling (:TbSync)]

See https://thunderbird.topicbox.com/groups/addons/T10a3b6ef4ef7b1c9-Mf759aca0e5faccf7fc3d6881

Comment 1

[John Bieling (:TbSync)]

Attachment: Bug 1920436 - Always handle forwarded messages as attachments, even if the content-disposition header is missing. r=#thunderbird-reviewers

This is a continuation of Bug 1898617. Our attachment detection code
missed some edge cases and did not consider inline forwarded messages as
attachments (which is what Thunderbird itself is doing). However, we
also missed to consider forwarded messages as attachments, which do not
have a content-disposition header at all.

This also adds a test for this additional edge case.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b9b900516349
Always handle forwarded messages as attachments, even if the content-disposition header is missing. r=tobyp

Comment 3

[John Bieling (:TbSync)]

Comment on attachment 9426429 [details]
Bug 1920436 - Always handle forwarded messages as attachments, even if the content-disposition header is missing. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): Cannot say which bug exactly, but caused by the new message parsing code used by the WebExtension API in TB128
User impact if declined: Some attachments are not considered as attachments and are not returned by messages.listAttachments()
Testing completed (on c-c, etc.): 21 days on c-c, 14 days on beta
Risk to taking this patch (and alternatives if risky): Moderate. Has a test.

Comment 4

[Corey Bryant]

Comment on attachment 9426429 [details]
Bug 1920436 - Always handle forwarded messages as attachments, even if the content-disposition header is missing. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr128

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 128.3.2esr:
https://hg.mozilla.org/releases/comm-esr128/rev/0022c1be7d06