1920586 - [wpt-sync] Sync PR 48318 - Fix <label>s for base-select custom <button>

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48318 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48318
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Fix <label>s for base-select custom <button>

This patch makes clicking on a label pointing to a base-select with an
author provided \<button> focus the \<button>, just like it focuses the
\<select> element itself when there is no author provided \<button>.

Change-Id: I12355e223de996138b64d9d9b17b8226eea6e06d

Reviewed-on: https://chromium-review.googlesource.com/5879535
WPT-Export-Revision: 9980854307a135b4e399504bf3ab05786fbaf466

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 48318 applied with additional changes from upstream: a05aea515ae7ed866237c0318fa6c05a9d31eeeb

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=93dd827f09c48fa33259ad9708e875ab2b936807

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

OK : 1
FAIL: 6

Chrome

OK : 1
PASS: 3
FAIL: 3

Safari

OK : 1
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/forms/the-select-element/customizable-select/select-mouse-behavior.tentative.html [wpt.fyi]
  • fallbackbutton: Select with appearance:base-select should open and close when clicking the button.: FAIL (Chrome: PASS, Safari: FAIL)
  • fallbackbutton: Clicking an option in an appearance:base-select select should choose the option and close the popover.: FAIL (Chrome: FAIL, Safari: FAIL)
  • fallbackbutton: Clicking the label should focus the select button without opening the picker.: FAIL (Chrome: PASS, Safari: FAIL)
  • custombutton: Select with appearance:base-select should open and close when clicking the button.: FAIL (Chrome: PASS, Safari: FAIL)
  • custombutton: Clicking an option in an appearance:base-select select should choose the option and close the popover.: FAIL (Chrome: FAIL, Safari: FAIL)
  • custombutton: Clicking the label should focus the select button without opening the picker.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/383bac001869
[wpt PR 48318] - Fix <label>s for base-select custom <button>, a=testonly
https://hg.mozilla.org/integration/autoland/rev/1bb8aac87970
[wpt PR 48318] - Update wpt metadata, a=testonly

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/383bac001869
https://hg.mozilla.org/mozilla-central/rev/1bb8aac87970