1920694 - Please create "thunderbird-data-reviewers" group and a matching Herald rule

Status: RESOLVED FIXED

(Conduit :: Phabricator, task)

Description

[Toby Pilling [:tobyp]]

For changes to data collection relating to Thunderbird, could you please create a thunderbird-data-reviewers group containing:

Andrei Hajdukewycz, https://phabricator.services.mozilla.com/p/sancus
Martin Giger, https://phabricator.services.mozilla.com/p/freaktechnik/
Magnus Melin, https://phabricator.services.mozilla.com/p/mkmelin/
Toby Pilling, https://phabricator.services.mozilla.com/p/tobyp/

Please also create a Herald rule to add the group as a blocking reviewer for patches that include keywords Glean or Telemetry in title, description or code. Is that possible?

Is it possible to inject a comment in addition? I was thinking that it would be helpful to add some text that will remind the team to submit a Data Review Request. If that's possible, could you please inject this comment:

DATA REVIEW REQUEST NEEDED?
If this change impacts user data collected, please follow the following protocol to submit a data review request:

https://wiki.mozilla.org/Data_Collection#Step_1:_Submit_Request
https://blog.mozilla.org/data/2021/09/07/this-week-in-glean-data-reviews-are-important-glean-parser-makes-them-easy/

Thank you!

Comment 1

[David Lawrence [:dkl]]

https://phabricator.services.mozilla.com/project/profile/214/

(In reply to Toby Pilling from comment #0)

Please also create a Herald rule to add the group as a blocking reviewer for patches that include keywords Glean or Telemetry in title, description or code. Is that possible?

We can look at the title of the title of the revision or text in a file name but probably not in the code itself.
I will attach a list of options for matching on.

Is it possible to inject a comment in addition? I was thinking that it would be helpful to add some text that will remind the team to submit a Data Review Request. If that's possible, could you please inject this comment:

We can add a comment but we will have to do in such a way that it doesn't re-add for each revision change. I think there is a way to do that.

Comment 2

[David Lawrence [:dkl]]

Attachment: image.png

Comment 3

[Toby Pilling [:tobyp]]

Thanks a lot David. Could we just match on title or summary including "glean" or "telemetry" - or affected files includes metrics.yaml?

Cheers

Comment 4

[David Lawrence [:dkl]]

Project:
https://phabricator.services.mozilla.com/project/profile/214

Herald:
https://phabricator.services.mozilla.com/H463
https://phabricator.services.mozilla.com/H464

We will give these a try for a bit to see if they are what you need and tweak as necessary.