1920771 - Allow onboarding to set sidebar.revamp on single select and next

Status: RESOLVED WORKSFORME

(Firefox :: Sidebar, task)

Description

[Ed Lee :Mardak]

To avoid existing users from getting sidebar.revamp set to true immediately on enrollment with bug 1895932 and later see an onboarding spotlight explaining horizontal vs vertical, the message should be the one setting sidebar.revamp pref on user interaction.

click horizontal: vertical = false, revamp = false
click vertical: vertical = true, revamp = true
click next: revamp = true

I believe this should be adding sidebar.revamp to https://searchfox.org/mozilla-central/rev/1e8cec3727d6e09f4af41bb3d202b7a4c326ed84/toolkit/components/messaging-system/lib/SpecialMessageActions.sys.mjs#221 then configuring the message bug 1919867 appropriately to use MULTI_ACTION and/or SET_PREF

Comment 1

[Meg Viar [:mviar]]

I'm adding sidebar.revamp to the allowed prefs for special message actions in this patch adding auto-triggering of the selected tile's action. However, given that patch's complexity and how late we are in the cycle, we might want to land the allowed pref update separately here to keep our options open. That one-line change allows up to change the sidebar.revamp pref using any special message action. As we're no longer setting that pref via nimbus for the experiment, this is necessary to allow other actions like changing tab orientation.

Comment 2

[Sarah Clements [:sclements]]

I'm adding sidebar.revamp to the allowed prefs for special message actions in this patch adding auto-triggering of the selected tile's action. However, given that patch's complexity and how late we are in the cycle, we might want to land the allowed pref update separately here to keep our options open.

I can land the sidebar.revamp pref as allowed in the SpecialMessageActions if needed (although Meg it looks like your patch is approved, so let me know if you think this is needed).

then configuring the message bug 1919867 appropriately to use MULTI_ACTION and/or SET_PREF

Could you clarify if you're asking for me to make an additional configuration change (please point to where specifically) or if this comment is just saying that we can use MULTI_ACTION in the JSON recipe with that above mentioned change.

Comment 3

[Sarah Clements [:sclements]]

Attachment: WIP: Bug 1920771 - Add sidebar.revamp to SpecialMessageActions r=#omc-reviewers

Comment 4

[Ed Lee :Mardak]

No code changes needed for MULTI_ACTION. This bug can be duped/resolved given bug 1920806, but if that patch isn't landing in time, this bug should be a 1 line fix of adding the pref

Comment 5

[Sarah Clements [:sclements]]

(In reply to Ed Lee :Mardak from comment #4)

No code changes needed for MULTI_ACTION. This bug can be duped/resolved given bug 1920806, but if that patch isn't landing in time, this bug should be a 1 line fix of adding the pref

Ok, I guess lets keep it open for now. I have the patch ready in case we need it.

Comment 6

[Meg Viar [:mviar]]

The patch for bug 1920806 is queued for landing.

Comment 7

[Sarah Clements [:sclements]]

Closing this out since bug 1920806 handles this and its on central now.