1920780 - jitsrc breaks on frames with no name

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P3)

Description

[Bryan Thrall [:bthrall]]

When the jitsrc (rr helper) command encounters frames without a name, it breaks:

Traceback (most recent call last):
File "/home/bryan/src/mozilla-unified/js/src/gdb/mozilla/jitsrc.py", line 156, in invoke
address = self.next_address(address)
File "/home/bryan/src/mozilla-unified/js/src/gdb/mozilla/jitsrc.py", line 137, in next_address
found = self.search_stack(*pattern, old)
File "/home/bryan/src/mozilla-unified/js/src/gdb/mozilla/jitsrc.py", line 128, in search_stack
if not re.match(name, f.name()):
File "/usr/lib/python3.10/re.py", line 190, in match
return _compile(pattern, flags).match(string)
TypeError: expected string or bytes-like object
Error occurred in Python: expected string or bytes-like object

If this happens enough times, rr runs out of internal watchpoints and stops working.

Comment 1

[Bryan Thrall [:bthrall]]

Attachment: Bug 1920780 - Fix jitsrc failure on frames without name, clean up internal watchpoints when "rc" fails r=mgaudet!

There appears to be no way to clean up internal watchpoints if "rc" fails,
other than quitting and restarting rr. This means after a few failures, rr
stops working because there are no more available hard watchpoints.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3750bed7393b
Fix jitsrc failure on frames without name, clean up internal watchpoints when "rc" fails r=iain

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3750bed7393b