1920832 - Add isProductSite to empty states in Review Checker sidebar

Status: RESOLVED FIXED

(Firefox :: Shopping, task, P2)

Description

[Fred Chasen [:fchasen]]

The empty state for the Review Checker sidebar will need more information from the actors to know if we are on a product site (but not a product page).

We should add a inProductSite check using the current toolkit url parsing, and pass the results of that instead of null on supported product sites.

Comment 1

[Fred Chasen [:fchasen]]

Attachment: WIP: Bug 1920832 - Add isSupportedSiteURL check and pass isEmpty and isSupportedSite to shopping content in updates.

Comment 2

[Fred Chasen [:fchasen]]

Attachment: Bug 1920832 - Add isSupportedSiteURL check and pass isProductPage and isSupportedSite to shopping content in updates. r?#shopping-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e78abc802629
Add isSupportedSiteURL check and pass isProductPage and isSupportedSite to shopping content in updates.  r=shopping-reviewers,kpatenio

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_integrated_sidebar.js

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9aa6fba18fe7
Add isSupportedSiteURL check and pass isProductPage and isSupportedSite to shopping content in updates.  r=shopping-reviewers,kpatenio

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/9aa6fba18fe7