1920942 - Make the duplicate frame interval in the Pacer mutable

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, task)

Description

[Andreas Pehrson [:pehrsons]]

It is currently immutable. With bug 1920687 we will want to change it depending on which FrameCadenceAdapter mode is in use.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1920942 - In WaitFor.h make functions work with both exclusive and non-exclusive event sources. r?jmaher!

This patch also cleans up includes and marks functions inline.

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1920942 - Make WaitFor(MediaEventSourceImpl&) work with any number of event params. r?jmaher!

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1920942 - In TakeN(MediaEventSourceImpl&) do not spin the event loop. r?jmaher!

Note this doesn't block the caller, which helps avoid hanging some tests, but
instead relies on the caller spinning the event loop. The latter typically
happens through WaitFor(RefPtr<MozPromise>).

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1920942 - Make Pacer's duplication interval mutable. r?#webrtc-reviewers

Comment 5

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1920942 - Update VideoFrameConverter logging. r?#webrtc-reviewers

This adds logging to Pacer<T>, which is currently only used by
VideoFrameConverter. It also updates VideoFrameConverter's own logging through a
dedicated macro, and puts both classes' on the MediaPipeline log module.

Comment 6

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1920942 - Improve VideoFrameConverterTest.NoConversionsWhileInactive. r?#webrtc-reviewers

Comment 7

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1920942 - Make TestVideoFrameConverter run faster with shorter duplication intervals. r?#webrtc-reviewers

Comment 8

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1920942 - In TestVideoFrameConverter turn IsFrameBlack into a matcher. r?#webrtc-reviewers

Comment 9

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1920942 - Disable VideoFrameConverter frame dropping for testing. r?#webrtc-reviewers

Comment 10

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1920942 - Allow 1us rounding error in VideoFrameConverterTest.TimestampPropagation. r?#webrtc-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7103b0ed880
In WaitFor.h make functions work with both exclusive and non-exclusive event sources. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/3a0274da9502
Make WaitFor(MediaEventSourceImpl&) work with any number of event params. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/fa25c14e9451
In TakeN(MediaEventSourceImpl&) do not spin the event loop. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/e7e6b555d8b2
Make Pacer's duplication interval mutable. r=webrtc-reviewers,ng
https://hg.mozilla.org/integration/autoland/rev/04a260ea11df
Update VideoFrameConverter logging. r=webrtc-reviewers,ng
https://hg.mozilla.org/integration/autoland/rev/878b0df5d9d1
Improve VideoFrameConverterTest.NoConversionsWhileInactive. r=webrtc-reviewers,ng
https://hg.mozilla.org/integration/autoland/rev/c66e6248ecd0
Make TestVideoFrameConverter run faster with shorter duplication intervals. r=webrtc-reviewers,ng
https://hg.mozilla.org/integration/autoland/rev/508fe4aa8e87
In TestVideoFrameConverter turn IsFrameBlack into a matcher. r=webrtc-reviewers,ng
https://hg.mozilla.org/integration/autoland/rev/94b2828d51cf
Disable VideoFrameConverter frame dropping for testing. r=webrtc-reviewers,ng
https://hg.mozilla.org/integration/autoland/rev/37a7d9addd13
Allow 1us rounding error in VideoFrameConverterTest.TimestampPropagation. r=webrtc-reviewers,ng

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b7103b0ed880
https://hg.mozilla.org/mozilla-central/rev/3a0274da9502
https://hg.mozilla.org/mozilla-central/rev/fa25c14e9451
https://hg.mozilla.org/mozilla-central/rev/e7e6b555d8b2
https://hg.mozilla.org/mozilla-central/rev/04a260ea11df
https://hg.mozilla.org/mozilla-central/rev/878b0df5d9d1
https://hg.mozilla.org/mozilla-central/rev/c66e6248ecd0
https://hg.mozilla.org/mozilla-central/rev/508fe4aa8e87
https://hg.mozilla.org/mozilla-central/rev/94b2828d51cf
https://hg.mozilla.org/mozilla-central/rev/37a7d9addd13