1921121 - [Desktop mode by default] Remove `Settings.openNextTabInDesktopMode`

Status: RESOLVED FIXED

(Firefox for Android :: Settings, task, P1)

Description

[Noah Bond [:007]]

Splitting this out from https://bugzilla.mozilla.org/show_bug.cgi?id=1910768#c16

We can safely remove the desktop mode toggle from within the Homepage menu (and its affiliated logic), as this is going away as part of the Menu redesign work and it'll greatly simplify adding the desktop mode by default feature.

Comment 1

[Noah Bond [:007]]

Attachment: Bug 1921121 - Remove `Settings.openNextTabInDesktopMode`

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40d0d6c43cbd
Remove `Settings.openNextTabInDesktopMode` r=android-reviewers,calu

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 40d0d6c43cbd (Bug 1921121) for causing lint fenix failures

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=40d0d6c43cbdffb43f2c944acf74d34b695899d9&selectedTaskRun=eac8Z0EISX6SiAff_nDHqQ.0

Log: https://treeherder.mozilla.org/logviewer?job_id=476323169&repo=autoland

Backout: https://hg.mozilla.org/integration/autoland/rev/382da1b8352071d3e029caa47f7f8ffe37331e36

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7dde70795ed0
Remove `Settings.openNextTabInDesktopMode` r=android-reviewers,calu

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7dde70795ed0

Comment 6

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Fenix Nightly 133.0a1 build from 10/3 with a Google Pixel 6 (Android 15), and a Xiaomi Mi8 Lite (Android 10).
The "Desktop site" option is no longer available in the main three-dot menu from the homepage.