1921380 - Update detekt to version 1.23.7 and clean up a lot of flagged issues

Status: RESOLVED FIXED

(Firefox for Android :: General, task)

Description

[Ryan VanderMeulen (PTO, back July 27)]

Release notes: https://github.com/detekt/detekt/releases/tag/v1.23.7

While I was working on this and updating the baselines, I decided to just clean up a lot of the flagged issues so now we're down to just a lot of undocumented classes/functions. And I have a plan for those too (eventually).

Green on Try: https://treeherder.mozilla.org/jobs?repo=try&revision=0a252998b35fe66202e00a8cb64942cb29fac9dd

Comment 1

[Ryan VanderMeulen (PTO, back July 27)]

Attachment: Bug 1921380 - Update detekt to version 1.23.7.

Comment 2

[Ryan VanderMeulen (PTO, back July 27)]

Attachment: Bug 1921380 - Fix some existing Focus detekt issues.

Comment 3

[Ryan VanderMeulen (PTO, back July 27)]

Attachment: Bug 1921380 - Fix some existing Fenix detekt issues.

Comment 4

[Ryan VanderMeulen (PTO, back July 27)]

Attachment: Bug 1921380 - Fix some existing AC detekt issues.

Comment 5

[Ryan VanderMeulen (PTO, back July 27)]

Attachment: Bug 1921380 - Regenerate detekt baselines.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ff885d717f5
Update detekt to version 1.23.7. r=android-reviewers,sfamisa
https://hg.mozilla.org/integration/autoland/rev/a866cb8bc275
Fix some existing Focus detekt issues. r=android-reviewers,sfamisa
https://hg.mozilla.org/integration/autoland/rev/14780ba4d15e
Fix some existing Fenix detekt issues. r=android-reviewers,jonalmeida
https://hg.mozilla.org/integration/autoland/rev/427e6d7c8718
Fix some existing AC detekt issues. r=android-reviewers,jonalmeida
https://hg.mozilla.org/integration/autoland/rev/e36b1dd0cf8a
Regenerate detekt baselines. r=android-reviewers,frontend-codestyle-reviewers,jonalmeida

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8ff885d717f5
https://hg.mozilla.org/mozilla-central/rev/a866cb8bc275
https://hg.mozilla.org/mozilla-central/rev/14780ba4d15e
https://hg.mozilla.org/mozilla-central/rev/427e6d7c8718
https://hg.mozilla.org/mozilla-central/rev/e36b1dd0cf8a