1921546 - Avoid superflous data storate for fuses

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P5)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

So our current set of fuses store some fairly superflous data

• EmulatesUndefined fuse stores the CompileRuntime
• RealmFuses store the realm

This is at least gently silly: These are both invariant over the course of a compilation.

One fix would be to stop storing this data, and instead providing it as arguments to checkDependency and registerDependency. But it's sort of awkward, because RealmFuse dependencies want a CompileRealm argument and EmulatesUndefinedDependency wants a CompileRuntime argument. It feels silly to pass both?

Potentially downstream of this may be the ability to remove the silly UniquePtr nonsense here.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Should be cautious here, because over-fixing on the current design may ultimately make something like https://phabricator.services.mozilla.com/D215566 too hard to do.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1921546 - Avoid superflous data storage for fuses r?jandem

Doesn't try to remove the UniquePtr stuff though, because I think we will
want that if we try to bring back the invalidation-for-generation-count,
and generally provides flexibility for the contents of a dependency

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ac82b3eea1f
Avoid superflous data storage for fuses r=jandem

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5ac82b3eea1f