Closed
Bug 1921576
Opened 1 year ago
Closed 11 months ago
Fix close / X button for integrated Review Checker
Categories
(Firefox Graveyard :: Shopping, defect, P2)
Firefox Graveyard
Shopping
Tracking
(firefox135 fixed)
RESOLVED
FIXED
135 Branch
| Tracking | Status | |
|---|---|---|
| firefox135 | --- | fixed |
People
(Reporter: kpatenio, Assigned: fchasen)
References
Details
(Whiteboard: [fidefe-RCSidebar])
Attachments
(1 file)
While integrated RC is still WIP, this is a reminder to verify the X button behaviour and ensure it closes the RC panel. At the moment, while the RC actors are not yet hooked up, pressing the X button nothing. We should also ensure that the vertical launcher is still visible after pressing X, even when hidden sidebar setting is true; inversely, pressing the sidebar toggle would close both the RC panel and the launcher.
Another option is to make use of the sidebar's optional X button instead, but doing so would force us to update the RC header and remove the Beta label from it.
Severity: -- → S3
Points: --- → 3
Priority: -- → P2
Whiteboard: [fidefe-RCSidebar]
|
||
Updated•1 year ago
|
|
Assignee | |
Updated•1 year ago
|
Assignee: nobody → fchasen
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•11 months ago
|
Attachment #9436073 -
Attachment description: WIP: Bug 1921576 - Fix close button for Review Checker sidebar. → Bug 1921576 - Fix close button for Review Checker sidebar. r?#shopping-reviewers
Pushed by fchasen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a43316dbc1d1
Fix close button for Review Checker sidebar. r=shopping-reviewers,firefox-desktop-core-reviewers ,kpatenio
|
||
Comment 3•11 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox135:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
|
||
Updated•6 months ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•