1921586 - Rapidly resizing the demo-pane on a Codepen demo makes the animation stop until you switch back to the tab (Best STR in comment #5)

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Mayank Bansal]

Enable gpu-canvas
Open https://lab.hakim.se/sphere/ in two foreground windows
Drag-and-resize one of the Windows horizontally (such that the other window/demo will resize) BUT keep on holding the mouse for maybe 10s.

AR: The demo in the resized window will become black and wont render at all. It will not fix even if you reload the window.
ER: Not so
Profile with graphics preset logging: https://share.firefox.dev/3zCcOr8
In about:support, you get these gfxlogs :
(#0) GP+[GFX1-]: RemoteTexture ready timeout
(#1) GP+[GFX1-]: RemoteTexture ready timeout

The STR are quite similar to bug 1899231

Comment 1

[Mayank Bansal]

Attachment: bandicam 2024-09-28 07-38-41-434.mp4

Comment 2

[Mayank Bansal]

Doesnt repro if I set gfx.canvas.remote.use-canvas-translator-event = False.
Tentatively marking regressed by on bug 1899231

Comment 3

[Mayank Bansal]

Attachment: about:support

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:sotaro, since you are the author of the regressor, bug 1899231, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 5

[Mayank Bansal]

Another STR is:
Go to https://codepen.io/Mertl/pen/vYPXMao
Once the demo starts, quickly and continuously keep on resizing the demo-pane horizontally making sure to move the slider maximum possible each side.
After 5s-10s, the demo will stop animating.
Profile with graphics logging preset: https://share.firefox.dev/3TMOc5Z

This STR is very similar to https://bugzilla.mozilla.org/show_bug.cgi?id=1898650#c6

Comment 6

[Mayank Bansal]

Even simpler STR:

1. enable gpu-canvas.
2. go to https://lab.hakim.se/sphere/
3. drag the tab to make a new window.
4. Rapidly resize the window diagonally.
   AR: After 5s-10s, the demo will stop painting nad wont resize.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1899231

Comment 8

[Mayank Bansal]

Slightly retitling the bug to match with the best STR of comment #5.

Comment 9

[Mayank Bansal]

Attachment: Demonstration for STR in comment #5.mp4

Comment 10

[Ashley Hale [:ahale]]

Has this issue been fixed by the patch that landed on Bug 1899231 some time ago?

Comment 11

[Mayank Bansal]

No, it is regressed by that bug.

Comment 12

[Donal Meehan [:dmeehan]]

(In reply to Ashley Hale [:ahale] from comment #10)

Has this issue been fixed by the patch that landed on Bug 1899231 some time ago?

Are there any updates since this was triaged? Bug 1910138 enabled this for Fx133.
Wondering about expectations for a fix in time for Fx133. Next week is the final week of beta for Fx133.

Comment 13

[Lee Salzman [:lsalzman]]

I don't know that Sotaro has the opportunity to investigate this in time, so I am marking this as fix-optional as it seems like something that shouldn't be a release blocker.

Comment 14

[Sotaro Ikeda [:sotaro]]

The problem seemed to happen when pending CanvasTranslator events were cleared in CanvasTranslator::ActorDestroy().

It happened when CanvasChild was destroyed in CanvasManagerChild::EndCanvasTransaction().

Comment 15

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1921586 - Handle pending CanvasTranslator events cleared by CanvasChild destroy

Comment 16

[Sotaro Ikeda [:sotaro]]

The problem was triggered by destroying CanvasChild in CanvasManagerChild::EndCanvasTransaction() by mCanvasChild->ShouldBeCleanedUp() == true.

Then if mCanvasChild->ShouldBeCleanedUp() == false during handling Texture in CanvasTranslator. The problem seemed not happen. It could be possible, by holding RefPtr<CanvasDrawEventRecorder>.

Comment 17

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1921586 - Do not destroy CanvasChild when texture is alive in CanvasTranslator

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb3bf13757a1
Do not destroy CanvasChild when texture is alive in CanvasTranslator r=lsalzman

Comment 19

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/fb3bf13757a1

Comment 20

[Mayank Bansal]

This is fixed for me in the latest Nightly.

Comment 21

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sotaro, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Comment 22

[Ada C.]

I was able to reproduce the issue on Windows 10 x64 using Firefox build 131.0a1 (2024-09-27).
Verified as fixed on Windows 10 x64 using Firefox build 136.0a1 and 135.0b9.