Closed
Bug 1921872
Opened 1 year ago
Closed 1 year ago
Fix up ShallowSizeOfIncludingThis for AttrAtomArray
Categories
(Core :: DOM: Core & HTML, task)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
133 Branch
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
nsAttrValue::SizeOfExcludingThis calls ShallowSizeOfIncludingThis on an interior field mArray of AttrAtomArray. This is okay for now because this == &mArray, but it is fragile. This patch adds a helper method ShallowSizeOfIncludingThis that should correctly calculate the size.
| Assignee | ||
Comment 1•1 year ago
|
||
The current approach is only okay because mArray is located at the
start of AttrAtomArray.
Also fix a few separatly typos.
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/95a3393e51af
Fix ShallowSizeOfIncludingThis for AttrAtomArray. r=dom-core,jjaschke
Comment 3•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox133:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
| Assignee | ||
Updated•1 year ago
|
status-firefox131:
--- → wontfix
status-firefox132:
--- → wontfix
status-firefox-esr115:
--- → wontfix
status-firefox-esr128:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•