Closed Bug 1921872 Opened 1 year ago Closed 1 year ago

Fix up ShallowSizeOfIncludingThis for AttrAtomArray

Categories

(Core :: DOM: Core & HTML, task)

task

Tracking

()

RESOLVED FIXED
133 Branch
Tracking Status
firefox-esr115 --- wontfix
firefox-esr128 --- wontfix
firefox131 --- wontfix
firefox132 --- wontfix
firefox133 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

nsAttrValue::SizeOfExcludingThis calls ShallowSizeOfIncludingThis on an interior field mArray of AttrAtomArray. This is okay for now because this == &mArray, but it is fragile. This patch adds a helper method ShallowSizeOfIncludingThis that should correctly calculate the size.

The current approach is only okay because mArray is located at the
start of AttrAtomArray.

Also fix a few separatly typos.

Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/95a3393e51af Fix ShallowSizeOfIncludingThis for AttrAtomArray. r=dom-core,jjaschke
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: