1922137 - Bookmarks are not deleted if we leave the panel before the snackbar is dismissed

Status: VERIFIED FIXED

(Firefox for Android :: Bookmarks, defect, P3)

Description

[Matt Tighe [:matt-tighe]]

Steps to reproduce

Delete a bookmark and then immediately exit bookmarks

Expected behavior

The bookmark is deleted

Actual behavior

The bookmark is not deleted

Comment 1

[Matt Tighe [:matt-tighe]]

Attachment: Bug 1922137 - Complete pending deletion when view is disposed

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abd4cace8c00
Complete pending deletion when view is disposed r=android-reviewers,boek

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out 4 changesets (Bug 1922134, Bug 1922140, Bug 1922137, Bug 1922701) for causing fenix failures on BookmarksReducerTest.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=130d2b29f39832023526989eaeae0ed7e12200a1&selectedTaskRun=FLIZj0LLRUmDqlz7Sp1r0g.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=477458132&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/e2a5988f2ba0cb142052882d153f55559d32d436

Comment 4

[Matt Tighe [:matt-tighe]]

Attachment: Bug 1922137 - Complete pending deletion when view is disposed

Original Revision: https://phabricator.services.mozilla.com/D224565

Comment 5

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Bookmarks MVP + 1 is not released to users
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: None
• Explanation of risk level: Behind a Nimbus flag
• String changes made/needed: None
• Is Android affected?: yes

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a929b186abc
Complete pending deletion when view is disposed r=android-reviewers,boek

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5a929b186abc

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e2ed554c1d4c

Comment 9

[Mira Lobontiu (Android QA)]

Verified as fixed on the Fenix Nightly 133.0a1 from 10/13 with Realme GT Master Edition (Android 13), and a Samsung Galaxy Tab S9 Ultra (Android 14).

I am unable to also verify on Beta, because the "Enable compose bookmarks" is not available yet in Beta 132.0b6.

Comment 10

[Mira Lobontiu (Android QA)]

Verified as fixed also on the Fenix Beta 132.0b8 with:

• Oppo Find X3 Lite (Android 11), and
• Google Pixel 6 (Android 15).