Closed Bug 1922193 Opened 2 years ago Closed 1 year ago

Sending multiple (unknown) cookies with same name

Categories

(Core :: Networking: Cookies, defect, P2)

Firefox 131
defect

Tracking

()

RESOLVED FIXED
134 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox131 --- disabled
firefox132 --- disabled
firefox133 --- disabled
firefox134 --- fixed

People

(Reporter: corgrath, Assigned: timhuang, NeedInfo)

References

Details

(Keywords: webcompat:platform-bug, Whiteboard: [necko-triaged])

Attachments

(1 file, 6 external files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:131.0) Gecko/20100101 Firefox/131.0

Steps to reproduce:

Background: I am using Firefox 131 (64bit) on Windows 10 towards my own local web server.

I am visiting a page / refreshing a page.

Actual results:

On the initial HTTP GET request to fetch the page/resource, Firefox is sending the cookie header:

Cookie: keystone-session-1=zxy9ifgh; keystone-session-1=o1ukqfle

Meaning two cookies with the same name.

However, when looking at my saved Cookies in the Storage tab in Developer Tools, can only see one single cookie.

At any given time there is only one Cookie present in Developer Tools.

Expected results:

Firefox should only send one cookie, the one that is present in the Storage Cookies tab.

I don't understand / I cannot see where the cookie "keystone-session-1=zxy9ifgh;" is coming from, but it is added to all requests.

Additional comment: The reason why the request is adding a new "keystone-session-1" cookie but with different values, is because my webserver is getting two cookies with the same name ("keystone-session-1") from Firefox, as seen in my screenshot.

Because two cookies with the same name is sent to my web server, my web server responds with a "add cookies" with a new ID. This is expected behavior.

What is not expected:
I don't understand why Firefox is sending "keystone-session-1=zxy9ifgh;". I cannot find this key+value anywhere in any views in Firefox.

(Clearing cookies and restarting the browser has no effect)

The Bugbug bot thinks this bug should belong to the 'Core::Networking: Cookies' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Networking: Cookies
Product: Firefox → Core

The spec allows for multiple cookies of the same name to exist provided that the path or domain attribute has been set differently. So it is the server's responsibility to be able to parse multiple cookies of the same name when it receives a Cookie header. Though the server owner may want to re-consider how they are using the Domain attribute across the sub domains.

As for the displaying of that cookie (or lack thereof), this does seem like an issue here. Though, I was not able to reproduce using document.cookie with different domain values across sub-domains of a remote website.

I also noticed in the attached image that devtools is displaying duplicate lines of HttpOnly with two different values. This is highly suspicious.
Using devtools to create httponly cookies with different domains I was able to reproduce the duplicate lines with different values, but not the original issue where the value is hidden to the user. I suspect this must be elicited from the HTTP Set-Cookie header and will give this another try when I get a moment.

One thing that could help us here is a look at the cookie DB entry of the cookie that you are unable to see.
Could you use a tool like sqlitebrowser (https://sqlitebrowser.org/) to open your cookies.sqlite DB and provide all the values of this entry?
You can find the location of cookies.sqlite by checking about:support > Profile Directory
Note that you may want to occlude any session token values if your server is remotely accessible.

Also, server-side are you aware of any changes recently to the HttpOnly state of the cookies sent via Set-Cookie response?

Thanks!

Flags: needinfo?(corgrath)
Flags: needinfo?(edgul)

Hey

First of all, I should say that this behavior occurred when Firefox upgraded from 130 to 131 (I know this since session "zxy9ifgh" has the user agent "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:130.0) Gecko/20100101 Firefox/130.0" in my database.

I know technically, or according to specifications, multiple cookies with the same name might exist, but in this case, the only difference is the name. All other data is (apart from value) is the same.

Also, server-side are you aware of any changes recently to the HttpOnly state of the cookies sent via Set-Cookie response?

My cookies has always been HttpOnly to true since multiple years back. Nothing has changed regarding cookies in my my web server logic.

The only thing, afaik, that has changed is that my browser upgraded from 130 to 131, and with that the User Agent string got upgraded, and my web server generated a new session ID and did a new "Set-Cookie" with a new value. And it kept generating a new session ID / Cookie value, since "keystone-session-1=zxy9ifgh;" was always sent regardless.

What I don't understand is why Firefox is still appending "keystone-session-1=zxy9ifgh;".

One thing that could help us here is a look at the cookie DB entry of the cookie that you are unable to see.

Okay, in my profile folder I see two files associated with cookies;

  • cookies.sqlite from 2024-10-02 17:52 (meaning, right now)
  • cookies.sqlite.bak from 2023-06-26

Opening cookies.sqlite from now and searching for the name, I do see the two different cookies (keystone-session-1=zxy9ifgh and keystone-session-1=szmgw03y).

The ONLY difference I see between those two rows is that "originAttributes" contains "^partitionKey=%28http%2Conline.localhost%29" on "keystone-session-1=zxy9ifgh" - the cookies that is mysteriously being appended.

I have exported both values to a JSON:

[
{
"creationTime": 1725816976905000,
"expiry": 1741596976,
"host": ".online.localhost",
"id": 43544821,
"inBrowserElement": 0,
"isHttpOnly": 1,
"isPartitionedAttributeSet": 0,
"isSecure": 0,
"lastAccessed": 1727883488245000,
"name": "keystone-session-1",
"originAttributes": "^partitionKey=%28http%2Conline.localhost%29",
"path": "/",
"rawSameSite": 0,
"sameSite": 1,
"schemeMap": 1,
"value": "zxy9ifgh"
},
{
"creationTime": 1727858095038000,
"expiry": 1743640692,
"host": ".online.localhost",
"id": 45879303,
"inBrowserElement": 0,
"isHttpOnly": 1,
"isPartitionedAttributeSet": 0,
"isSecure": 0,
"lastAccessed": 1727883488245000,
"name": "keystone-session-1",
"originAttributes": "",
"path": "/",
"rawSameSite": 0,
"sameSite": 1,
"schemeMap": 1,
"value": "szmgw03y"
}
]

The only significant difference is ""originAttributes": "^partitionKey=%28http%2Conline.localhost%29",".

Okay - I don't want to edit this file or do anything else until you tell me what to do :)

I don't want to ruin your troubleshooting :)

Flags: needinfo?(corgrath)

This is really my note area, but it makes sense that Firefox is sending

Cookie: keystone-session-1=zxy9ifgh; keystone-session-1=o1ukqfle

If both exists in the database. That makes sense.

However, the question are perhaps;

  1. How come the cookie got ""originAttributes": "^partitionKey=%28http%2Conline.localhost%29",". Is that something that happens internally that is associated with Firefox going from 130 to 131.

  2. Is ""originAttributes": "^partitionKey=%28http%2Conline.localhost%29"," making the cookie being hidden in Developer Tools.

  3. Is ""originAttributes": "^partitionKey=%28http%2Conline.localhost%29"," making the cookie so unique that "Set-Cookie" does not update that specific entry.

Looking forward to hearing your thoughts!

Tim, this seems like it might be an edge case of CHIPS, any thoughts?

Flags: needinfo?(edgul) → needinfo?(tihuang)

Oh, one more thing. It is very possible this bug occurred because I force-quit Firefox via Windows Taskmanager (because the RAM usage was going bananas), so next time it restarted, Firefox auto updated to 131.

And in that whole chain of event, "^partitionKey=%28http%2Conline.localhost%29"," was added, hence my firefox is now always sending that cookie in each request, and I have no way to.. make it stop.

Unless, I modify this cookies.sqlite file, I suppose. But I don't want to do that, until you guys say its okay.

We are experiencing a very similar problem.

Our app sends session cookies with the Partitioned attribute. If a user was already logged in to our site and then upgraded to Firefox 131, they will now have two cookies, identical except for one being partitioned and the other one not.
Looking at the cookies.sqlite I see the same as Christoffer, one has partitionKey and the other one not.
Only the unpartitioned one is shown in the "Storage" tab of the browser devtools, but both cookies are sent with each request to the server.

This breaks our logout, because the server sends a set-cookie header with the Partitioned attribute, meaning that Firefox will only delete the partitioned cookie. Therefore the user will actually stay logged in and will get a new partitioned cookie with the subsequent requests, bringing us back to square one.

This forced us to implement the clearing of the unpartitioned session cookie (in addition to our standard clearing of the session cookie with the Partitioned attribute) too as a workaround for Firefox.

Looking at the JSON, the cookie with the partitionKey is partitioned under the same domain as the host. So, it's a first-party partition cookie. This means the cookie is set with the Partitioned cookie attribution. The other cookie was set without the Partitioned cookie attribution because it doesn't have the partitionKey, so it's a regular first-party(unpartitioned) cookie.

In CHIPS, the top-level context can access both partitioned and unpartitioned cookies, which is why there are two cookies with the same name but different values. We are still working on supporting CHIPS in Devtools, Bug 1895215, so it will be easier for developers to manipulate CHIPS cookies.

Flags: needinfo?(tihuang)

We're also seeing this issue with a bunch of users starting with FF 131. In our case we don't (intentionally) use partitioned cookies. However we do use SameSite=None,Secure=True which - judging from the changelog - has had some changes in FF. We're not seeing these issues on other browsers or earlier versions.

We have been able to repro this on some of our machines, so I'll try to get a dump of cookies.sqlite asap, but wanted to check if SameSite=None is supposed to allow duplicates/implicitly set a partitionKey as well? From Tim's message it sounded like duplicates were intended to be possible if they're partitioned, however that's definitely unexpected/unintended from our side.

This sounds like a recent regression.
Could you try to use mozregression to help us find out the regression range?
Thanks.

Flags: needinfo?(corgrath)
Flags: needinfo?(bugzilla)
See Also: → 1923663
Assignee: nobody → tihuang
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by tihuang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9aa373dda3fb Initiate the isPartitioned() value before parsing the cookie attributions. r=valentin,cookie-reviewers
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
Attachment #9430970 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: Users could get unexpected first-party partitioned cookies. This could break websites.
  • Code covered by automated testing: no
  • Fix verified in Nightly: yes
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing: None. It's hard to reproduce.
  • Risk associated with taking this patch: low
  • Explanation of risk level: This is only one line change and it doesn't change any functionalities
  • String changes made/needed: None
  • Is Android affected?: yes

Tim, could you also write a test/WPT for this?

Flags: needinfo?(tihuang)
Blocks: 1923663
Attachment #9430970 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Hello Sebastian,

Thanks for the comment on the issue. Have you had the chance to get a dump of cookies.sqlite? It will help us understand the issue more.

Hi Tim,

Yes, I had a look at one of the dumps that naturally occurred and it matched the previously mentioned scenario on this ticket - cookies are equal except for partitionKey, even though we never explicitly opt-in to partitioning.

We've unfortunately been unable to trigger this scenario intentionally. We originally thought this was caused by the 130 -> 131 update cycle, but judging by the posted patches the update itself wouldn't be necessary? The only way we were somewhat able to get us in a similar situation for remediation testing was by deliberately setting document.cookies="foo=bar; Partitioned".

Flags: needinfo?(bugzilla)

I don't think we've fully resolved this issue, because I am easily able to re-create duplicate cookies simply by enabling CHIPS and returning to a previously used site that sets the Partitioned attribute. So while the partition attribute bit in the DB did look like an issue:
a) I don't think we can say yet we've resolved the problem there
b) and the duplicate cookie sending can be reproduced without an uninitialized partAttr field
Though it may be harder to encounter now (?)

What we need to know now is if there is anyone who experienced login issues before (the patch above was landed) that is still having login issues or if they are able to re-create a login failure with some of the following steps:

Preamble

The following scenario was created with a local server and setting cookies via document.cookie on the most recent version of nightly.
You may want to try performing similar cookie setting via HTTP headers (and let me know if that also works).
CHIPS mode can be controlled (enabled/disabled) in about:config: with the setting network.cookie.CHIPS.enabled

Turning CHIPS on can easily result in duplicate cookies (with DB partAttr set)

Setting cookie via document.cookie, v131.0.3 and nightly 133:

  1. with chips off, set cookie with partitioned attr
    document.cookie = "part=chipsOff; Secure; Partitioned; Max-Age=9000"
  2. turn on chips, set another partitioned cookie of same name and different value
    document.cookie = "part=chipsON; Secure; Partitioned; Max-Age=9000"
    (interestingly devtools-storage shows the change, but only until another network request is made)
  3. refresh page
    notice request header: Cookie: part=chipsOff; part=chipsON
    devtools-storage: one cookie: part=chipsOff
  4. close fx and open cookies.sqlite w sqlitebrowser
    notice: two cookies, with same everything except value and OA:
    1	  (no OA/partitionKey) 	part	chipsOff	localhost	/	1729194472	1729185640306116	1729185472895365	1	0	0	1	0	1	1
    2	^partitionKey=%28http%2Clocalhost%2C8000%29	part	chipsON	localhost	/	1729194553	1729185640306144	1729185553660830	1	0	0	1	0	1	1
  1. Side note: if we disable CHIPS then we will only send the partitioned cookies set from CHIPS mode (as expected)
    And re-enabling CHIPS restores the duplicate cookie header behaviour (as expected)

Cookie clearing CAN resolve the issue, but only with client side control

  • if CHIPS is still enabled then "part=clear; Partitioned; Secure; expires=Thu, Jan 01 1970 00:00:00 UTC"
    does NOT clear part=chipsOff, only part=chipsON will be removed from DB and subsequent request
  • if CHIPS is disabled then the same cookie will remove it (from DB and subsequent requests)
  • indifferent of CHIPS mode, via the address bar clear cookies and site data seems to clear both values
  • (I would expect the same from history/settings cookie clearing)
  • devtools: regardless of CHIPS mode, regardless of before/after the first request is made
  •       devtools can only delete the `part=chipsOFF` cookie
          (even with right click > delete all)
    

Thanks for all the help folks.

Status: RESOLVED → REOPENED
Flags: needinfo?(lg)
Flags: needinfo?(bugzilla)
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Target Milestone: 133 Branch → ---

Closing the loop on this for us: We managed to identify this case (since both cookies show up in document.cookies, we can identify the duplicate) and worked around it by expiring both Partitioned and un-Partitioned cookie via JS, to then be re-set by the server after a page reload. Judging from server logs, this seems to have recovered a significant numbers of impacted users, the remaining hits I'm seeing might not be due to this issue (roundabout way of identification). Since we never use Partitioned, I'm assuming the previous patch should fix the issue for our case at least.

Flags: needinfo?(bugzilla)
Attachment #9431815 - Attachment description: Bug 1922193 - Cleanup invalid first-party partitioned cookies in the cookie DB. r?valentin → Bug 1922193 - Cleanup invalid first-party partitioned cookies in the cookie DB. r?valentin!
Pushed by bvandersloot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eaf6d254dde1 Drop first-party partitioned cookies that don't have CHIPS. r=valentin,cookie-reviewers,edgul https://hg.mozilla.org/integration/autoland/rev/72cf46f0f246 Cleanup invalid first-party partitioned cookies in the cookie DB. r=valentin,cookie-reviewers,edgul https://hg.mozilla.org/integration/autoland/rev/d76bfc18f2d2 Add telemetry probes for invalid first party partitioned cookies. r=valentin,cookie-reviewers,edgul
Backout by amarc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f92b711812c7 Backed out 3 changesets for causing multiple failures. CLOSED TREE

Backed out for causing xpcshell failures @ test_ext_cookies_partitionKey.js

[task 2024-10-22T15:05:58.109Z] 15:05:58     INFO -  TEST-PASS | toolkit/components/telemetry/tests/unit/test_TelemetryEnvironment.js | took 4859ms
[task 2024-10-22T15:05:58.113Z] 15:05:58     INFO -  TEST-START | toolkit/components/telemetry/tests/unit/test_UserInteraction_annotations.js
[task 2024-10-22T15:05:58.113Z] 15:05:58     INFO -  TEST-SKIP | toolkit/components/telemetry/tests/unit/test_UserInteraction_annotations.js | took 0ms
[task 2024-10-22T15:05:58.113Z] 15:05:58     INFO -  Retrying tests that failed when run in parallel.
[task 2024-10-22T15:05:58.117Z] 15:05:58     INFO -  TEST-START | xpcshell-remote.toml:toolkit/components/extensions/test/xpcshell/test_ext_cookies_partitionKey.js
[task 2024-10-22T15:06:06.056Z] 15:06:06  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell-remote.toml:toolkit/components/extensions/test/xpcshell/test_ext_cookies_partitionKey.js | xpcshell return code: -11
[task 2024-10-22T15:06:06.056Z] 15:06:06     INFO -  TEST-INFO took 7938ms
[task 2024-10-22T15:06:06.056Z] 15:06:06     INFO -  >>>>>>>
[task 2024-10-22T15:06:06.057Z] 15:06:06     INFO -  PID 23541 | [Parent 23541, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp:2897
[task 2024-10-22T15:06:06.057Z] 15:06:06     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2024-10-22T15:06:06.057Z] 15:06:06     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2024-10-22T15:06:06.057Z] 15:06:06     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2024-10-22T15:06:06.057Z] 15:06:06     INFO -  running event loop
[task 2024-10-22T15:06:06.062Z] 15:06:06     INFO -  xpcshell-remote.toml:toolkit/components/extensions/test/xpcshell/test_ext_cookies_partitionKey.js | Starting setup check_remote
[task 2024-10-22T15:06:06.062Z] 15:06:06     INFO -  (xpcshell/head.js) | test check_remote pending (2)
[task 2024-10-22T15:06:06.063Z] 15:06:06     INFO -  TEST-PASS | xpcshell-remote.toml:toolkit/components/extensions/test/xpcshell/test_ext_cookies_partitionKey.js | check_remote - [check_remote : 1] useRemoteWebExtensions matches - true == true

Backed out for causing bc failures @ CookieStorage.cpp
————————————————————————————

[task 2024-10-22T15:06:18.509Z] 15:06:18     INFO - GECKO(8586) | [Child 11168: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 8 (7fb21fcc5400) [pid = 11168] [serial = 8] [outer = 7fb23f78f000]
[task 2024-10-22T15:06:18.720Z] 15:06:18     INFO - GECKO(8586) | [Parent 8586, DOMCacheThread] WARNING: QM_TRY failure (WARNING): '"ToResult(file->Remove( false))" failed with resultCode 0x80520012, resultName NS_ERROR_FILE_NOT_FOUND', file dom/cache/FileUtils.cpp:809
[task 2024-10-22T15:06:18.721Z] 15:06:18     INFO - GECKO(8586) | [Parent 8586, DOMCacheThread] WARNING: QM_TRY failure (WARNING): '"ToResult(file->Remove( false))" failed with resultCode 0x80520012, resultName NS_ERROR_FILE_NOT_FOUND', file dom/cache/FileUtils.cpp:809
[task 2024-10-22T15:06:18.755Z] 15:06:18     INFO - GECKO(8586) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpgq6xzhtz.mozrunner/runtests_leaks_tab_pid11326.log
[task 2024-10-22T15:06:18.780Z] 15:06:18     INFO - GECKO(8586) | [Child 11326, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:757
[task 2024-10-22T15:06:18.889Z] 15:06:18     INFO - GECKO(8586) | [Parent 8586, Main Thread] WARNING: 'NS_FAILED(rr->RetargetDeliveryTo(queue))', file /builds/worker/checkouts/gecko/dom/fetch/FetchDriver.cpp:1368
[task 2024-10-22T15:06:18.921Z] 15:06:18     INFO - GECKO(8586) | [8586] Assertion failure: false, at /builds/worker/checkouts/gecko/netwerk/cookie/CookieStorage.cpp:612
[task 2024-10-22T15:06:18.925Z] 15:06:18     INFO -  Initializing stack-fixing for the first stack frame, this may take a while...
[task 2024-10-22T15:06:31.081Z] 15:06:31     INFO - GECKO(8586) | #01: mozilla::net::CookieStorage::AddCookie(mozilla::net::CookieParser*, nsTSubstring<char> const&, mozilla::OriginAttributes const&, mozilla::net::Cookie*, long, nsIURI*, nsTSubstring<char> const&, bool, bool, mozilla::dom::BrowsingContext*, nsID const*) [netwerk/cookie/CookieStorage.cpp:612]
[task 2024-10-22T15:06:31.081Z] 15:06:31     INFO - GECKO(8586) | #02: mozilla::net::CookieService::SetCookieStringFromHttp(nsIURI*, nsTSubstring<char> const&, nsIChannel*) [netwerk/cookie/CookieService.cpp:619]
[task 2024-10-22T15:06:31.081Z] 15:06:31     INFO - GECKO(8586) | #03: mozilla::net::nsHttpChannel::ContinueProcessResponse1() [netwerk/protocol/http/nsHttpChannel.cpp:2703]
[task 2024-10-22T15:06:31.082Z] 15:06:31     INFO - GECKO(8586) | #04: mozilla::net::nsHttpChannel::ProcessResponse() [netwerk/protocol/http/nsHttpChannel.cpp:0]
[task 2024-10-22T15:06:31.082Z] 15:06:31     INFO - GECKO(8586) | #05: mozilla::net::nsHttpChannel::OnStartRequest(nsIRequest*) [netwerk/protocol/http/nsHttpChannel.cpp:0]
[task 2024-10-22T15:06:31.083Z] 15:06:31     INFO - GECKO(8586) | #06: mozilla::net::HttpTransactionParent::DoOnStartRequest(nsresult const&, mozilla::Maybe<mozilla::net::nsHttpResponseHead> const&, nsITransportSecurityInfo*, bool const&, mozilla::net::TimingStructArgs const&, int const&, nsTArray<unsigned char>&&, mozilla::Maybe<nsTString<char> > const&, bool const&, bool const&, unsigned int const&, bool const&, nsIRequest::TRRMode const&, nsITRRSkipReason::value const&, unsigned int const&, mozilla::TimeStamp const&) [netwerk/protocol/http/HttpTransactionParent.cpp:505]
[task 2024-10-22T15:06:31.083Z] 15:06:31     INFO - GECKO(8586) | #07: std::_Function_handler<void (), mozilla::net::HttpTransactionParent::RecvOnStartRequest(nsresult const&, mozilla::Maybe<mozilla::net::nsHttpResponseHead> const&, nsITransportSecurityInfo*, bool const&, mozilla::net::TimingStructArgs const&, int const&, nsTArray<unsigned char>&&, mozilla::Maybe<nsTString<char> > const&, bool const&, bool const&, unsigned int const&, bool const&, nsIRequest::TRRMode const&, nsITRRSkipReason::value const&, unsigned int const&, mozilla::TimeStamp const&)::$_0>::_M_invoke(std::_Any_data const&) [/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/8/bits/std_function.h:299]
[task 2024-10-22T15:06:31.084Z] 15:06:31     INFO - GECKO(8586) | #08: mozilla::net::ChannelEventQueue::RunOrEnqueue(mozilla::net::ChannelEvent*, bool) [netwerk/ipc/ChannelEventQueue.h:266]
[task 2024-10-22T15:06:31.085Z] 15:06:31     INFO - GECKO(8586) | #09: mozilla::net::HttpTransactionParent::RecvOnStartRequest(nsresult const&, mozilla::Maybe<mozilla::net::nsHttpResponseHead> const&, nsITransportSecurityInfo*, bool const&, mozilla::net::TimingStructArgs const&, int const&, nsTArray<unsigned char>&&, mozilla::Maybe<nsTString<char> > const&, bool const&, bool const&, unsigned int const&, bool const&, nsIRequest::TRRMode const&, nsITRRSkipReason::value const&, unsigned int const&, mozilla::TimeStamp const&) [netwerk/protocol/http/HttpTransactionParent.cpp:418]
[task 2024-10-22T15:06:31.085Z] 15:06:31     INFO - GECKO(8586) | #10: mozilla::net::PHttpTransactionParent::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources:6f4ca32e55de93d6d40f0ee0146aae2220726419dc4df1ca015fa6081a4d846fce66d4804ff4aa047c4d8194f74be1ee820bf50c1a2fe55c082e98e8a1715e7a/ipc/ipdl/PHttpTransactionParent.cpp::631]
[task 2024-10-22T15:06:31.086Z] 15:06:31     INFO - GECKO(8586) | #11: mozilla::net::PSocketProcessParent::OnMessageReceived(IPC::Message const&) [s3:gecko-generated-sources:929d08338c8074624105cdca27b905f927224b2e58e2058086a746331d356683fe4b4a92e5dca6eeab5738831bf05e000ba8b5a9b41341e6afa1e9ac9e8219bb/ipc/ipdl/PSocketProcessParent.cpp::2302]
[task 2024-10-22T15:06:31.086Z] 15:06:31     INFO - GECKO(8586) | #12: mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) [ipc/glue/MessageChannel.cpp:1726]
[task 2024-10-22T15:06:31.086Z] 15:06:31     INFO - GECKO(8586) | #13: mozilla::ipc::MessageChannel::DispatchMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::UniquePtr<IPC::Message, mozilla::DefaultDelete<IPC::Message> >) [ipc/glue/MessageChannel.cpp:0]
[task 2024-10-22T15:06:31.087Z] 15:06:31     INFO - GECKO(8586) | #14: mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::ActorLifecycleProxy*, mozilla::ipc::MessageChannel::MessageTask&) [ipc/glue/MessageChannel.cpp:1444]
[task 2024-10-22T15:06:31.087Z] 15:06:31     INFO - GECKO(8586) | #15: mozilla::ipc::MessageChannel::MessageTask::Run() [ipc/glue/MessageChannel.cpp:1553]
[task 2024-10-22T15:06:31.087Z] 15:06:31     INFO - GECKO(8586) | #16: mozilla::RunnableTask::Run() [xpcom/threads/TaskController.cpp:619]
[task 2024-10-22T15:06:31.087Z] 15:06:31     INFO - GECKO(8586) | #17: mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:945]
[task 2024-10-22T15:06:31.088Z] 15:06:31     INFO - GECKO(8586) | #18: mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) [xpcom/threads/TaskController.cpp:0]
[task 2024-10-22T15:06:31.088Z] 15:06:31     INFO - GECKO(8586) | #19: mozilla::TaskController::ProcessPendingMTTask(bool) [xpcom/threads/TaskController.cpp:554]
[task 2024-10-22T15:06:31.089Z] 15:06:31     INFO - GECKO(8586) | #20: mozilla::detail::RunnableFunction<mozilla::TaskController::TaskController()::$_0>::Run() [xpcom/threads/nsThreadUtils.h:549]
[task 2024-10-22T15:06:31.089Z] 15:06:31     INFO - GECKO(8586) | #21: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1159]
[task 2024-10-22T15:06:31.089Z] 15:06:31     INFO - GECKO(8586) | #22: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:480]
[task 2024-10-22T15:06:31.090Z] 15:06:31     INFO - GECKO(8586) | #23: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:85]
[task 2024-10-22T15:06:31.090Z] 15:06:31     INFO - GECKO(8586) | #24: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:345]
[task 2024-10-22T15:06:31.091Z] 15:06:31     INFO - GECKO(8586) | #25: nsBaseAppShell::Run() [widget/nsBaseAppShell.cpp:150]
[task 2024-10-22T15:06:31.091Z] 15:06:31     INFO - GECKO(8586) | #26: nsAppShell::Run() [widget/gtk/nsAppShell.cpp:469]
[task 2024-10-22T15:06:31.092Z] 15:06:31     INFO - GECKO(8586) | #27: nsAppStartup::Run() [toolkit/components/startup/nsAppStartup.cpp:296]
[task 2024-10-22T15:06:31.092Z] 15:06:31     INFO - GECKO(8586) | #28: XREMain::XRE_mainRun() [toolkit/xre/nsAppRunner.cpp:5798]
[task 2024-10-22T15:06:31.092Z] 15:06:31     INFO - GECKO(8586) | #29: XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:6034]
[task 2024-10-22T15:06:31.093Z] 15:06:31     INFO - GECKO(8586) | #30: XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:6106]
[task 2024-10-22T15:06:31.093Z] 15:06:31     INFO - GECKO(8586) | #31: ??? [/builds/worker/workspace/build/application/firefox/firefox + 0x3d78f]
[task 2024-10-22T15:06:31.094Z] 15:06:31     INFO - GECKO(8586) | #32: __libc_start_main [/lib/x86_64-linux-gnu/libc.so.6 + 0x21b97]
[task 2024-10-22T15:06:31.094Z] 15:06:31     INFO - GECKO(8586) | #33: ??? [/builds/worker/workspace/build/application/firefox/firefox + 0x3d259]
[task 2024-10-22T15:06:31.095Z] 15:06:31     INFO - GECKO(8586) | #34: ??? (???:???)
[task 2024-10-22T15:06:31.095Z] 15:06:31     INFO - GECKO(8586) | ExceptionHandler::GenerateDump attempting to generate:/tmp/tmpgq6xzhtz.mozrunner/minidumps/1252da87-120d-7499-b6cc-49018c582c6d.dmp
[task 2024-10-22T15:06:31.095Z] 15:06:31     INFO - GECKO(8586) | ExceptionHandler::GenerateDump cloned child 11349
[task 2024-10-22T15:06:31.096Z] 15:06:31     INFO - GECKO(8586) | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2024-10-22T15:06:31.096Z] 15:06:31     INFO - GECKO(8586) | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2024-10-22T15:06:31.096Z] 15:06:31     INFO - GECKO(8586) | ExceptionHandler::GenerateDump minidump generation succeeded
[task 2024-10-22T15:06:31.097Z] 15:06:31     INFO - GECKO(8586) | [Child 11168, IPC I/O Child] WARNING: [2A89C05D7EBCA477.A733B0152374B40A]: Dropping message '<null>'; no connection to unknown peer 1.1: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:364
[task 2024-10-22T15:06:31.097Z] 15:06:31     INFO - GECKO(8586) | [Child 8861, IPC I/O Child] WARNING: [358D0922D58EC474.6B0025E9EF36D661]: Dropping message '<null>'; no connection to unknown peer 1.1: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:364
[task 2024-10-22T15:06:31.098Z] 15:06:31     INFO - GECKO(8586) | Exiting due to channel error.
[task 2024-10-22T15:06:31.098Z] 15:06:31     INFO - GECKO(8586) | Exiting due to channel error.
[task 2024-10-22T15:06:31.098Z] 15:06:31     INFO - GECKO(8586) | [Child 11272, IPC I/O Child] WARNING: [D3A0FEF6BF9C84CF.DB5448EAEA941241]: Dropping message '<null>'; no connection to unknown peer 1.1: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:364
[task 2024-10-22T15:06:31.099Z] 15:06:31     INFO - GECKO(8586) | [Child 11300, IPC I/O Child] WARNING: [663E067CCB6E1426.38C6FBCED6A73546]: Dropping message '<null>'; no connection to unknown peer 1.1: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:364
[task 2024-10-22T15:06:31.099Z] 15:06:31     INFO - GECKO(8586) | Exiting due to channel error.
[task 2024-10-22T15:06:31.100Z] 15:06:31     INFO - GECKO(8586) | [Child 11326, IPC I/O Child] WARNING: [A4F11115C2F4F8F4.EF7D6E80CE89BA9B]: Dropping message '<null>'; no connection to unknown peer 1.1: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:364
[task 2024-10-22T15:06:31.100Z] 15:06:31     INFO - GECKO(8586) | Exiting due to channel error.
[task 2024-10-22T15:06:31.100Z] 15:06:31     INFO - GECKO(8586) | Exiting due to channel error.
[task 2024-10-22T15:06:31.101Z] 15:06:31     INFO - GECKO(8586) | [Utility 8792, IPC I/O Child] WARNING: [1B5221718637F0E2.873104C6BBDAC9F9]: Dropping message '<null>'; no connection to unknown peer 1.1: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:364
[task 2024-10-22T15:06:31.101Z] 15:06:31     INFO - GECKO(8586) | [Child 11225, IPC I/O Child] WARNING: [84C5D0BA3CFCA5F8.3535399944DFB8B5]: Dropping message '<null>'; no connection to unknown peer 1.1: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:364
[task 2024-10-22T15:06:31.102Z] 15:06:31     INFO - GECKO(8586) | [Utility 8792, Main Thread] WARNING: Shutting down Utility process early due to a crash!: file /builds/worker/checkouts/gecko/ipc/glue/UtilityProcessChild.cpp:358
[task 2024-10-22T15:06:31.102Z] 15:06:31     INFO - GECKO(8586) | Exiting due to channel error.
[task 2024-10-22T15:06:31.102Z] 15:06:31     INFO - GECKO(8586) | [Child 8739, IPC I/O Child] WARNING: [11B03BE9C2F4BEA7.BC48D5AFB11364CA]: Dropping message '<null>'; no connection to unknown peer 1.1: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:364
[task 2024-10-22T15:06:31.103Z] 15:06:31     INFO - GECKO(8586) | Exiting due to channel error.
[task 2024-10-22T15:06:31.103Z] 15:06:31     INFO - GECKO(8586) | [Child 8704, IPC I/O Child] WARNING: [349158618671D91F.3651DFA1DED9FD4D]: Dropping message '<null>'; no connection to unknown peer 1.1: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:364
[task 2024-10-22T15:06:31.104Z] 15:06:31     INFO - GECKO(8586) | Exiting due to channel error.
[task 2024-10-22T15:06:31.104Z] 15:06:31     INFO - GECKO(8586) | [Child 11219, IPC I/O Child] WARNING: [CC974FD3B430A906.F5124D4A7C130C3F]: Dropping message '<null>'; no connection to unknown peer 1.1: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:364
[task 2024-10-22T15:06:31.104Z] 15:06:31     INFO - GECKO(8586) | Exiting due to channel error.
[task 2024-10-22T15:06:31.105Z] 15:06:31     INFO - GECKO(8586) | [Socket 8668, IPC I/O Child] WARNING: [710C1886BA3D0D0B.42AB8D5F13AA8D8D]: Dropping message '<null>'; no connection to unknown peer 1.1: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:364
[task 2024-10-22T15:06:31.105Z] 15:06:31     INFO - GECKO(8586) | [GPU 8637, IPC I/O Child] WARNING: [9B5F3671F6935DD5.B36FC601D1B4ED14]: Dropping message '<null>'; no connection to unknown peer 1.1: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:364
[task 2024-10-22T15:06:31.106Z] 15:06:31     INFO - GECKO(8586) | [GPU 8637, Main Thread] WARNING: Shutting down GPU process early due to a crash!: file /builds/worker/checkouts/gecko/gfx/ipc/GPUParent.cpp:734
[task 2024-10-22T15:06:31.106Z] 15:06:31     INFO - GECKO(8586) | [Socket 8668, Main Thread] WARNING: Shutting down Socket process early due to a crash!: file /builds/worker/checkouts/gecko/netwerk/ipc/SocketProcessChild.cpp:234
[task 2024-10-22T15:06:31.107Z] 15:06:31     INFO - GECKO(8586) | [Child 8800, IPC I/O Child] WARNING: [23ACE4D0AB8A3F1B.2DDD484F2E35A616]: Dropping message '<null>'; no connection to unknown peer 1.1: file /builds/worker/checkouts/gecko/ipc/glue/NodeController.cpp:364
[task 2024-10-22T15:06:31.107Z] 15:06:31     INFO - GECKO(8586) | Exiting due to channel error.
[task 2024-10-22T15:06:31.107Z] 15:06:31     INFO - TEST-INFO | Main app process: exit 11
[task 2024-10-22T15:06:31.108Z] 15:06:31    ERROR - TEST-UNEXPECTED-FAIL | ShutdownLeaks | process() called before end of test suite
[task 2024-10-22T15:06:31.108Z] 15:06:31     INFO - TEST-INFO | Confirming we saw 132 DOCSHELL created and 116 destroyed log strings.
[task 2024-10-22T15:06:31.108Z] 15:06:31     INFO - TEST-INFO | Confirming we saw 359 DOMWINDOW created and 321 destroyed log strings.
[task 2024-10-22T15:06:31.109Z] 15:06:31     INFO - Buffered messages logged at 15:06:14
[task 2024-10-22T15:06:31.109Z] 15:06:31     INFO - Entering setup bound 
[task 2024-10-22T15:06:31.109Z] 15:06:31     INFO - Leaving setup bound 
[task 2024-10-22T15:06:31.109Z] 15:06:31     INFO - Entering test bound testCookiesWithFirstPartyServiceWorker
[task 2024-10-22T15:06:31.110Z] 15:06:31     INFO - Open a tab
[task 2024-10-22T15:06:31.110Z] 15:06:31     INFO - Writing cookies to the first-party context.
[task 2024-10-22T15:06:31.111Z] 15:06:31     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "https://example.com/browser/netwerk/cookie/test/browser/file_empty.html" line: 0}]
[task 2024-10-22T15:06:31.111Z] 15:06:31     INFO - Register a service worker and trigger a fetch request to get cookies.
[task 2024-10-22T15:06:31.111Z] 15:06:31     INFO - Buffered messages logged at 15:06:15
[task 2024-10-22T15:06:31.112Z] 15:06:31     INFO - TEST-PASS | netwerk/cookie/test/browser/browser_cookies_serviceWorker.js | The service worker controls the document successfully. - {} == true - 
<...>
[task 2024-10-22T15:06:31.145Z] 15:06:31     INFO - TEST-PASS | netwerk/cookie/test/browser/browser_cookies_serviceWorker.js | No cookie should be available in ABA context. - 
[task 2024-10-22T15:06:31.146Z] 15:06:31     INFO - Set cookies in the ABA iframe
[task 2024-10-22T15:06:31.146Z] 15:06:31     INFO - Buffered messages finished
[task 2024-10-22T15:06:31.147Z] 15:06:31     INFO - runtests.py | Application ran for: 0:01:03.832323
[task 2024-10-22T15:06:31.147Z] 15:06:31     INFO - zombiecheck | Reading PID log: /tmp/tmp9d2vwnc_pidlog
[task 2024-10-22T15:06:31.148Z] 15:06:31     INFO - ==> process 8586 launched child process 8637
[task 2024-10-22T15:06:31.148Z] 15:06:31     INFO - ==> process 8586 launched child process 8646
[task 2024-10-22T15:06:31.148Z] 15:06:31     INFO - zombiecheck | Checking for orphan process with PID: 8637
[task 2024-10-22T15:06:31.149Z] 15:06:31     INFO - zombiecheck | Checking for orphan process with PID: 8646
[task 2024-10-22T15:06:31.149Z] 15:06:31     INFO - mozcrash Copy/paste: /builds/worker/fetches/minidump-stackwalk/minidump-stackwalk --symbols-url=https://symbols.mozilla.org/ --cyborg=/tmp/tmpu5f3toaj/1252da87-120d-7499-b6cc-49018c582c6d.trace /tmp/tmpgq6xzhtz.mozrunner/minidumps/1252da87-120d-7499-b6cc-49018c582c6d.dmp /builds/worker/workspace/build/symbols
[task 2024-10-22T15:06:36.181Z] 15:06:36     INFO - mozcrash Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/1252da87-120d-7499-b6cc-49018c582c6d.dmp
[task 2024-10-22T15:06:36.182Z] 15:06:36     INFO - mozcrash Saved app info as /builds/worker/workspace/build/blobber_upload_dir/1252da87-120d-7499-b6cc-49018c582c6d.extra
[task 2024-10-22T15:06:36.318Z] 15:06:36     INFO - PROCESS-CRASH | MOZ_DIAGNOSTIC_ASSERT(false) [@ mozilla::net::CookieStorage::AddCookie] | netwerk/cookie/test/browser/browser_cookies_serviceWorker.js 
[task 2024-10-22T15:06:36.318Z] 15:06:36     INFO - Process type: main
[task 2024-10-22T15:06:36.318Z] 15:06:36     INFO - Process pid: 8586
[task 2024-10-22T15:06:36.318Z] 15:06:36     INFO - Mozilla crash reason: MOZ_DIAGNOSTIC_ASSERT(false)
[task 2024-10-22T15:06:36.318Z] 15:06:36     INFO - Crash dump filename: /tmp/tmpgq6xzhtz.mozrunner/minidumps/1252da87-120d-7499-b6cc-49018c582c6d.dmp
[task 2024-10-22T15:06:36.318Z] 15:06:36     INFO - Operating system: Linux
[task 2024-10-22T15:06:36.318Z] 15:06:36     INFO -                   4.4.0-1014-aws #14taskcluster1-Ubuntu SMP Tue Apr 3 10:27:00 UTC 2018
[task 2024-10-22T15:06:36.318Z] 15:06:36     INFO - CPU: amd64
[task 2024-10-22T15:06:36.318Z] 15:06:36     INFO -      family 6 model 85 stepping 7
[task 2024-10-22T15:06:36.318Z] 15:06:36     INFO -      4 CPUs
[task 2024-10-22T15:06:36.319Z] 15:06:36     INFO - Linux Ubuntu 18.04 - bionic (Ubuntu 18.04.6 LTS)
[task 2024-10-22T15:06:36.319Z] 15:06:36     INFO - 
[task 2024-10-22T15:06:36.319Z] 15:06:36     INFO - Crash reason:  SIGSEGV / SEGV_MAPERR
[task 2024-10-22T15:06:36.319Z] 15:06:36     INFO - Crash address: 0x0000000000000000
[task 2024-10-22T15:06:36.319Z] 15:06:36     INFO - Crashing instruction: `mov dword [0x0], 0x264`
[task 2024-10-22T15:06:36.319Z] 15:06:36     INFO - Memory accessed by instruction:
[task 2024-10-22T15:06:36.319Z] 15:06:36     INFO -   0. Address: 0x0000000000000000
[task 2024-10-22T15:06:36.319Z] 15:06:36     INFO -      Size: 4
[task 2024-10-22T15:06:36.319Z] 15:06:36     INFO - Process uptime: not available
[task 2024-10-22T15:06:36.319Z] 15:06:36     INFO - 
[task 2024-10-22T15:06:36.319Z] 15:06:36     INFO - Thread 0 firefox-bin (crashed)
[task 2024-10-22T15:06:36.319Z] 15:06:36     INFO -  0  libxul.so!mozilla::net::CookieStorage::AddCookie(mozilla::net::CookieParser*, nsTSubstring<char> const&, mozilla::OriginAttributes const&, mozilla::net::Cookie*, long, nsIURI*, nsTSubstring<char> const&, bool, bool, mozilla::dom::BrowsingContext*, nsID const*) [CookieStorage.cpp:d76bfc18f2d2d0b7495b9870b444326baf6b07c0 : 612 + 0x0]
[task 2024-10-22T15:06:36.319Z] 15:06:36     INFO -      rax = 0x00007f2d5784de01    rdx = 0x0000000000000000
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      rcx = 0x000055fc1e560a90    rbx = 0x00007f2d30fe5ae0
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      rsi = 0x00007f2d709b68b0    rdi = 0x00007f2d709b5680
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      rbp = 0x00007ffed8ff2670    rsp = 0x00007ffed8ff25a0
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -       r8 = 0x00007f2d709b68b0     r9 = 0x00007f2d7191e780
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      r10 = 0x0000000000000000    r11 = 0x0000000000000000
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      r12 = 0x000625121c8d3a69    r13 = 0x00007ffed8ff29a0
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      r14 = 0x00007ffed8ff2770    r15 = 0x00007f2d56b11da0
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      rip = 0x00007f2d5b185fda
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -     Found by: given as instruction pointer in context
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -  1  libxul.so!mozilla::net::CookieService::SetCookieStringFromHttp(nsIURI*, nsTSubstring<char> const&, nsIChannel*) [CookieService.cpp:d76bfc18f2d2d0b7495b9870b444326baf6b07c0 : 619 + 0x2a]
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      rbx = 0x00007f2d30fe5ae0    rbp = 0x00007ffed8ff2a30
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      rsp = 0x00007ffed8ff2680    r12 = 0x00007ffed8ff27d0
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      r13 = 0x00007ffed8ff2770    r14 = 0x000625121c8d3a69
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      r15 = 0x00007f2d33633200    rip = 0x00007f2d5b183ccb
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -     Found by: call frame info
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -  2  libxul.so!mozilla::net::nsHttpChannel::ContinueProcessResponse1() [nsHttpChannel.cpp:d76bfc18f2d2d0b7495b9870b444326baf6b07c0 : 2702 + 0x7]
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      rbx = 0x00007f2d30e72300    rbp = 0x00007ffed8ff2af0
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      rsp = 0x00007ffed8ff2a40    r12 = 0x00000000000000c8
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      r13 = 0xaaaaaaaaaaaaaaaa    r14 = 0x0000000000000000
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -      r15 = 0x00007ffed8ff2a50    rip = 0x00007f2d5b5ab4ea
[task 2024-10-22T15:06:36.320Z] 15:06:36     INFO -     Found by: call frame info
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -  3  libxul.so!mozilla::net::nsHttpChannel::ProcessResponse() [nsHttpChannel.cpp:d76bfc18f2d2d0b7495b9870b444326baf6b07c0 : 2659 + 0x7]
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -      rbx = 0x00007f2d4b2d0580    rbp = 0x00007ffed8ff2bc0
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -      rsp = 0x00007ffed8ff2b00    r12 = 0x00007f2d3195e2e0
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -      r13 = 0x00000000000000c8    r14 = 0x00007f2d30e72300
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -      r15 = 0x00007f2d30c04b80    rip = 0x00007f2d5b5aaf99
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -     Found by: call frame info
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -  4  libxul.so!mozilla::net::nsHttpChannel::OnStartRequest(nsIRequest*) [nsHttpChannel.cpp:d76bfc18f2d2d0b7495b9870b444326baf6b07c0 : 7908 + 0x9]
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -      rbx = 0x00007f2d30e72300    rbp = 0x00007ffed8ff2cd0
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -      rsp = 0x00007ffed8ff2bd0    r12 = 0x0000000000000002
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -      r13 = 0x00007f2d4b2d0580    r14 = 0x0000000000000000
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -      r15 = 0x00007ffed8ff2c50    rip = 0x00007f2d5b5c784a
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -     Found by: call frame info
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -  5  libxul.so!mozilla::net::HttpTransactionParent::DoOnStartRequest(nsresult const&, mozilla::Maybe<mozilla::net::nsHttpResponseHead> const&, nsITransportSecurityInfo*, bool const&, mozilla::net::TimingStructArgs const&, int const&, nsTArray<unsigned char>&&, mozilla::Maybe<nsTString<char> > const&, bool const&, bool const&, unsigned int const&, bool const&, nsIRequest::TRRMode const&, nsITRRSkipReason::value const&, unsigned int const&, mozilla::TimeStamp const&) [HttpTransactionParent.cpp:d76bfc18f2d2d0b7495b9870b444326baf6b07c0 : 504 + 0x9]
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -      rbx = 0x00007f2d2f387400    rbp = 0x00007ffed8ff2d50
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -      rsp = 0x00007ffed8ff2ce0    r12 = 0x00007f2d32650110
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -      r13 = 0x00007f2d4b2d0580    r14 = 0x00007f2d30e72a30
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -      r15 = 0x00007f2d32650259    rip = 0x00007f2d5b53756a
[task 2024-10-22T15:06:36.321Z] 15:06:36     INFO -     Found by: call frame info
<...>
[task 2024-10-22T15:08:53.294Z] 15:08:53     INFO - PERFHERDER_DATA: {"framework": {"name": "job_resource_usage"}, "suites": [{"name": "mochitest.mochitest-browser-chrome.15.overall", "extraOptions": ["e10s", "taskcluster-projects/887720501152/machineTypes/c2-standard-4"], "subtests": [{"name": "cpu_percent", "value": 53.30846087827197}, {"name": "io_write_bytes", "value": 988053504}, {"name": "io.read_bytes", "value": 0}, {"name": "io_write_time", "value": 495620}, {"name": "io_read_time", "value": 0}]}, {"name": "mochitest.mochitest-browser-chrome.15.start-pulseaudio", "subtests": [{"name": "time", "value": 0.012573572000007971}, {"name": "cpu_percent", "value": 0}]}, {"name": "mochitest.mochitest-browser-chrome.15.install", "subtests": [{"name": "time", "value": 13.750393023000015}, {"name": "cpu_percent", "value": 25.38639705882353}]}, {"name": "mochitest.mochitest-browser-chrome.15.stage-files", "subtests": [{"name": "time", "value": 0.00022445399997650384}, {"name": "cpu_percent", "value": 0}]}, {"name": "mochitest.mochitest-browser-chrome.15.run-tests", "subtests": [{"name": "time", "value": 685.2338068640001}, {"name": "cpu_percent", "value": 53.86904640303508}]}, {"name": "mochitest.mochitest-browser-chrome.15.uninstall", "subtests": [{"name": "time", "value": 0.00013943399994786887}, {"name": "cpu_percent", "value": 0}]}]}
[task 2024-10-22T15:08:53.294Z] 15:08:53     INFO - Total resource usage - Wall time: 699s; CPU: Can't collect data; Read bytes: 0; Write bytes: 988053504; Read time: 0; Write time: 495620
[task 2024-10-22T15:08:53.294Z] 15:08:53     INFO - TinderboxPrint: I/O read bytes / time<br/>0 / 0
[task 2024-10-22T15:08:53.294Z] 15:08:53     INFO - TinderboxPrint: I/O write bytes / time<br/>988,053,504 / 495,620
[task 2024-10-22T15:08:53.294Z] 15:08:53     INFO - TinderboxPrint: CPU idle<br/>1,267.9 (45.7%)
[task 2024-10-22T15:08:53.294Z] 15:08:53     INFO - TinderboxPrint: CPU iowait<br/>28.0 (1.0%)
[task 2024-10-22T15:08:53.294Z] 15:08:53     INFO - TinderboxPrint: CPU system<br/>99.4 (3.6%)
[task 2024-10-22T15:08:53.294Z] 15:08:53     INFO - TinderboxPrint: CPU user<br/>1,375.2 (49.6%)
[task 2024-10-22T15:08:53.295Z] 15:08:53     INFO - TinderboxPrint: Swap in / out<br/>0 / 0
[task 2024-10-22T15:08:53.296Z] 15:08:53     INFO - start-pulseaudio - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2024-10-22T15:08:53.297Z] 15:08:53     INFO - install - Wall time: 14s; CPU: 25%; Read bytes: 0; Write bytes: 18759680; Read time: 0; Write time: 3108
[task 2024-10-22T15:08:53.298Z] 15:08:53     INFO - stage-files - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2024-10-22T15:08:53.340Z] 15:08:53     INFO - run-tests - Wall time: 685s; CPU: 54%; Read bytes: 0; Write bytes: 969293824; Read time: 0; Write time: 492512
[task 2024-10-22T15:08:53.343Z] 15:08:53     INFO - uninstall - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2024-10-22T15:08:54.582Z] 15:08:54  WARNING - returning nonzero exit status 2
[task 2024-10-22T15:08:54.669Z] cleanup
[task 2024-10-22T15:08:54.669Z] + cleanup
[task 2024-10-22T15:08:54.669Z] + local rv=2
[task 2024-10-22T15:08:54.669Z] + [[ -s /builds/worker/.xsession-errors ]]
[task 2024-10-22T15:08:54.669Z] + cp /builds/worker/.xsession-errors /builds/worker/artifacts/public/xsession-errors.log
[task 2024-10-22T15:08:54.670Z] + '[' ']'
[task 2024-10-22T15:08:54.670Z] + true
[task 2024-10-22T15:08:54.670Z] + cleanup_xvfb
[task 2024-10-22T15:08:54.671Z] ++ pidof Xvfb
[task 2024-10-22T15:08:54.678Z] + local xvfb_pid=52
[task 2024-10-22T15:08:54.678Z] + local vnc=false
[task 2024-10-22T15:08:54.678Z] + local interactive=false
[task 2024-10-22T15:08:54.678Z] + '[' -n 52 ']'
[task 2024-10-22T15:08:54.678Z] + [[ false == false ]]
[task 2024-10-22T15:08:54.678Z] + [[ false == false ]]
[task 2024-10-22T15:08:54.678Z] + kill 52
[task 2024-10-22T15:08:54.678Z] + screen -XS xvfb quit
[task 2024-10-22T15:08:54.687Z] + exit 2
[taskcluster 2024-10-22 15:08:55.118Z] === Task Finished ===
[taskcluster 2024-10-22 15:08:57.344Z] Unsuccessful task run with exit code: 2 completed in 1050.764 seconds
Flags: needinfo?(tihuang) → needinfo?(bvandersloot)

I think it's probably safer to land this after the code freeze - and we can consider whether an uplift to beta is needed.

I agree. I am still waiting for a review on it as well.

Flags: needinfo?(bvandersloot)

Redirect a needinfo that is pending on an inactive user to the triage owner.
:valentin, since the bug has recent activity, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(corgrath) → needinfo?(valentin.gosu)
Severity: -- → S3
Flags: needinfo?(valentin.gosu)
Flags: needinfo?(lg)
Priority: -- → P2
Whiteboard: [necko-triaged]
Pushed by bvandersloot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/636bc2b1c45b Drop first-party partitioned cookies that don't have CHIPS. r=valentin,cookie-reviewers,edgul,extension-reviewers,sessionstore-reviewers,willdurand,sfoster https://hg.mozilla.org/integration/autoland/rev/eb6b645090c2 Cleanup invalid first-party partitioned cookies in the cookie DB. r=valentin,cookie-reviewers,edgul https://hg.mozilla.org/integration/autoland/rev/4d455d19f7fb Add telemetry probes for invalid first party partitioned cookies. r=valentin,cookie-reviewers,edgul

Found the crash, and a fix has been added.

Flags: needinfo?(bvandersloot)
Pushed by bvandersloot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/72c01388440a Drop first-party partitioned cookies that don't have CHIPS. r=valentin,cookie-reviewers,edgul,extension-reviewers,sessionstore-reviewers,willdurand,sfoster,webdriver-reviewers,Sasha,whimboo https://hg.mozilla.org/integration/autoland/rev/6f22034706d4 Cleanup invalid first-party partitioned cookies in the cookie DB. r=valentin,cookie-reviewers,edgul https://hg.mozilla.org/integration/autoland/rev/b160e175b74e Add telemetry probes for invalid first party partitioned cookies. r=valentin,cookie-reviewers,edgul

Backed out for causing build bustages in CookiePersistentStorage.cpp.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/netwerk/cookie/CookiePersistentStorage.cpp:221:1: error: 'virtual nsresult mozilla::net::{anonymous}::CalculatePartitionKeyFromHostSQLFunction::OnFunctionCall(mozIStorageValueArray*, nsIVariant**)' defined but not used [-Werror=unused-function]
Flags: needinfo?(tihuang)

Removing the offending function.

Flags: needinfo?(tihuang)
Pushed by bvandersloot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fb747408813c Drop first-party partitioned cookies that don't have CHIPS. r=valentin,cookie-reviewers,edgul,extension-reviewers,sessionstore-reviewers,willdurand,sfoster,webdriver-reviewers,Sasha,whimboo https://hg.mozilla.org/integration/autoland/rev/6ca20b512745 Cleanup invalid first-party partitioned cookies in the cookie DB. r=valentin,cookie-reviewers,edgul https://hg.mozilla.org/integration/autoland/rev/01c2f8a4572f Add telemetry probes for invalid first party partitioned cookies. r=valentin,cookie-reviewers,edgul
Regressions: 1929973
Status: ASSIGNED → RESOLVED
Closed: 2 years ago → 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch

Backed out 5 changesets (Bug 1923663, Bug 1922193) for causing cookie parsing crashes.

Status: RESOLVED → REOPENED
Flags: needinfo?(tihuang)
Resolution: FIXED → ---
Target Milestone: 134 Branch → ---

:nchevobbe hit the following crash with an artifact build based on mozilla-central revision 3e6134136fe66d9475fd0e42d0984bbc7cecbe2d:

Crashed Thread:        0  MainThread  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000000
Exception Codes:       0x0000000000000001, 0x0000000000000000

Termination Reason:    Namespace SIGNAL, Code 11 Segmentation fault: 11
Terminating Process:   exc handler [73652]

VM Region Info: 0 is not in any region.  Bytes before following region: 4367548416
      REGION TYPE                    START - END         [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL
      UNUSED SPACE AT START
--->  
      __TEXT                      104538000-104540000    [   32K] r-x/r-x SM=COW  /Users/USER/*/Firefox Nightly.app/Contents/MacOS/firefox

Thread 0 Crashed:: MainThread Dispatch queue: com.apple.main-thread
0   XUL                           	       0x12272ef4c mozilla::net::CookieStorage::AddCookie(mozilla::net::CookieParser*, nsTSubstring<char> const&, mozilla::OriginAttributes const&, mozilla::net::Cookie*, long long, nsIURI*, nsTSubstring<char> const&, bool, bool, mozilla::dom::BrowsingContext*, nsID const*) + 2636
1   XUL                           	       0x12272f9a0 mozilla::net::CookieService::AddNative(nsTSubstring<char> const&, nsTSubstring<char> const&, nsTSubstring<char> const&, nsTSubstring<char> const&, bool, bool, bool, long long, mozilla::OriginAttributes*, int, nsICookie::schemeType, bool, nsID const*) + 772
2   XUL                           	       0x12272f690 mozilla::net::CookieService::Add(nsTSubstring<char> const&, nsTSubstring<char> const&, nsTSubstring<char> const&, nsTSubstring<char> const&, bool, bool, bool, long long, JS::Handle<JS::Value>, int, nsICookie::schemeType, bool, JSContext*) + 320
3   XUL                           	       0x1200e0280 _NS_InvokeByIndex + 96
4   XUL                           	       0x1207de0cc XPCWrappedNative::CallMethod(XPCCallContext&, XPCWrappedNative::CallMode) + 2048
5   XUL                           	       0x1207dfba8 XPC_WN_CallMethod(JSContext*, unsigned int, JS::Value*) + 388
6   ???                           	     0x15e07a4adf4 ???
7   ???                           	     0x15e07be0920 ???
8   ???                           	     0x15e07a287bc ???
9   XUL                           	       0x121b916a8 js::jit::EnterBaselineInterpreterAtBranch(JSContext*, js::InterpreterFrame*, unsigned char*) + 424
10  XUL                           	       0x1217889fc js::Interpret(JSContext*, js::RunState&) + 1416
11  XUL                           	       0x1217814ac js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) + 3368
12  XUL                           	       0x1218a209c PromiseReactionJob(JSContext*, unsigned int, JS::Value*) + 432
13  XUL                           	       0x1217811e8 js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) + 2660
14  XUL                           	       0x121803870 JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) + 420
15  XUL                           	       0x12042cef4 mozilla::PromiseJobRunnable::Run(mozilla::AutoSlowOperation&) + 336
16  XUL                           	       0x12041b0b8 mozilla::CycleCollectedJSContext::PerformMicroTaskCheckPoint(bool) + 1464
17  XUL                           	       0x120f7a4c0 mozilla::EventTargetChainItem::HandleEvent(mozilla::EventChainPostVisitor&, mozilla::ELMCreationDetector&) + 3756
18  XUL                           	       0x120f70f70 mozilla::EventTargetChainItem::HandleEventTargetChain(nsTArray<mozilla::EventTargetChainItem>&, mozilla::EventChainPostVisitor&, mozilla::EventDispatchingCallback*, mozilla::ELMCreationDetector&) + 3052
19  XUL                           	       0x120f7ddd0 mozilla::EventDispatcher::Dispatch(mozilla::dom::EventTarget*, nsPresContext*, mozilla::WidgetEvent*, mozilla::dom::Event*, nsEventStatus*, mozilla::EventDispatchingCallback*, nsTArray<mozilla::dom::EventTarget*>*) + 8260
20  XUL                           	       0x121443c78 DelayedFireDOMPaintEvent::Run() + 392
21  XUL                           	       0x12049f1ec mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) + 3544
22  XUL                           	       0x1204a75d8 mozilla::detail::RunnableFunction<mozilla::TaskController::TaskController()::$_0>::Run() + 72
23  XUL                           	       0x1204b0554 nsThread::ProcessNextEvent(bool, bool*) + 968
24  XUL                           	       0x1204addec NS_ProcessPendingEvents(nsIThread*, unsigned int) + 136
25  XUL                           	       0x1212fe74c nsAppShell::ProcessGeckoEvents(void*) + 272
26  CoreFoundation                	       0x187ba14d8 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 28
27  CoreFoundation                	       0x187ba146c __CFRunLoopDoSource0 + 176
28  CoreFoundation                	       0x187ba123c __CFRunLoopDoSources0 + 340
29  CoreFoundation                	       0x187b9fdc8 __CFRunLoopRun + 828
30  CoreFoundation                	       0x187b9f434 CFRunLoopRunSpecific + 608
31  HIToolbox                     	       0x19234919c RunCurrentEventLoopInMode + 292
32  HIToolbox                     	       0x192348fd8 ReceiveNextEventCommon + 648
33  HIToolbox                     	       0x192348d30 _BlockUntilNextEventMatchingListInModeWithFilter + 76
34  AppKit                        	       0x18b3fecc8 _DPSNextEvent + 660
35  AppKit                        	       0x18bbf54d0 -[NSApplication(NSEventRouting) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 700
36  XUL                           	       0x1212fdf44 -[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 132
37  AppKit                        	       0x18b3f1ffc -[NSApplication run] + 476
38  XUL                           	       0x124b09854 -[GeckoNSApplication run] + 72
39  XUL                           	       0x1212ff11c nsAppShell::Run() + 468
40  XUL                           	       0x12501511c nsAppStartup::Run() + 88
41  XUL                           	       0x12175c050 XREMain::XRE_mainRun() + 1692
42  XUL                           	       0x1250ae838 XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) + 800
43  XUL                           	       0x1250aed8c XRE_main(int, char**, mozilla::BootstrapConfig const&) + 144
44  firefox                       	       0x10453e2fc main + 492
45  dyld                          	       0x187737154 start + 2476

Hello nchevobbe,

Could you provide the steps to reproduce the crash? Did it happen on a fresh profile? If not, did you install any extensions on the profile? Thanks.

Flags: needinfo?(tihuang) → needinfo?(nchevobbe)

(In reply to Tim Huang[:timhuang] from comment #43)

Hello nchevobbe,

Could you provide the steps to reproduce the crash?

I was seeing that this morning just running ./mach run -P dev, I wouldn't even have the time to see the Firefox window, it would crash straight away.

Did it happen on a fresh profile?

It wasn't happening on a fresh profile

If not, did you install any extensions on the profile? Thanks.

Yeah a few:

Add-ons
-------

Name: Add-ons Search Detection
Type: extension
Version: 2.0.0
Enabled: true
ID: addons-search-detection@mozilla.com

Name: Firefox Alpenglow
Type: theme
Version: 1.4
Enabled: true
ID: firefox-alpenglow@mozilla.org

Name: devtools-inspector-sidebar
Type: extension
Version: 1.0
Enabled: false
ID: {50b26d0f-7926-482d-8ef8-cc760ea4d4f0}

Name: Firefox DevTools ADB Extension
Type: extension
Version: 0.0.8.2
Enabled: false
ID: adb@mozilla.org

Name: Firefox Multi-Account Containers
Type: extension
Version: 8.2.0
Enabled: false
ID: @testpilot-containers

Name: Minimal Theme for Twitter / X
Type: extension
Version: 6.1.1
Enabled: false
ID: {e7476172-097c-4b77-b56e-f56a894adca9}

Name: MyQOnly
Type: extension
Version: 0.10.0
Enabled: false
ID: myqonly@mikeconley.ca

Name: Open Tabs Next to Current
Type: extension
Version: 2.0.14
Enabled: false
ID: opentabsnexttocurrent@sblask

Name: phab-conventional-comments
Type: extension
Version: 0.4
Enabled: false
ID: {3e0e2f7e-1dde-4fee-ab96-031faa42ec52}

Name: phab-test-policy
Type: extension
Version: 1.6
Enabled: false
ID: {33d43318-bde8-4b88-9658-4b89629dbc4e}

Name: React Developer Tools
Type: extension
Version: 5.3.1
Enabled: false
ID: @react-devtools

Name: remote-settings-devtools
Type: extension
Version: 1.10.0buildid20240610.091201
Enabled: false
ID: remote-settings-devtools@mozilla.com

Name: Searchfox Search Engine
Type: extension
Version: 1.0
Enabled: false
ID: searchfox-search-engine@harrytwyford.com

Name: uBlock Origin
Type: extension
Version: 1.60.0
Enabled: false
ID: uBlock0@raymondhill.net

Name: Vue.js devtools
Type: extension
Version: 6.6.3
Enabled: false
ID: {5caff8cc-3d2e-4110-a88a-003cc85b3858}

Name: webhint
Type: extension
Version: 2.4.17
Enabled: false
ID: {e748cb59-4901-4bea-b74a-1d8dab98e3c7}

Name: Dark
Type: theme
Version: 1.3.2
Enabled: false
ID: firefox-compact-dark@mozilla.org

Name: Light
Type: theme
Version: 1.3
Enabled: false
ID: firefox-compact-light@mozilla.org

Name: Save the Bees Plz
Type: theme
Version: 2.0
Enabled: false
ID: {c905452b-5278-4ff5-8eef-542b9c009b9e}

Name: System theme — auto
Type: theme
Version: 1.4.1
Enabled: false
ID: default-theme@mozilla.org

Name: wp8153887-green-plants-wallpapers
Type: theme
Version: 1.0
Enabled: false
ID: {5b9a318f-5781-49fa-84c9-6a616ae953ff}
Flags: needinfo?(nchevobbe)
Status: REOPENED → ASSIGNED

The session cookies in the session store file didn't have the
isPartitioned flag. The patch enforces the isPartitioned flag for the
partitioned session cookies in order to properly set the flag when
restoring.

Pushed by tihuang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/abfae75af05f Drop first-party partitioned cookies that don't have CHIPS. r=valentin,cookie-reviewers,edgul,extension-reviewers,sessionstore-reviewers,willdurand,sfoster,webdriver-reviewers,Sasha,whimboo https://hg.mozilla.org/integration/autoland/rev/7a03590458f2 Cleanup invalid first-party partitioned cookies in the cookie DB. r=valentin,cookie-reviewers,edgul https://hg.mozilla.org/integration/autoland/rev/817a9db0594b Add telemetry probes for invalid first party partitioned cookies. r=valentin,cookie-reviewers,edgul https://hg.mozilla.org/integration/autoland/rev/e2c5151ea497 Enforce isPartitioned flag for partitioned session cookie when restoring session cookies. r=sfoster,sessionstore-reviewers

Backed out alongside Bug 1923663 for causing bc failures on browser_cookies_legacy.js

Backout link

Push with failures

Failure log

Flags: needinfo?(tihuang)
Pushed by tihuang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/313c49d4aab3 Drop first-party partitioned cookies that don't have CHIPS. r=valentin,cookie-reviewers,edgul,extension-reviewers,sessionstore-reviewers,willdurand,sfoster,webdriver-reviewers,Sasha,whimboo https://hg.mozilla.org/integration/autoland/rev/18fea91fe475 Cleanup invalid first-party partitioned cookies in the cookie DB. r=valentin,cookie-reviewers,edgul https://hg.mozilla.org/integration/autoland/rev/f3c6037bcaa9 Add telemetry probes for invalid first party partitioned cookies. r=valentin,cookie-reviewers,edgul https://hg.mozilla.org/integration/autoland/rev/3347ee1d52dd Enforce isPartitioned flag for partitioned session cookie when restoring session cookies. r=sfoster,sessionstore-reviewers
Flags: needinfo?(tihuang)
Flags: qe-verify+

Christoffer, can you please confirm issue is fixed on latest Firefox build (https://archive.mozilla.org/pub/firefox/candidates/) ? Thank you.

Flags: needinfo?(corgrath)
See Also: → 1989181
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: