192255 - user accessible pref for image resizing/scaling

Status: VERIFIED FIXED

(Firefox :: Settings UI, enhancement)

Description

[Tomasz Torcz]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030206 Phoenix/0.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030206 Phoenix/0.5

Summary is descriptive enough. Pictures are unreadable, because they are scaled.
CPU cycles are wasted for scaling.

Reproducible: Always

Steps to Reproduce:
1. Open some picture from web bigger than browser window.
2. Got blind trying to figure what is on picture.
3. Profit? (:-))

Actual Results:  
Unreadable image.

Expected Results:  
Show picture as usual, unscaled, with scrollbars.

Comment 1

[David P James]

There is something very wrong with that image. I downloaded it and kview won't
even display it whilst GIMP will but not particularly well either. In fact, GIMP
thinks that it is a corrupted image.

Sorry, this bug is invalid (not a bug - not with Phoenix anyway).

Comment 2

[Tomasz Torcz]

That's only a example - a big image. Just go and find any big file on net - it
will be scaled down.
I've found that single-clicking on image will bring it to normal size. 
Thus, fixing that bug can be done by changing default behaviour from
scale-to-fit to scale-after-clicked.

Comment 3

[Gilles Durys]

If you don't want the rescale effect, just add the following line to your prefs.js

user_pref("browser.enable_automatic_image_resizing", false);

Comment 4

[Sébastien Delahaye]

v.

Comment 5

[David P James]

I only invalidated this bug on the basis that the image was a bad one as the
"scaled down" effect was indistinguishable from the badness of the image itself.
However, I've now seen this with a good image, and I think what we need is a
pref in Options to deal with this.

Reopening

Comment 6

[David P James]

OS --> All
Severity --> Enhancement
Status --> New
Component --> Preferences
Changing summary

Removing bad image URL

Comment 7

[David P James]

Attachment: 1024 pixel-wide screenshot

By default, this image will be displayed scaled down. There ought to be a pref
in Tools | Options... | Web Features to set/unset this.

Comment 8

[Jesse Ruderman]

I agree that this is a problem, and I'm about to switch to an earlier nightly
for my porn surfing.  But I think the problem can be fixed without adding a pref.

1) The default should be to not scale the image.  Prefer scrolling over subtle
dataloss (making the image ugly without making it unrecognizable) for users who
don't know about the image-scaling feature.

2) Remember the state of the last image the user scaled.  For example, if I
unscaled the last image I viewed, new images should appear unscaled.

Comment 9

[Jesse Ruderman]

Fixing this bug the way I suggested in comment 8 requires fixing bug 197263,
"Unchecking 'enable automatic image resizing' also disables click-to-resize".

A nice thing about not having a pref is that then users won't wonder why large
images in web pages don't get scaled down.  (It's usually bad when changing a
pref doesn't seem to have any effect.)

If Phoenix does end up having a pref, see bug 197274 for suggestions about wording.

Comment 10

[noririty]

*** Bug 204926 has been marked as a duplicate of this bug. ***

Comment 11

[Bill Mason]

*** Bug 206629 has been marked as a duplicate of this bug. ***

Comment 12

[Mike Connor [:mconnor]]

taking QA contact, sorry about the bugspam

Comment 13

[Pham]

/

Comment 14

[Kevin Ar18]

I'm still seeing this issue on the latest nightly build ( 10-Aug-2003 12:31 ).

Comment 15

[David P James]

The pref is set in the Advanced Pane under Multimedia in the Options dialog. You
do have to reload an image to see the pref take effect.

Comment 16

[Kevin Ar18]

I thought we were gonna have this feature default to off?

Comment 17

[Mike Connor [:mconnor]]

Verified.  

Kevin, no, we're not going to default it off, and nothing in this bug indicates
this anywhere.  This bug was just to make the pref accessible in the UI, which
it is.

Comment 18

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change