1922563 - Investigate relevancy of optimizing storage for mozilla::dom::MathMLElement::MapGlobalMathMLAttributesInto()::values

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[[:sergesanspaille]]

It shows up in the profile from https://bugzilla.mozilla.org/show_bug.cgi?id=1922272#c1

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1922563 - Reduce memory foot print of mozilla::dom::MathMLElement::MapGlobalMathMLAttributesInto()::values

Use some kind of prefix table to avoid storing redundant string. Also
Avoid storing an array of enum when tehre's a direct mapping between
enum values and loop index.

This result in a reduction of 352 byte in the resulting binary, so this
may not be worth the effort, but it was great fun to write that patch.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/875fb891b6a9
Reduce memory foot print of mozilla::dom::MathMLElement::MapGlobalMathMLAttributesInto()::values r=emilio

Comment 3

[pstanciu]

Backed out for causing (part of commit message) build bustages on MathMLElement.cpp

• Backout link
• Push with failures
• Failure Log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c518c29f1c31
Reduce memory foot print of mozilla::dom::MathMLElement::MapGlobalMathMLAttributesInto()::values r=emilio

Comment 5

[Atila Butkovits]

Backed out for causing bustages at MathMLElement.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/203efe29ccd568d8f65727acd7177cc1629de76d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c518c29f1c31d401758b4efad7fd6a5ae82dcddd&selectedTaskRun=ZvFtg4HVSDWnk6usyUJ5sQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=478206433&repo=autoland&lineNumber=22146

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f6ddacd157f
Reduce memory foot print of mozilla::dom::MathMLElement::MapGlobalMathMLAttributesInto()::values r=emilio

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5f6ddacd157f