1922568 - [wpt-sync] Sync PR 48448 - Fix bugs: closedPath doesn't work for open circle

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48448 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48448
Details from upstream follow.

Yi Xu <[e-mail]> wrote:

Fix bugs: closedPath doesn't work for open circle

We're currently drawing a full-sweep open arc (sweep angle = 360 or
-360) and full-sweep closed arc with the same function
SkCanvas::drawArc(), which only draws open arcs. So it incorrectly
draws open arc for closed path.

This cl fixes the issue by converting the full sweep open arc to skpath.

Bug: 370690269

Change-Id: I7aee5f953d7d04b1ea73730a41c64cd86911746e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5889468
Reviewed-by: Florin Malita \<[e-mail]>
Commit-Queue: Yi Xu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1363662}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=67b9287d9ed583fb7f676dc223c4eebd8edd4c02

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 6 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests and 1 subtests

Status Summary

Firefox

OK : 6
PASS: 5[Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub] 6[Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt]
FAIL: 1

Chrome

OK : 6
PASS: 6

Safari

OK : 6
PASS: 3
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/element/path-objects/2d.path.open.arc.html [wpt.fyi]
  • line caps should be drawn on open arcs: FAIL [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub], PASS [Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89e523657386
[wpt PR 48448] - Fix bugs: closedPath doesn't work for open circle, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b7696bd8d150
[wpt PR 48448] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/89e523657386
https://hg.mozilla.org/mozilla-central/rev/b7696bd8d150