1922701 - Going through the add folder from select folder from edit bookmark flow is broken

Status: VERIFIED FIXED

(Firefox for Android :: Bookmarks, defect)

Description

[Matt Tighe [:matt-tighe]]

Attachment: hmm.mp4

Comment 1

[Matt Tighe [:matt-tighe]]

Attachment: Bug 1922701 - Fix issues with nested bookmark add and select folder screens

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/130d2b29f398
Fix issues with nested bookmark add and select folder screens r=android-reviewers,boek

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out 4 changesets (Bug 1922134, Bug 1922140, Bug 1922137, Bug 1922701) for causing fenix failures on BookmarksReducerTest.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=130d2b29f39832023526989eaeae0ed7e12200a1&selectedTaskRun=FLIZj0LLRUmDqlz7Sp1r0g.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=477458132&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/e2a5988f2ba0cb142052882d153f55559d32d436

Comment 4

[Matt Tighe [:matt-tighe]]

Attachment: Bug 1922701 - Fix issues with nested bookmark add and select folder screens

Original Revision: https://phabricator.services.mozilla.com/D224566

Comment 5

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Bookmarks MVP + 1 is blocked from 132
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: None
• Explanation of risk level: Feature is behind a nimbus flag and can be rolled back if bugs found
• String changes made/needed: None
• Is Android affected?: yes

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e65cba9c02c1
Fix issues with nested bookmark add and select folder screens r=android-reviewers,boek

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e65cba9c02c1

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f040b6d5d1d8

Comment 9

[Mira Lobontiu (Android QA)]

Attachment: bug1922701.mp4

This is not fixed entirely yet.

I was able to reproduce the broken flow while trying to:

• move a subfolder - please see the attached short video (trying to move the "shoppingareala" folder from the "PDF links" folder to "Bookmarks" folder - and it is not working no matter how many times I tried);
• move a folder in a folder (did not attached any videos).

Tested on Fenix Nightly 133.0a1 from 10/13, with Realme GT Master Edition (Android 10), and Samsung Galaxy Tab S9 Ultra (Android 14).

Comment 10

[Matt Tighe [:matt-tighe]]

Reopening to address the issue discovered by QA. Please NI me as well on any bookmarks bugs that you discover! Thanks

Comment 11

[Matt Tighe [:matt-tighe]]

Attachment: Bug 1922701 - Don't allow adding a folder while editing a different folder

Comment 12

[Matt Tighe [:matt-tighe]]

Attachment: Bug 1922701 - Don't allow adding a folder while editing a different folder

Original Revision: https://phabricator.services.mozilla.com/D225886

Comment 13

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Bugs prevent new bookmarks from being enabled
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: None
• Explanation of risk level: Code is all behind a Nimbus flag
• String changes made/needed: None
• Is Android affected?: yes

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8cbb4e557921
Don't allow adding a folder while editing a different folder r=android-reviewers,boek

Comment 15

[amarc]

https://hg.mozilla.org/mozilla-central/rev/8cbb4e557921

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/4dd1d4f122dd

Comment 17

[Mira Lobontiu (Android QA)]

Verified as fixed on the Fenix Beta 132.0b9, and on Nightly 133.0a1 from 10/21, with Google Pixel 6 (Android 15), and Oppo Find X3 Lite (Android 11).
Verified that:

• the user can move a subfolder to a different folder or subfolder;
• the user can move a folder in a folder;
• the user can move multiple bookmarks to a folder.