192272 - Mozilla crashed on Quit after attempting access to SSL IMAP account during DNS hang [@ nsInputStreamPump::EnsureWaiting]

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect, P1)

Description

[Greg K.]

When Mozilla is trying to resolve a cranky DNS (bug 192271), if connection is
attempted to another site in another tab or in MailNews that connection will
pause until the recalcitrant DNS query completes. Sometimes, Mozilla will crash
if Quit in this state.

Steps to reproduce:
1. Attempt to access <http://www.imagemagick.org/> using the DNS <206.13.28.12>
2. Attempt to access <> in another tab
3. Observe that access attempt "pause" while the first access hangs
4. Attempt to access an SSL IMAP account
5. Quit Mozilla.

Expected results:
Mozilla should abort all the connection attempts and quit successfully.

Actual results:
Mozilla crashes sometimes.

Reproducibility:
Tried, could not reproduce.

Comment 1

[Greg K.]

Attachment: Crash report generated by FizzillaMach/2003020603 showing crash at nsInputStreamPump::EnsureWaiting

Comment 2

[grylchan]

i belive this should be a dupe of 192271.

I did query on talkback and there are multiple crash reports.
I'll attach an attachment.

I searched through bugzilla and did not see any other bugs
with the same stacktrace.

Comment 3

[grylchan]

Attachment: climate query with same strack trace

Comment 4

[David :Bienvenu]

-> Darin

Comment 5

[Greg K.]

Please note that attachment 113813 [details] contains e-mail addresses, and should be deleted.

Comment 6

[Darin Fisher]

right, i've seen this crash recently.  my patch for bug 190106 actually includes
the fix, but i'll attach just the part needed to fix this crash here.

Comment 7

[Darin Fisher]

Attachment: v1 patch

the problem is that nsInputStreamPump is not threadsafe.  IMAP should not try
to talk to it from both the UI thread as well as the background IMAP thread. 
i'm fixing this problem by calling the transport's close method instead to
bring down the necko connection.

Comment 8

[David :Bienvenu]

Comment on attachment 113817 [details] [diff] [review]
v1 patch

sr=bienvenu

Comment 9

[(not reading, please use [e-mail] instead)]

Comment on attachment 113817 [details] [diff] [review]
v1 patch

r=sspitzer

Comment 10

[Darin Fisher]

Comment on attachment 113817 [details] [diff] [review]
v1 patch

seeking drivers approval for 1.3 beta...

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 113817 [details] [diff] [review]
v1 patch

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 12

[Darin Fisher]

fixed-on-trunk

Comment 13

[Greg K.]

Are you sure? It hasn't shown up on Bonsai yet.

Comment 14

[Greg K.]

Whoops, never mind; there it is.

Comment 15

[Jay Patel [:jay]]

Adding topcrash+, testcase keywords for future reference.  Also updating
Hardware and OS to All...there were crashes on Windows and Linux as well as MacOS. 

Looking at the latest Talkback data, this crash is gone...no crashes since 2/6
MozillaTrunk builds.  Marking verified.