192291 - [FIXr]Not reflowing when inside position:fixed element

Status: VERIFIED FIXED

(Core :: Layout: Positioned, defect, P1)

Description

[James Ross]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3b) Gecko/20030202 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3b) Gecko/20030202 Phoenix/0.5

Changing style.display for an element within a postion:fixed doesn't seem to
work initially.

Reproducible: Always

Steps to Reproduce:
1. Go to http://www.warwickcompsoc.co.uk/?usetheme=v2-compact
2. Hover mouse over left edge (to see menu).
3. Click an expandable menu item (e.g. 'About').

Actual Results:  
Nothing happens.

Expected Results:  
The menu should expand to show what's under that area of the site.

This *does* work in Mozilla build 20030114, but not in build 20030122.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This works in Linux build 2003-01-19-22 and is broken in 2003-01-20-21

Chances are, this is fallout from bug 179683.

A minimal testcase would sure be nice here... :(

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: testcase

The key is the div around the thing whose display we change.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: This hack didn't get fully removed

This looks like a carryover from when the "we only do dirty frames" assert and
such were still there....

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 113876 [details] [diff] [review]
This hack didn't get fully removed

dbaron, would you review?

Comment 5

[Boris Zbarsky [:bzbarsky]]

to me

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 113876 [details] [diff] [review]
This hack didn't get fully removed

Makes sense to me, although I don't see the line in the old code where this
came from.

Comment 7

[Boris Zbarsky [:bzbarsky]]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/html/base/src/nsViewportFrame.cpp&rev=1.59&mark=468#459

is where it came from... 

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 113876 [details] [diff] [review]
This hack didn't get fully removed

Could this be approved for 1.3?  We're just changing the reflow reason for no
good reason here, and it breaks things...

Comment 9

[Asa Dotzler [:asa]]

Comment on attachment 113876 [details] [diff] [review]
This hack didn't get fully removed

a=asa (on behalf of drivers) for checkin to 1.3 final.

Comment 10

[Boris Zbarsky [:bzbarsky]]

fixed for 1.3final

Comment 11

[Boris Zbarsky [:bzbarsky]]

*** Bug 193135 has been marked as a duplicate of this bug. ***

Comment 12

[Madhur Bhatia]

verifying