1922910 - Crash in [@ stackoverflow | style::custom_properties::parse_declaration_value::closure$0] when loading https://sophielcottrell.github.io/CSS-Chess/

Status: REOPENED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

Crash report: https://crash-stats.mozilla.org/report/index/c3b211d9-6398-4b89-9fc3-47ea10241005

Reason:

EXCEPTION_STACK_OVERFLOW

Top 10 frames:

0  xul.dll  style::custom_properties::parse_declaration_value::closure$0(style::custom_pr...  servo/components/style/custom_properties.rs:683
0  xul.dll  cssparser::parser::Parser::parse_entirely(style::custom_properties::parse_dec...  third_party/rust/cssparser/src/parser.rs:695
0  xul.dll  cssparser::parser::parse_until_before(cssparser::parser::Parser*, cssparser::...  third_party/rust/cssparser/src/parser.rs:1065
0  xul.dll  cssparser::parser::Parser::parse_until_before(cssparser::parser::Delimiters, ...  third_party/rust/cssparser/src/parser.rs:803
0  xul.dll  style::custom_properties::parse_declaration_value(cssparser::parser::Parser*,...  servo/components/style/custom_properties.rs:682
1  xul.dll  style::custom_properties::parse_declaration_value_block::closure$0(style::cus...  servo/components/style/custom_properties.rs:813
1  xul.dll  cssparser::parser::Parser::parse_entirely(style::custom_properties::parse_dec...  third_party/rust/cssparser/src/parser.rs:695
1  xul.dll  cssparser::parser::parse_nested_block(cssparser::parser::Parser*, style::cust...  third_party/rust/cssparser/src/parser.rs:1145
1  xul.dll  cssparser::parser::Parser::parse_nested_block(style::custom_properties::parse...  third_party/rust/cssparser/src/parser.rs:783
1  xul.dll  style::custom_properties::parse_declaration_value_block(cssparser::parser::Pa...  servo/components/style/custom_properties.rs:769

Comment 1

[Emilio Cobos Álvarez [:emilio]]

We're crashing while parsing a ridiculously nested var(...) substitution. If I inline the CSS then it works because we parse on the main thread which has a larger stack...

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.

Comment 3

[Tyson Smith [:tsmith]]

site-scout is still reporting this issue as of m-c 20250302-543c21c8e352.