1922915 - Update irregexp to new version 4464871fc2e0472861e04fd8c383452d7260dbab from 2024-10-12 00:00:00

Status: RESOLVED DUPLICATE of bug 1924344

(Core :: JavaScript Engine, enhancement)

Description

[Update Bot]

This update covers 718 commits, including 107 new upstream commits I've never filed a bug on before. (They're the top 107.). Here are the overall diff statistics.

---

js/src/irregexp/imported/regexp-bytecode-generator.cc | 24 +-
js/src/irregexp/imported/regexp-bytecode-generator.h | 4 +
js/src/irregexp/imported/regexp-compiler-tonode.cc | 33 +-
js/src/irregexp/imported/regexp-compiler.cc | 273 +++++++++----
js/src/irregexp/imported/regexp-compiler.h | 6 +-
js/src/irregexp/imported/regexp-dotprinter.cc | 1 +
js/src/irregexp/imported/regexp-interpreter.cc | 2 +-
js/src/irregexp/imported/regexp-macro-assembler-tracer.cc | 33 +
js/src/irregexp/imported/regexp-macro-assembler-tracer.h | 3 +
js/src/irregexp/imported/regexp-macro-assembler.h | 5 +
js/src/irregexp/imported/regexp-nodes.h | 57 ++-
js/src/irregexp/imported/regexp-parser.cc | 13 +-
js/src/irregexp/imported/regexp.h | 37 +
js/src/irregexp/moz.yaml | 4 +-
14 files changed, 359 insertions(+), 136 deletions(-)

Comment 2

[Update Bot]

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=f2135ea8f16e6cec1056cc72cc1cb5889e8ec1a5

Comment 3

[Update Bot]

Attachment: Bug 1922915 - Update irregexp to 4464871fc2e0472861e04fd8c383452d7260dbab

Comment 4

[Update Bot]

The try push is done, we found jobs with unclassified failures.

Needs Close Investigation:

• spidermonkey-sm-plain-linux64/opt - 4 of 4 failed on the same (retriggered) task (failed: BhK4E_xxReivNWpoVbq5vQ, ChCtJ6IKQn-_bjHCqKIm-w, RQux9hdPSqGoGrMyaCTwew, Y_BywlEoQ560VJeAsNg_Fg)
• spidermonkey-sm-package-linux64/opt - 4 of 4 failed on the same (retriggered) task (failed: bHmrx9gaRmCWIf5SEQ9vmQ, Bw6y-eDcTkCDyISmFG_T4w, O47zixj3SnaAIDA07SMVxQ, U_NuAg9uSJmDoQEgYO_Okg)
• spidermonkey-sm-wasm-no-experimental-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: c3Ir1JxhQuO7cF_D0EJNkA, bXdsNSaoR4mU8v8wpjm9Sw, eQKkgBqAR_yP8mqlKNwOig, UvfQVjhZQUmJhZIUYnEljA)
• spidermonkey-sm-arm-sim-linux32/debug - 4 of 4 failed on the same (retriggered) task (failed: cazC8epFSUSiQrEif1iepQ, BrtW9tRRTg2zs8-TILvSAw, HPSolpcZSbOSsILHfQN-sA, N6p1oFqYR4eAyH6Nfro4kw)
• spidermonkey-sm-pbl-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: d9UgTtaZT1yKjyLAJiLuiw, cKv4-LJ-QQy72L-OHHf5mA, S82WyuLcTNGK9oKNOyf-Bg, SPmQ1Y5fSWC5rhIu7KS43A)
• spidermonkey-sm-linux64-wasi-pbl/opt - 4 of 4 failed on the same (retriggered) task (failed: CqH0ZWpvQwi2pJSmwaR00w, LteN-bvPSHuIAGm6ASqTYA, OyUEvFBCT8KwkQ7m5T_HYQ, X1D_eJW4R5i9daUZyE9A6Q)
• spidermonkey-sm-nojit-linux64/opt - 4 of 4 failed on the same (retriggered) task (failed: eGC6wdQZS9CsMJRV4fDZcA, GDQM0eaRS3WFjpxittw8vg, KoPISDbSSjKCESp8VCJrDw, WT3ezmqsSfmMQXn7NDf-XQ)
• spidermonkey-sm-fuzzilli-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: dYD-TBGHQsiDLLW5y1Esow, dqTHtaU5Rz6W8uXLsRE3gQ, XSgiZis5TJCKC20i_b3GNg, YA1seoS7TnGyKznLuCkvdA)
• spidermonkey-sm-pbl-linux64/opt - 4 of 4 failed on the same (retriggered) task (failed: EqU2JSqFT7aOfyV_6tNfYw, aXaG-W5aT2KSqwduZAX9PA, dAer49hxSpaCJovPsU7k2g, Q1es6LrmSmmmx05Ttk6rRQ)
• spidermonkey-sm-linux64-wasi-intl/opt - 4 of 4 failed on the same (retriggered) task (failed: ERcORCVWQn2HedjWjEoNwQ, GNjKg7M3QMWxbhtbNlfJIQ, IHT4rLvHQKeuEXVPo97HuA, TUWYNEyDSROUJ1cnXbhPbQ)
• spidermonkey-sm-plain-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: FuB10JSmRF-3vir29yu8lA, ID1QPp9GRlamevRL1drQZg, W2m-5dROT2ie3GMUI99h5Q, Wdm5rm8MTgit55DJmTjLMg)
• spidermonkey-sm-gdb-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: GmdDzR-jShG0VPQeDvJcpw, LUCX4ZvAQ1OjAaMcOjUVVQ, R_nX_nXaRkea9EO5plKHGg, XEdxD0QjSQik_duX7K7Nig)
• spidermonkey-sm-fuzzing-linux64/opt - 4 of 4 failed on the same (retriggered) task (failed: dWA4-JraT_2s6Is7Iy5xMw, Pz7XUrh6TICbbKQXdokN3A, VIuVstLpRkm2diFzRd3AQQ, WNXxhZLvSB-jdanL9stgCQ)
• hazard-linux64-shell-haz/debug - 4 of 4 failed on the same (retriggered) task (failed: H2_7pIE7SweNBDy44lSthw, daskFoJXTd2vMNVnKxkwiQ, ERMpq0_9Ri6lEfdOKCzpsw, JqBUeHy6QHKrzpYOFg4kFA)
• spidermonkey-sm-arm64-sim-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: Kl05iFgpRM6drqz6Ptp8dQ, bOaJwQJ7SNqa6gxsaKM8ew, Sow69zTCTMGTIhL0oSxFEA, TuzTdAqfQEOuMMvswB978g)
• spidermonkey-sm-nonunified-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: NYnukcIMRQGsaH4uxudvqA, e7EHv5E1T_OSHsHn6r4t8Q, PaJA0JqWQLix8miKSVtWTA, QZowGLv7Tj2wOi5TU8o8FQ)
• spidermonkey-sm-linux64-wasi/opt - 4 of 4 failed on the same (retriggered) task (failed: O9O5GS5OT7yy_t_VJzN_uQ, Fj0ZoKgiRUeAwdnqulGaqA, FVbuVaIKSMCWhg6bLcDM5A, JXJm0_buSs2USvAnuqa62g)
• spidermonkey-sm-plain-linux32/debug - 4 of 4 failed on the same (retriggered) task (failed: OY4a8LYUSwmwigEx30Gzhg, d9k7T4r8R26OeyFmclPO0g, Gy5rNiU9Q9aVsJog-FOxyw, YdCBFDZOSFGT57LsGL2Rww)
• spidermonkey-sm-rootanalysis-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: P3-CqRg6R0-C7EteU8RqJA, EbAnwAB5SF2flqTkB0SnbQ, Pp0EzA-_QnulsDOwuM8c_Q, U9vK_PXgQd6SQ3wcaYJcQA)
• spidermonkey-sm-asan-linux64/opt - 4 of 4 failed on the same (retriggered) task (failed: Q6YtJJqtROGgAtn66YThJA, exJ_mahOQx6q56yilJ2pHQ, TK-zwMk5Sb-fs2jvdecPqA, VVjazELxT_CkmUuTY6eVcA)
• spidermonkey-sm-temporal-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: RODphgJBTIGpYGFJPkKXVQ, C2rJZqAhS_uTV17zzQE_Rw, GR5A6GDZTuS379-ahTD-2Q, I5jxXcrlQt2tUbDmwA9vWw)
• spidermonkey-sm-rt-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: X7oCf7meS7W9ZjEaUB6Z1Q, DngCgo5zTFWH5CjsW-VqJA, QJOc0FpTQl2S9jMrZzRKuA, UtMPGKCNSEyaDBvAvsMAvA)
• spidermonkey-sm-tsan-linux64/opt - 4 of 4 failed on the same (retriggered) task (failed: ZYrO_xKQRhyPT1bcYmfrRA, cBX2dwPJRxSz0cYpOcwlQw, Lle_O989SqCbqS9RgFX61g, P1UxzxyQQWygUrCwgijpjg)
• spidermonkey-sm-compacting-linux64/debug - 4 of 4 failed on the same (retriggered) task (failed: GMt7iJuyQpqPRPemVICKrA, CyZjIV82QlW2PHTlaIxdpw, N-iivHZqQJ-gINxLKZ3l8g, WsaiHYYZR1-gCg4DjD7v8g)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor js/src/irregexp/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

Comment 5

[Jan de Mooij [:jandem]]

Iain is on leave.

Looks like this needs some small changes to our code.

Comment 6

[Jan de Mooij [:jandem]]

Attachment: WIP: Bug 1922915 - Implement SMRegExpMacroAssembler::SkipUntilBitInTable and define CHECK_IMPLIES.

Comment 7

[Jan de Mooij [:jandem]]

This update is non-trivial because the assembler now has to implement a new SkipUntilBitInTable method. The patch I posted adds the non-SIMD version of this and passes tests. The V8 code also has a SIMD-optimized code path.

Iain knows this code better than I do. He'll be back in about four weeks so maybe we can wait for that.

Comment 8

[Update Bot]

This bug is being closed because a newer revision of the library is available.
This bug will be marked as a duplicate of it (because although this bug is older, it is superseded by the newer one).