1922956 - Clean up widget creation code-paths.

Status: RESOLVED FIXED

(Core :: Widget, task, P3)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1922956 - Remove crashtests trying to create a child popup in a puppet widget. r=Gijs,#layout

I added an assertion that it doesn't happen, because this is not really
well handled (the popup won't show up). This is the only thing
triggering it. I don't think the crashtest is relevant anyways since
<menupopup> doesn't use XUL layout anymore (so setting
MozBoxOrdinalGroup has no effect), so I don't think it's worth porting
to a chrome/browser mochitest.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1922956 - Further clean-up widget creation code-paths. r=#win-reviewers,stransky,#mac-reviewers

This is all super-hacky (see a lot of the XXXcjones comments).

Simplify it... We never create widgets with a bare native parent but no
nsIWidget parent. Pass nsIWidgets and deal with things correctly.

There were also things that were dealing with stuff that can't happen,
like top level popups, children of PuppetWidgets, or such.

Instead of overriding Create(), let's just teach nsBaseWidget about
non-native (headless/puppet) widgets.

Remove lots of old APIs for the native window stuff that are unused
and/or unimplemented.

It's early in the cycle so I'd appreciate landing this sooner rather
than later, since (specially in cocoa) this is a rather scary change,
and I might have the cycles to look into bug 1919165 or so.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a0c81136658
Further clean-up widget creation code-paths. r=win-reviewers,mac-reviewers,geckoview-reviewers,mstange,rkraesig,m_kato

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4efd354e5f9
Make some reftests less flaky on Android.

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6a0c81136658
https://hg.mozilla.org/mozilla-central/rev/e4efd354e5f9