Closed Bug 192318 Opened 21 years ago Closed 21 years ago

clean up fix for bug #191817 in msgHdrViewOverlay.js

Categories

(SeaMonkey :: MailNews: Message Display, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.6alpha

People

(Reporter: sspitzer, Assigned: neil)

Details

(Whiteboard: [sg:nse])

Attachments

(1 file, 3 obsolete files)

neil's got some ways to clean up the fix I landed for #191817 (don't use eval()
for security reasons)

neil has the patch in his tree, so assigning to him.
Marking secure since the comment and filename gives people enough clues to
create an exploit.
Group: security
This makes it easier to add additional context menu items, e.g. view source
Attachment #113996 - Flags: superreview+
Attachment #113997 - Flags: superreview+
Attachment #113998 - Flags: superreview+
/me must remember to check these in :-)
Target Milestone: --- → mozilla1.6alpha
Based on #3.
Attachment #113996 - Attachment is obsolete: true
Attachment #113997 - Attachment is obsolete: true
Attachment #113998 - Attachment is obsolete: true
Attachment #131449 - Flags: superreview?(bienvenu)
Attachment #131449 - Flags: review?(scott)
Comment on attachment 131449 [details] [diff] [review]
Updated for bitrot

sr=bienvenu
Attachment #131449 - Flags: superreview?(bienvenu) → superreview+
Attachment #131449 - Flags: review?(scott) → review+
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Should this land on the 1.4 branch?
Flags: blocking1.4.2?
This is just cleanup, the security fix is already in, right?

It doesn't apply to 1.4.
My understanding is that the security fix is in, this is just cleanup.

Someone correct me if I am wrong.
Flags: blocking1.4.2? → blocking1.4.2-
Removing security flag for this cleanup bug
Group: security
Whiteboard: [sg:nse]
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: