Closed
Bug 192318
Opened 21 years ago
Closed 21 years ago
clean up fix for bug #191817 in msgHdrViewOverlay.js
Categories
(SeaMonkey :: MailNews: Message Display, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.6alpha
People
(Reporter: sspitzer, Assigned: neil)
Details
(Whiteboard: [sg:nse])
Attachments
(1 file, 3 obsolete files)
4.88 KB,
patch
|
mscott
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
neil's got some ways to clean up the fix I landed for #191817 (don't use eval() for security reasons) neil has the patch in his tree, so assigning to him.
Comment 1•21 years ago
|
||
Marking secure since the comment and filename gives people enough clues to create an exploit.
Group: security
Assignee | ||
Comment 2•21 years ago
|
||
Assignee | ||
Comment 3•21 years ago
|
||
Assignee | ||
Comment 4•21 years ago
|
||
This makes it easier to add additional context menu items, e.g. view source
Updated•21 years ago
|
Attachment #113996 -
Flags: superreview+
Updated•21 years ago
|
Attachment #113997 -
Flags: superreview+
Updated•21 years ago
|
Attachment #113998 -
Flags: superreview+
Assignee | ||
Comment 5•21 years ago
|
||
/me must remember to check these in :-)
Target Milestone: --- → mozilla1.6alpha
Assignee | ||
Comment 6•21 years ago
|
||
Based on #3.
Attachment #113996 -
Attachment is obsolete: true
Attachment #113997 -
Attachment is obsolete: true
Attachment #113998 -
Attachment is obsolete: true
Assignee | ||
Updated•21 years ago
|
Attachment #131449 -
Flags: superreview?(bienvenu)
Attachment #131449 -
Flags: review?(scott)
Comment 7•21 years ago
|
||
Comment on attachment 131449 [details] [diff] [review] Updated for bitrot sr=bienvenu
Attachment #131449 -
Flags: superreview?(bienvenu) → superreview+
Updated•21 years ago
|
Attachment #131449 -
Flags: review?(scott) → review+
Assignee | ||
Comment 8•21 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 10•20 years ago
|
||
This is just cleanup, the security fix is already in, right? It doesn't apply to 1.4.
Comment 11•20 years ago
|
||
My understanding is that the security fix is in, this is just cleanup. Someone correct me if I am wrong.
Flags: blocking1.4.2? → blocking1.4.2-
Comment 12•20 years ago
|
||
Removing security flag for this cleanup bug
Group: security
Whiteboard: [sg:nse]
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•