1923193 - [wpt-sync] Sync PR 48503 - compute pressure: Increase timeouts and drop uses of t.step_wait()

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48503 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48503
Details from upstream follow.

Raphael Kubo da Costa <[e-mail]> wrote:

compute pressure: Increase timeouts and drop uses of t.step_wait()

• When we need to wait to verify that an update was not sent, update
  the timeout from 1 second to 3 seconds (and mark tests with
  timeout=long). 1 second is sometimes too little for busy bots such as
  the mac-rel and win-rel ones, which can lead to flakiness or, in this
  case, updates not being delivered for the wrong reason (i.e. the
  browser process just has not had time to process the
  update_virtual_pressure_source() call).

• Introduce a new SyncPressureObserver wrapper class that stores
  multiple pressure updates and allows users to synchronously wait for
  the next one using Promises. This is useful for tests that need to
  send and wait for multiple updates: instead of polling using
  t.step_wait(), these tests can just use this class to wait for a
  Promise to resolve when an update is delivered.

Bug: 347031400
Change-Id: I7880577757d71678e612d912716f4f12020a5fef

Reviewed-on: https://chromium-review.googlesource.com/5912856
WPT-Export-Revision: 3f52e76c8766ae55c719af5c1105701721ebd117

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 48503 applied with additional changes from upstream: 3b5b938807426d70481ad1effdfedb4d3fddc7d7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cd8f8520142d1e2feb29907ea8cdc9ba9ce7cab

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 9 tests and 1 subtests

Status Summary

Firefox

OK : 5
PASS : 1
FAIL : 9
TIMEOUT: 4
ERROR : 4
NOTRUN : 1

Chrome

OK : 9
PASS : 15

Safari

OK : 5
PASS : 1
FAIL : 9
TIMEOUT: 4
ERROR : 4
NOTRUN : 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /compute-pressure/compute_pressure_detached_iframe.https.window.html?globalScope=window [wpt.fyi]
  • PressureObserver.observe() on detached frame rejects: FAIL (Chrome: PASS, Safari: FAIL)
  • PressureObserver.disconnect() on detached frame returns: FAIL (Chrome: PASS, Safari: FAIL)
  • Detaching frame while PressureObserver.observe() settles: FAIL (Chrome: PASS, Safari: FAIL)
  • PressureObserver on detached frame returns with no callback: FAIL (Chrome: PASS, Safari: FAIL)
• /compute-pressure/compute_pressure_duplicate_updates.https.window.html?globalScope=dedicated_worker [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
  • Changes that fail the "has change in data" test are discarded.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /compute-pressure/compute_pressure_duplicate_updates.https.window.html?globalScope=window [wpt.fyi]
  • Changes that fail the "has change in data" test are discarded.: FAIL (Chrome: PASS, Safari: FAIL)
• /compute-pressure/compute_pressure_timestamp.https.window.html?globalScope=dedicated_worker [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
  • Timestamp from update should be tied to the global object's time origin: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
  • disconnect() should update [[LastRecordMap]]: NOTRUN (Chrome: PASS, Safari: NOTRUN)
• /compute-pressure/compute_pressure_timestamp.https.window.html?globalScope=window [wpt.fyi]
  • Timestamp from update should be tied to the global object's time origin: FAIL (Chrome: PASS, Safari: FAIL)
  • disconnect() should update [[LastRecordMap]]: FAIL (Chrome: PASS, Safari: FAIL)
• /compute-pressure/compute_pressure_timestamp_continuously_increasing.https.window.html?globalScope=window [wpt.fyi]
  • Timestamp difference between two changes should be continuously increasing: FAIL (Chrome: PASS, Safari: FAIL)
• /compute-pressure/compute_pressure_timestamp_continuously_increasing.https.window.html?globalScope=dedicated_worker [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
  • Timestamp difference between two changes should be continuously increasing: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /compute-pressure/compute_pressure_timestamp_faster_collector.https.window.html?globalScope=dedicated_worker [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
  • Faster collector: Timestamp difference between two changes should be higher or equal to the observer sample rate: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
• /compute-pressure/compute_pressure_timestamp_faster_collector.https.window.html?globalScope=window [wpt.fyi]
  • Faster collector: Timestamp difference between two changes should be higher or equal to the observer sample rate: FAIL (Chrome: PASS, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bed30abd3cc7
[wpt PR 48503] - compute pressure: Increase timeouts and drop uses of t.step_wait(), a=testonly
https://hg.mozilla.org/integration/autoland/rev/951144375fdf
[wpt PR 48503] - Update wpt metadata, a=testonly

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/bed30abd3cc7
https://hg.mozilla.org/mozilla-central/rev/951144375fdf