Closed Bug 1923267 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 48515 - [css-typed-om] Avoid infinite recursion when serializing CSSUnparsedValue

Categories

(Core :: DOM: CSS Object Model, task, P4)

Product:
Core
Component:
DOM: CSS Object Model
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
firefox133 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48515 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48515
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[css-typed-om] Avoid infinite recursion when serializing CSSUnparsedValue

It's possible to create cyclic CSSUnparsedValues. This causes infinite
recursion when serializing the value. The spec needs to say how this
should be handled, but meanwhile, we handle the problem by serializing
an empty string for cycles.

Fixed: 371292572
Change-Id: I15ff38ff2b87eecec1f175d6aab7736dcf8091ed
Reviewed-on: https://chromium-review.googlesource.com/5905363
WPT-Export-Revision: aea22f0d707917dd3a8b66963460652ca776544f

Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

OK : 1
PASS : 1
FAIL : 5

Chrome

OK : 1
PASS : 5
CRASH: 1

Safari

OK : 1
PASS : 2
CRASH: 1
FAIL : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /css/css-typed-om/stylevalue-serialization/cssUnparsedValue.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
    • CSSUnparsedValue containing strings serializes to its tokenized contents: FAIL (Chrome: PASS, Safari: FAIL)
    • CSSUnparsedValue containing variable references serializes its tokenized contents: FAIL (Chrome: PASS, Safari: PASS)
    • CSSUnparsedValue containing mix of strings and variable references serializes to its tokenized contents: FAIL (Chrome: PASS, Safari: FAIL)
    • CSSUnparsedValue can hold same object in multiple places: FAIL (Chrome: PASS, Safari: PASS)
    • attributeStyleMap round-trips correctly, though the comment is gone: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

  • /css/css-typed-om/stylevalue-serialization/cssUnparsedValue.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/df33716f0e62 [wpt PR 48515] - [css-typed-om] Avoid infinite recursion when serializing CSSUnparsedValue, a=testonly

https://hg.mozilla.org/mozilla-central/rev/df33716f0e62

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox133: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.