1923313 - Impression and Dismiss events for cards from the “Need to Know” contextual content section are incomplete

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Alexandru Bejenaru [:abejenaru], Ecosystem QA]

[Affected versions]:

• Firefox Beta 132.0b4, BUILD ID: 20241007091632.
• Firefox Nightly 133.0a1, BUILD ID: 20241007210631.

[Affected Platforms]:

• Windows 10, Windows 11.
• macOS 15.0.1.
• Ubuntu 22.04.

[Prerequisites]:

• Have a new profile with the “browser.search.region” pref from the “about:config” page set to any of the supported regions (“US”, “GB”, “DE”).
• In the same profile, have the “browser.newtabpage.activity-stream.discoverystream.contextualContent.enabled” pref from “about:config” page set to “true” (preffed off by default).

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Navigate to the “about:glean” page, input any tag name, select “newtab”, and click the “Apply settings and submit ping” button.
3. Open a new tab and close it.
4. Navigate to the https://debug-ping-preview.firebaseapp.com/pings/tag_name_here page and verify the generated pings.

[Expected result]:

• All telemetry events originating from cards from the “Need to Know” section contain the “is_list_card” property.

[Actual result]:

• The “impression” events from the “newtab” ping do not contain the “is_list_card” property, making it hard to determine their source.

[Additional Notes]:

• This issue is also reproducible with the "dismiss" events of the “Need to Know” section.
• Navigating to the “about:telemetry#events-tab”, it seems that the value of the events is registered as “CARDGRID”, which is the same as any other card from the main Pocket feed.

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 1923313 - Add is_list_card attribute to impression/dismiss telemetry events r?#home-newtab-reviewers

Comment 2

[Maxx Crawford [:maxx]]

Attachment: Bug 1923313 - Add is_list_card attribute to impression/dismiss telemetry events r?#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D225376

Comment 3

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: This would impact the timeline for contextual content experiment which delays the feature being released to users
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See test plan in https://phabricator.services.mozilla.com/D225376
• Risk associated with taking this patch: Low
• Explanation of risk level: All code related to this experiment (including this change) are behind prefs. This code will only be exposed to users in the experiment branch of the contextual content experiment
• String changes made/needed: No
• Is Android affected?: no

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8918fddc242c
Add is_list_card attribute to impression/dismiss telemetry events r=home-newtab-reviewers,thecount

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8918fddc242c

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/a6ef35d3e376

Comment 7

[Alexandru Bejenaru [:abejenaru], Ecosystem QA]

Hello. We have verified this issue on Windows 10 x64 using:

• Firefox Beta 132.0b7 (Build ID: 20241014091808), en-US locale
• Firefox Nightly 133.0a1 (Build ID: 20241014095457), en-US locale

And we were unable to reproduce it anymore. The mentioned telemetry events now contain the "is_list_card": "true" for cards from the "Need to Know" contextual context section.

Note that telemetry events for all other cards from the main feed area do not contain the "is_list_card": "false" property, which was never stated as something required but we felt it was worth mentioning. As a result I'm marking this as Verified Fixed.