1923336 - DAMP doesn't cover DOM Element and Node List logging correctly

Status: RESOLVED FIXED

(DevTools :: Console, enhancement)

Description

[Alexandre Poirot [:ochameau]]

The following two lines are running before the DOM elements they refer to are created, leading them to test unexpected things (null and empty node list)

Comment 1

[Alexandre Poirot [:ochameau]]

This fix expectedly regresses the two node (200%) and nodelist (30%) tests:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=902a9500a21b3ddd15572e1d7897aa4c1f7293aa&originalSignature=4763542&newSignature=4763542&framework=12&application=firefox&originalRevision=049e51fe2843ad7be104fa402066c4e627adc164&page=1&showOnlyConfident=1

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1923336 - [devtools] Fix DAMP DOM elements and Node List logging.

When this code runs, the DOM elements aren't created yet.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b357915c617a
[devtools] Fix DAMP DOM elements and Node List logging. r=devtools-reviewers,perftest-reviewers,jdescottes,sparky

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b357915c617a

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Perfherder has detected a devtools performance change from push b357915c617a21167a8f979c6e6b3ee31cd5e6a9.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
248%	damp console.log-in-loop-content-process-node	macosx1015-64-shippable-qr	e10s fission stylo webrender	66.33 -> 230.74
225%	damp console.log-in-loop-content-process-node	windows11-64-shippable-qr	e10s fission stylo webrender	31.21 -> 101.50
185%	damp console.log-in-loop-content-process-node	linux1804-64-shippable-qr	e10s fission stylo webrender	100.06 -> 285.15
182%	damp console.log-in-loop-content-process-node	linux1804-64-shippable-qr	e10s fission stylo webrender	100.89 -> 284.81
28%	damp console.log-in-loop-content-process-nodelist	macosx1015-64-shippable-qr	e10s fission stylo webrender	765.36 -> 978.46
24%	damp console.log-in-loop-content-process-nodelist	linux1804-64-shippable-qr	e10s fission stylo webrender	923.66 -> 1,148.25
22%	damp console.log-in-loop-content-process-nodelist	windows11-64-shippable-qr	e10s fission stylo webrender	353.44 -> 432.57