Closed Bug 1923336 Opened 1 month ago Closed 1 month ago

DAMP doesn't cover DOM Element and Node List logging correctly

Categories

(DevTools :: Console, enhancement)

enhancement

Tracking

(firefox133 fixed)

RESOLVED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

The following two lines are running before the DOM elements they refer to are created, leading them to test unexpected things (null and empty node list)

When this code runs, the DOM elements aren't created yet.

Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b357915c617a [devtools] Fix DAMP DOM elements and Node List logging. r=devtools-reviewers,perftest-reviewers,jdescottes,sparky
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch

Perfherder has detected a devtools performance change from push b357915c617a21167a8f979c6e6b3ee31cd5e6a9.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
248% damp console.log-in-loop-content-process-node macosx1015-64-shippable-qr e10s fission stylo webrender 66.33 -> 230.74
225% damp console.log-in-loop-content-process-node windows11-64-shippable-qr e10s fission stylo webrender 31.21 -> 101.50
185% damp console.log-in-loop-content-process-node linux1804-64-shippable-qr e10s fission stylo webrender 100.06 -> 285.15
182% damp console.log-in-loop-content-process-node linux1804-64-shippable-qr e10s fission stylo webrender 100.89 -> 284.81
28% damp console.log-in-loop-content-process-nodelist macosx1015-64-shippable-qr e10s fission stylo webrender 765.36 -> 978.46
24% damp console.log-in-loop-content-process-nodelist linux1804-64-shippable-qr e10s fission stylo webrender 923.66 -> 1,148.25
22% damp console.log-in-loop-content-process-nodelist windows11-64-shippable-qr e10s fission stylo webrender 353.44 -> 432.57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: