Closed Bug 1923367 Opened 1 month ago Closed 26 days ago

Go back to using the dropdown icon for all-tabs button when it's in the tabs toolbar

Categories

(Firefox :: Theme, task, P1)

task
Points:
2

Tracking

()

RESOLVED FIXED
133 Branch
Tracking Status
firefox131 + fixed
firefox132 + fixed
firefox133 + fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 3 open bugs)

Details

(Whiteboard: [fidefe-tabgrps-tabbrowser])

Attachments

(2 files)

UX recommends that we keep the dropdown icon for the all-tabs button in the horizontal tab strip. This will hopefully help with users complaining about the button, thinking it's a new one. It does add complexity for the callout when an extension hides tabs (that includes the button icon) and for SUMO, but it was decided that we'll have to deal with that.

thinking it's a new one.

I am not sure if it's really because the button looks different now. There used to be an option to disable the button and this option was removed in the same version as the icon change (bug 1916622). So for people who used this option, it is a new button.

(In reply to Sören Hentzschel from comment #1)

thinking it's a new one.

I am not sure if it's really because the button looks different now. There used to be an option to disable the button and this option was removed in the same version as the icon change (bug 1916622). So for people who used this option, it is a new button.

Didn't mean to generalize too much here. Yes, we can assume that some users had flipped the pref, but it still seems odd that they'd think it's a new button, because they would presumably recognize the menu if they had looked at it before and decided to remove it. Some feedback we got does seem to indicate that some folks really just never noticed or cared about the button when it had the generic dropdown icon.

Anyway, we're going to address bug 1918681 too, so this question is sort of moot.

Blocks: 1923393

This is for mozilla-central. Will post a separate patch for beta and release.

User response:
It is new because now it has appeared in the toolbar. Before, it was discreetly in the top left corner and could easily be disabled.
Today, it sits among our commonly used tools and sits alongside the “extension” button, itself immutable; so it gets noticed and annoys users who have spent an hour personalizing their Firefox and see their personalization called into question.

Never forget: a large proportion of Firefox users care a lot about their personalization!

Sincerely(In reply to Dão Gottwald [:dao] from comment #2)

User response:
It is new because now it has appeared in the toolbar. Before, it was discreetly in the top left corner and could easily be disabled.
Today, it sits among our commonly used tools and sits alongside the “extension” button, itself immutable; so it gets noticed and annoys users who have spent an hour personalizing their Firefox and see their personalization called into question.

Never forget: a large proportion of Firefox users care a lot about their personalization!

Sincerely

Attachment #9429657 - Flags: approval-mozilla-beta?

Comment on attachment 9429657 [details]
Bug 1923367 - Revert bug 1910203 (patch for beta and release). r?#theme

Beta/Release Uplift Approval Request

  • User impact if declined: See comment 0
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Straight backout of bug 1910203. (The complexity I mentioned in comment 0 only applies to the patch for mozilla-central.)
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9429657 - Flags: approval-mozilla-release?
Blocks: 1923411
Attachment #9429655 - Attachment description: Bug 1923367 - Go back to using the dropdown icon for all-tabs button when it's in the tabs toolbar. r=gijs → Bug 1923367 - Go back to using the dropdown icon for all-tabs button when it's in the tabs toolbar. r=#theme

Comment on attachment 9429657 [details]
Bug 1923367 - Revert bug 1910203 (patch for beta and release). r?#theme

Approved for 132.0b5.

Attachment #9429657 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Duplicate of this bug: 1923393
No longer blocks: 1923393
Priority: -- → P1
See Also: → 1923411
See Also: 1923411

Comment on attachment 9429657 [details]
Bug 1923367 - Revert bug 1910203 (patch for beta and release). r?#theme

Approved for 131.0.3 dot release

Attachment #9429657 - Flags: approval-mozilla-release? → approval-mozilla-release+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/756b1c3bfb88 Go back to using the dropdown icon for all-tabs button when it's in the tabs toolbar. r=desktop-theme-reviewers,tabbrowser-reviewers,rpl
Status: ASSIGNED → RESOLVED
Closed: 26 days ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
Duplicate of this bug: 1921708
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: