Go back to using the dropdown icon for all-tabs button when it's in the tabs toolbar
Categories
(Firefox :: Theme, task, P1)
Tracking
()
People
(Reporter: dao, Assigned: dao)
References
(Blocks 3 open bugs)
Details
(Whiteboard: [fidefe-tabgrps-tabbrowser])
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
diannaS
:
approval-mozilla-release+
|
Details | Review |
UX recommends that we keep the dropdown icon for the all-tabs button in the horizontal tab strip. This will hopefully help with users complaining about the button, thinking it's a new one. It does add complexity for the callout when an extension hides tabs (that includes the button icon) and for SUMO, but it was decided that we'll have to deal with that.
Updated•1 month ago
|
Comment 1•1 month ago
|
||
thinking it's a new one.
I am not sure if it's really because the button looks different now. There used to be an option to disable the button and this option was removed in the same version as the icon change (bug 1916622). So for people who used this option, it is a new button.
Assignee | ||
Comment 2•1 month ago
|
||
(In reply to Sören Hentzschel from comment #1)
thinking it's a new one.
I am not sure if it's really because the button looks different now. There used to be an option to disable the button and this option was removed in the same version as the icon change (bug 1916622). So for people who used this option, it is a new button.
Didn't mean to generalize too much here. Yes, we can assume that some users had flipped the pref, but it still seems odd that they'd think it's a new button, because they would presumably recognize the menu if they had looked at it before and decided to remove it. Some feedback we got does seem to indicate that some folks really just never noticed or cared about the button when it had the generic dropdown icon.
Anyway, we're going to address bug 1918681 too, so this question is sort of moot.
Assignee | ||
Comment 3•1 month ago
|
||
This is for mozilla-central. Will post a separate patch for beta and release.
User response:
It is new because now it has appeared in the toolbar. Before, it was discreetly in the top left corner and could easily be disabled.
Today, it sits among our commonly used tools and sits alongside the “extension” button, itself immutable; so it gets noticed and annoys users who have spent an hour personalizing their Firefox and see their personalization called into question.
Never forget: a large proportion of Firefox users care a lot about their personalization!
Sincerely(In reply to Dão Gottwald [:dao] from comment #2)
User response:
It is new because now it has appeared in the toolbar. Before, it was discreetly in the top left corner and could easily be disabled.
Today, it sits among our commonly used tools and sits alongside the “extension” button, itself immutable; so it gets noticed and annoys users who have spent an hour personalizing their Firefox and see their personalization called into question.
Never forget: a large proportion of Firefox users care a lot about their personalization!
Sincerely
Assignee | ||
Comment 5•1 month ago
|
||
Updated•1 month ago
|
Assignee | ||
Comment 6•1 month ago
•
|
||
Comment on attachment 9429657 [details]
Bug 1923367 - Revert bug 1910203 (patch for beta and release). r?#theme
Beta/Release Uplift Approval Request
- User impact if declined: See comment 0
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Straight backout of bug 1910203. (The complexity I mentioned in comment 0 only applies to the patch for mozilla-central.)
- String changes made/needed:
- Is Android affected?: No
Assignee | ||
Updated•1 month ago
|
Updated•1 month ago
|
Comment 7•1 month ago
|
||
Comment on attachment 9429657 [details]
Bug 1923367 - Revert bug 1910203 (patch for beta and release). r?#theme
Approved for 132.0b5.
Updated•1 month ago
|
Assignee | ||
Updated•28 days ago
|
Comment 10•28 days ago
|
||
Comment on attachment 9429657 [details]
Bug 1923367 - Revert bug 1910203 (patch for beta and release). r?#theme
Approved for 131.0.3 dot release
Updated•28 days ago
|
Comment 11•28 days ago
|
||
uplift |
Comment 12•27 days ago
|
||
Comment 13•26 days ago
|
||
bugherder |
Description
•