1923428 - Unnecessary barriers during Map/Set finalization

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement)

Description

[Jon Coppeard (:jonco)]

While profiling I noticed that prebarriers were showing up during MapObject finalization. These are not necessary when the GC is destroying things itself so we should be able to remove them.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1923428 - Remove barriers when finalizing Map/Set tables r?jandem

This changes the Map/Set code to create and destroy the ordered hash table
tables as the unbarriered version and then casts as necessary elsewhere.

I changed the accessors to use reinterpret_cast rather than calling
maybePtrFromReservedSlot which uses static_cast as this is slightly less
dubious.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee0dfaa78303
Remove barriers when finalizing Map/Set tables r=jandem

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ee0dfaa78303