1923463 - AutoProfileRunnable distorts ETW profiles

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Olli Pettay [:smaug][[e-mail]]]

It shows up for example in News-Site-Next sp3 profiles.

Comment 1

[Denis Palmeiro [:denispal]]

I think this is Windows specific, since it seems enabling ETW will add some profiler marker overhead in these cases due to https://searchfox.org/mozilla-central/rev/488d81581a9142d532bf814efa60564ff11599ca/tools/profiler/public/ProfilerMarkers.h#139

Comment 2

[Markus Stange [:mstange]]

Bas, can you make this check whether we're actually collecting runnable information with the current ETW session?

Comment 3

[Florian Quèze [:florian]]

(In reply to Olli Pettay [:smaug][[e-mail]] from comment #0)

It shows up for example in News-Site-Next sp3 profiles.

A link to an example profile would be nice.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

https://share.firefox.dev/3NhRIBG

Comment 5

[Bas Schouten (:bas.schouten)]

Attachment: Bug 1923463: Avoid profiling runnables when using ETW and not collecting scheduling information. r=mstange

Comment 6

[Bas Schouten (:bas.schouten)]

This should do the job.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc486d6d2a1f
Avoid profiling runnables when using ETW and not collecting scheduling information. r=mstange,profiler-reviewers

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fc486d6d2a1f