Closed Bug 1923546 Opened 2 years ago Closed 2 years ago

Perma TEST-UNEXPECTED-FAIL | dom/events/test/browser_dragdrop_protected_diff_origin.js | [tab1->tab1|dragSource]| mousedown existed - false == true - got false, expected true (operator ==)

Categories

(Core :: DOM: UI Events & Focus Handling, defect, P5)

defect

Tracking

()

RESOLVED FIXED
133 Branch
Tracking Status
firefox-esr128 --- unaffected
firefox131 --- unaffected
firefox132 --- unaffected
firefox133 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: emilio)

References

(Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: [stockwell disabled])

Attachments

(1 external file)

Filed by: tszentpeteri [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=477409053&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/UucDCZdqRre_ZiadV3du_g/runs/0/artifacts/public/logs/live_backing.log


[task 2024-10-08T23:58:12.520Z] 23:58:12     INFO - TEST-PASS | dom/events/test/browser_dragdrop_protected_diff_origin.js | [tab1->tab1|dragTarget]| dragElement exists - {} == true - 
[task 2024-10-08T23:58:12.521Z] 23:58:12     INFO - [tab1->tab1|dragTarget]| getBoundingClientRect(): left: 8, top: 77.60000610351562, right: 72, bottom: 141.60000610351562
[task 2024-10-08T23:58:12.521Z] 23:58:12     INFO - [tab1->tab1|dragSource]| clientpos: 8,8, screenPos: 12,117
[task 2024-10-08T23:58:12.521Z] 23:58:12     INFO - [tab1->tab1|dragTarget]| clientpos: 8,78, screenPos: 12,187
[task 2024-10-08T23:58:12.522Z] 23:58:12     INFO - [tab1->tab1]| screenSrcPos: 12,117 | screenTargetPos: 12,187
[task 2024-10-08T23:58:12.522Z] 23:58:12     INFO - [tab1->tab1]| sending mousedown at 12, 117
[task 2024-10-08T23:58:12.522Z] 23:58:12     INFO - [tab1->tab1]| mousedown sent
[task 2024-10-08T23:58:12.523Z] 23:58:12     INFO - Buffered messages finished
[task 2024-10-08T23:58:12.524Z] 23:58:12     INFO - TEST-UNEXPECTED-FAIL | dom/events/test/browser_dragdrop_protected_diff_origin.js | [tab1->tab1|dragSource]| mousedown existed - false == true - got false, expected true (operator ==)
[task 2024-10-08T23:58:12.524Z] 23:58:12     INFO - Stack trace:
[task 2024-10-08T23:58:12.524Z] 23:58:12     INFO - ok@resource://testing-common/SpecialPowersSandbox.sys.mjs:85:21
[task 2024-10-08T23:58:12.524Z] 23:58:12     INFO - DragChildContextBase/this.ok@chrome://mochikit/content/tests/SimpleTest/DragChildContextBase.sys.mjs:148:15
[task 2024-10-08T23:58:12.524Z] 23:58:12     INFO - checkMouseDown@chrome://mochikit/content/tests/SimpleTest/DragSourceChildContext.sys.mjs:42:12
[task 2024-10-08T23:58:12.524Z] 23:58:12     INFO - @chrome://mochikit/content/tests/SimpleTest/DragParentContextBase.sys.mjs:70:51
[task 2024-10-08T23:58:12.524Z] 23:58:12     INFO - execute@resource://testing-common/SpecialPowersSandbox.sys.mjs:139:12
[task 2024-10-08T23:58:12.524Z] 23:58:12     INFO - _spawnTask@resource://testing-common/SpecialPowersChild.sys.mjs:1620:15
[task 2024-10-08T23:58:12.525Z] 23:58:12     INFO - receiveMessage@resource://testing-common/SpecialPowersChild.sys.mjs:255:21
[task 2024-10-08T23:58:12.525Z] 23:58:12     INFO - JSActor query*receiveMessage@resource://testing-common/SpecialPowersParent.sys.mjs:1383:14
[task 2024-10-08T23:58:12.525Z] 23:58:12     INFO - JSActor query*spawn@resource://testing-common/SpecialPowersChild.sys.mjs:1549:17
[task 2024-10-08T23:58:12.525Z] 23:58:12     INFO - runRemote@chrome://mochikit/content/tests/SimpleTest/DragParentContextBase.sys.mjs:65:31
[task 2024-10-08T23:58:12.525Z] 23:58:12     INFO - checkMouseDown@chrome://mochikit/content/tests/SimpleTest/DragSourceParentContext.sys.mjs:36:17
[task 2024-10-08T23:58:12.525Z] 23:58:12     INFO - synthesizeMockDragAndDrop@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:4310:21
[task 2024-10-08T23:58:12.525Z] 23:58:12     INFO - async*runDnd@chrome://mochitests/content/browser/dom/events/test/browser_dragdrop_impl.js:31:21
[task 2024-10-08T23:58:12.525Z] 23:58:12     INFO - test_dnd_tab1_to_tab1@chrome://mochitests/content/browser/dom/events/test/browser_dragdrop_impl.js:129:9
[task 2024-10-08T23:58:12.525Z] 23:58:12     INFO - handleTask@chrome://mochikit/content/browser-test.js:1145:26
[task 2024-10-08T23:58:12.525Z] 23:58:12     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1217:18
[task 2024-10-08T23:58:12.525Z] 23:58:12     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1358:14
[task 2024-10-08T23:58:12.525Z] 23:58:12     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1134:14
[task 2024-10-08T23:58:12.525Z] 23:58:12     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-10-08T23:58:12.525Z] 23:58:12     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-10-08T23:58:12.527Z] 23:58:12     INFO - TEST-UNEXPECTED-FAIL | dom/events/test/browser_dragdrop_protected_diff_origin.js | [tab1->tab1|dragSource]| 	element received proper number of mousedown events. - 0 == 1 - got 0, expected 1 (operator ==)
[task 2024-10-08T23:58:12.527Z] 23:58:12     INFO - Stack trace:
[task 2024-10-08T23:58:12.527Z] 23:58:12     INFO - is@resource://testing-common/SpecialPowersSandbox.sys.mjs:88:21
[task 2024-10-08T23:58:12.527Z] 23:58:12     INFO - DragChildContextBase/this.is@chrome://mochikit/content/tests/SimpleTest/DragChildContextBase.sys.mjs:151:15
[task 2024-10-08T23:58:12.527Z] 23:58:12     INFO - checkExpected@chrome://mochikit/content/tests/SimpleTest/DragChildContextBase.sys.mjs:74:12
[task 2024-10-08T23:58:12.527Z] 23:58:12     INFO - checkMouseDown@chrome://mochikit/content/tests/SimpleTest/DragSourceChildContext.sys.mjs:53:16
[task 2024-10-08T23:58:12.527Z] 23:58:12     INFO - @chrome://mochikit/content/tests/SimpleTest/DragParentContextBase.sys.mjs:70:51
[task 2024-10-08T23:58:12.527Z] 23:58:12     INFO - execute@resource://testing-common/SpecialPowersSandbox.sys.mjs:139:12
[task 2024-10-08T23:58:12.527Z] 23:58:12     INFO - _spawnTask@resource://testing-common/SpecialPowersChild.sys.mjs:1620:15
[task 2024-10-08T23:58:12.527Z] 23:58:12     INFO - receiveMessage@resource://testing-common/SpecialPowersChild.sys.mjs:255:21
[task 2024-10-08T23:58:12.528Z] 23:58:12     INFO - JSActor query*receiveMessage@resource://testing-common/SpecialPowersParent.sys.mjs:1383:14
[task 2024-10-08T23:58:12.528Z] 23:58:12     INFO - JSActor query*spawn@resource://testing-common/SpecialPowersChild.sys.mjs:1549:17
[task 2024-10-08T23:58:12.528Z] 23:58:12     INFO - runRemote@chrome://mochikit/content/tests/SimpleTest/DragParentContextBase.sys.mjs:65:31
[task 2024-10-08T23:58:12.528Z] 23:58:12     INFO - checkMouseDown@chrome://mochikit/content/tests/SimpleTest/DragSourceParentContext.sys.mjs:36:17
[task 2024-10-08T23:58:12.528Z] 23:58:12     INFO - synthesizeMockDragAndDrop@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:4310:21
[task 2024-10-08T23:58:12.528Z] 23:58:12     INFO - async*runDnd@chrome://mochitests/content/browser/dom/events/test/browser_dragdrop_impl.js:31:21
[task 2024-10-08T23:58:12.528Z] 23:58:12     INFO - test_dnd_tab1_to_tab1@chrome://mochitests/content/browser/dom/events/test/browser_dragdrop_impl.js:129:9
[task 2024-10-08T23:58:12.528Z] 23:58:12     INFO - handleTask@chrome://mochikit/content/browser-test.js:1145:26
[task 2024-10-08T23:58:12.528Z] 23:58:12     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1217:18
[task 2024-10-08T23:58:12.528Z] 23:58:12     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1358:14
[task 2024-10-08T23:58:12.528Z] 23:58:12     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1134:14
[task 2024-10-08T23:58:12.528Z] 23:58:12     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-10-08T23:58:12.528Z] 23:58:12     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-10-08T23:58:12.530Z] 23:58:12     INFO - TEST-UNEXPECTED-FAIL | dom/events/test/browser_dragdrop_protected_diff_origin.js | [tab1->tab1|dragSource]| 	document received proper number of mousedown events. - 0 == 1 - got 0, expected 1 (operator ==)
[task 2024-10-08T23:58:12.530Z] 23:58:12     INFO - Stack trace:
[task 2024-10-08T23:58:12.530Z] 23:58:12     INFO - is@resource://testing-common/SpecialPowersSandbox.sys.mjs:88:21
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - DragChildContextBase/this.is@chrome://mochikit/content/tests/SimpleTest/DragChildContextBase.sys.mjs:151:15
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - checkExpected@chrome://mochikit/content/tests/SimpleTest/DragChildContextBase.sys.mjs:79:12
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - checkMouseDown@chrome://mochikit/content/tests/SimpleTest/DragSourceChildContext.sys.mjs:53:16
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - @chrome://mochikit/content/tests/SimpleTest/DragParentContextBase.sys.mjs:70:51
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - execute@resource://testing-common/SpecialPowersSandbox.sys.mjs:139:12
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - _spawnTask@resource://testing-common/SpecialPowersChild.sys.mjs:1620:15
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - receiveMessage@resource://testing-common/SpecialPowersChild.sys.mjs:255:21
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - JSActor query*receiveMessage@resource://testing-common/SpecialPowersParent.sys.mjs:1383:14
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - JSActor query*spawn@resource://testing-common/SpecialPowersChild.sys.mjs:1549:17
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - runRemote@chrome://mochikit/content/tests/SimpleTest/DragParentContextBase.sys.mjs:65:31
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - checkMouseDown@chrome://mochikit/content/tests/SimpleTest/DragSourceParentContext.sys.mjs:36:17
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - synthesizeMockDragAndDrop@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:4310:21
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - async*runDnd@chrome://mochitests/content/browser/dom/events/test/browser_dragdrop_impl.js:31:21
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - test_dnd_tab1_to_tab1@chrome://mochitests/content/browser/dom/events/test/browser_dragdrop_impl.js:129:9
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - handleTask@chrome://mochikit/content/browser-test.js:1145:26
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1217:18
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1358:14
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1134:14
[task 2024-10-08T23:58:12.531Z] 23:58:12     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-10-08T23:58:12.532Z] 23:58:12     INFO - TEST-PASS | dom/events/test/browser_dragdrop_protected_diff_origin.js | [tab1->tab1|dragSource]| 	element received proper number of mouseup events. - 0 == 0 - 

Set release status flags based on info from the regressing bug 1922956

:emilio, since you are the author of the regressor, bug 1922956, could you take a look?

For more information, please visit BugBot documentation.

This is Mac specific right?

Flags: needinfo?(emilio) → needinfo?(tszentpeteri)
Flags: needinfo?(emilio)
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38735bc33d7a Disable browser_dragdrop_protected_diff_origin.js temporarily on mac until a fix is in place. a=test-only
Keywords: leave-open
Whiteboard: [stockwell disabled]

Ah, so both debug and opt, good to know.

Assignee: nobody → emilio
Pushed by csabou@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/ba301423863e Disable browser_dragdrop_protected_diff_origin.js temporarily on mac until a fix is in place. a=test-only
Pushed by smolnar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a772227e4782 Disable browser_dragdrop_protected_same_origin temporarily on mac until a fix is in place. a=test-only CLOSED TREE

@emilio, also disabled browser_dragdrop_protected_same_origin.js for perma failure on mac

After disabling browser_dragdrop_protected_same_origin.js , the next test browser_dragdrop_unprotected_diff_origin.js started perma-failing so it's futile to continue disabling it.

Ok I'll look at this asap. That probably means some state from the previous test show persisted.

Ok, so I understand this, but it's a bit annoying.

The main issue is that my patch changed this widget to be the nsCocoaWidget rather than the nsChildView.

However the nsCocoaWindow is the "right" widget to return when you ask for a top level widget...

Flags: needinfo?(emilio)

Bug 1922956 made it so that nsChildView::GetTopLevelWidget() properly
returned the top level nsCocoaWindow. However that meant that
MockDragServiceController::SendEvent started sending events through the
wrong widget (because the nsChildView is the thing that has the APZ
state and such).

However the fix is trivial. Use GetWidgetForContent in order to
determine which widget to fire the event to, restoring the previous
behavior and fixing the tests.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d1706ab9250c Fix MockDragServiceController on macOS after bug 1922956. r=handyman
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: