1923638 - [Toolbar redesign] Rotating screen for PWAS with fixed bottom toolbars shows empty space at bottom

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: EmptySpaceInPWA.mp4

Steps to reproduce

1. Have the toolbar set at bottom or the navbar enabled
2. Disable "Scroll to hide toolbar" from Settings -> Customize
3. Install & open a PWA like https://phanpy.social/
4. Rotate the screen

Expected behavior

The browser remains occupying the entire screen minus the OS bars.

Actual behavior

The browser is now padded with what would be the height of the bottom toolbar (which is not actually showing).

Device information

• Firefox version: Happens on current Beta / Nightly.

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1923638 - Ignore toolbars when configuring the engine view if in a PWA r=#android-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a8f168554a0
Ignore toolbars when configuring the engine view if in a PWA r=android-reviewers,skhan

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2a8f168554a0

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Adding back the NI to request beta uplift after QA validates this in Nightly.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Just for clarity, we're building the final Beta of the cycle on Friday before next week's RC. If the plan is to uplift this, we'll need the request pretty soon.

Comment 7

[Delia Pop (Android QA)]

Attachment: Nightly 133_1017.mp4

Verified as fixed in the latest Nightly 13.0a1 from 10/17 with Samsung Galaxy S22 Ultra (Android 14) and Google Pixel 8 Pro (Android 14).
Tested with the new and the old toolbars.

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9430124 [details]
Bug 1923638 - Ignore toolbars when configuring the engine view if in a PWA r=#android-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Empty space shown in PWAs after rotating the screen
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:
  • Have the toolbar set at bottom or the navbar enabled
  • Disable "Scroll to hide toolbar" from Settings -> Customize
  • Install & open a PWA like https://phanpy.social/
  • Rotate the screen
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small targeted change verified by QA.
• String changes made/needed:
• Is Android affected?: Yes

Comment 9

[Ryan VanderMeulen [:RyanVM]]

This

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9430124 [details]
Bug 1923638 - Ignore toolbars when configuring the engine view if in a PWA r=#android-reviewers

Approved for 132.0b9.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8b37748edfca

Comment 12

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1923638 - Expand visibility of webAppToolbarShouldBeVisible r=#android-reviewers

This is needed for a beta uplift of the initial patch.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/82f483530cdb

Comment 14

[Delia Pop (Android QA)]

Attachment: media_20241021_145144_8096356855031010742.mp4

Verified as fixed in Beta 132.0b9 with LG G7 fit (Android 9) and Google Pixel 8 Pro (Android 14).