192369 - Doesn't set _NET_WM_ICON_NAME property

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[smoynes]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021204
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021204

Mozilla sets the UTF8 encoded hint _NET_WM_NAME but does set the
_NET_WM_ICON_NAME hint. According to
http://www.freedesktop.org/standards/wm-spec/1.3/html/x231.html a window manager
should fall back to WM_NAME which is ANSI encoded. So if the webpage has a title
in UTF8 the icon name may not be encoded properly. This can cause problems with
some window managers or desktop environments.

Reproducible: Always

Steps to Reproduce:
1. Visit a webpage with a UTF8 encoded title. eg. http://sslug.dk/locale/utf-8
2. xprop the window


Actual Results:  
Relevant hints:
_NET_WM_NAME(UTF8_STRING) = 0x53, 0x53, 0x4c, 0x55, 0x47, 0x20, 0x2d, 0x20,
0x48, 0xc3, 0xa5, 0x6e, 0x64, 0x74, 0x65, 0x72, 0x69, 0x6e, 0x67, 0x20, 0x61,
0x66, 0x20, 0x55, 0x54, 0x46, 0x2d, 0x38, 0x2d, 0x6b, 0x6f, 0x64, 0x65, 0x64,
0x65, 0x20, 0x62, 0x65, 0x73, 0x6b, 0x65, 0x64, 0x65, 0x72, 0x20, 0x2d, 0x20,
0x4d, 0x6f, 0x7a, 0x69, 0x6c, 0x6c, 0x61
WM_ICON_NAME(STRING) = "SSLUG - H?ndtering af UTF-8-kodede beskeder - Mozilla"
WM_NAME(STRING) = "SSLUG - H?ndtering af UTF-8-kodede beskeder - Mozilla"


Expected Results:  
Set _NET_WM_ICON_NAME to the same value as _NET_WM_NAME

Comment 1

[Yuying Long]

reassign to frank.

Comment 2

[Frank Tang]

katakai- can you take this one? or reassign to the Sun browser team ?

Comment 3

[Masaki Katakai]

Attachment: patch

widget/src/gtk2 is OK. We need to fix this for GTK only.

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 114161 [details] [diff] [review]
patch

Sure.  blizzard, do you think this looks ok?

Comment 5

[Masaki Katakai]

Comment on attachment 114161 [details] [diff] [review]
patch

Thank you for review, Brian.

Blizzard, could you review please?

Comment 6

[Christopher Blizzard (:blizzard)]

Comment on attachment 114161 [details] [diff] [review]
patch

sr=blizzard

seems fine to me.

Comment 7

[Masaki Katakai]

patch checked in to 1.4a.