Closed Bug 1923738 Opened 27 days ago Closed 19 days ago

[Outreachy] Add preference for iterator-sequencing proposal

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
133 Branch
Tracking Status
firefox133 --- fixed

People

(Reporter: dminor, Assigned: temidayoazeez032)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

The first step to implementing at TC39 proposal in SpiderMonkey is to add a preference for it. This allows for the feature to be enabled or disabled at runtime, which is important, because we don't want to enable a feature by default until we've tested it enough to be confident that it won't cause problems for our users.

This bug is about adding a preference for the Iterator Sequencing proposal. The steps to do this are:

  1. Make sure that you are able to build SpiderMonkey and run the existing tests. There are instructions here. You want to run the jstests, using this command ./mach jstests.
  2. Find the section in StaticPrefList.yaml for SpiderMonkey preferences and make a copy of an existing preference. Make sure your copy is inside the #ifdef NIGHTLY_BUILD ... #endif // NIGHTLY_BUILD section, because we only want this to be available on nightly builds to begin with.
  3. Change the copy so that the preference name is javascript.options.experimental.iterator_sequencing and save your changes.
  4. Similarly, add an option for the JavaScript shell, by making a copy of this example and changing promise-try to iterator-sequencing.
  5. Make sure you can still build and run the tests.
  6. Once the tests all pass for you, you can commit your changes. Your commit message should look like: Bug X - Add preference for Iterator Sequencing proposal; r=dminor!, where X is the number for this bug.
  7. Once you have your changes committed, request review. There are instructions on using phabricator and on getting reviews.

I am looking into this issue

Assignee: nobody → temidayoazeez032
Status: NEW → ASSIGNED
Attachment #9430112 - Attachment is obsolete: true
Severity: -- → N/A
Priority: -- → P3
Pushed by dminor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dc47324f88ab Add preference for Iterator Sequencing proposal; r=dminor
Status: ASSIGNED → RESOLVED
Closed: 19 days ago
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: