Open Bug 1923886 Opened 1 year ago Updated 1 year ago

Investigate using -forder-file-instrumentation to generate order file

Categories

(Firefox Build System :: General, task)

Product:
Firefox Build System
Component:
General
Type:
task

Tracking

(Not tracked)

People

(Reporter: sergesanspaille, Assigned: sergesanspaille)

Details

The documentation in https://developer.android.com/ndk/guides/orderfile mentions an other approach to generate orderfile through -forder-file-instrumentation. It would be great investigating and comparing the results.

I've playing around with that flag and checked the Android documentation. The flag activates https://reviews.llvm.org/D57463 which just logs the order (``We only log the function when it is first executed.'') which is exactly what we're doing with current implementation through https://reviews.llvm.org/D147287

There are still a few points I'd like to investigate but that's my current understanding.

For reference: This was the chrome issue regarding orderfiles

(In reply to [:sergesanspaille] from comment #1)

which is exactly what we're doing with current implementation through https://reviews.llvm.org/D147287

Specifically, as of bug 1839832, our orderfile is no longer hardcoded, it is based on the PGO profile. So that should have already given us a very similar outcome, though with a different command line flag. Does that sound about right?

For the record: in current situation, the order file we generate are not improving the situation. It's actually worse as showcased by this perftest run: https://perf.compare/compare-results?baseRev=97813366c6b31d2add86a68cbdeefd6617c7a813&newRev=9291cdc801946f998ca00b5a7bdeb2e3032b71e7&baseRepo=try&newRepo=try&framework=13

From 6.84 score with orderfile to 7.16 score without :-/

(In reply to [:sergesanspaille] from comment #4)

For the record: in current situation, the order file we generate are not improving the situation. It's actually worse as showcased by this perftest run: https://perf.compare/compare-results?baseRev=97813366c6b31d2add86a68cbdeefd6617c7a813&newRev=9291cdc801946f998ca00b5a7bdeb2e3032b71e7&baseRepo=try&newRepo=try&framework=13

From 6.84 score with orderfile to 7.16 score without :-/

Hi Serge, given the 5% improvement here, do you also plan on landing this change?

You need to log in before you can comment on or make changes to this bug.