1923902 - Add settings toggle for Focus DAU ping

Status: RESOLVED FIXED

(Focus :: General, enhancement, P1)

Description

[Polly [:polly]]

For the additional DAU ping we will want a separate settings toggle that controls whether it is uploaded.

When we add this, we must make sure that for any users that have already disabled telemetry, the new ping is also disabled.

Content design for this work has not been finalized so this part is not actionable as yet.

Client apps will need to generate and store a new dau_id for the lifetime of the app.

Steps:

• add a new usage:profile_id metric to fenix/app/metrics.yaml ("the dau id")
• on first launch of the app when Glean is initialised, call Usage.profileId.generateAndSet() and save the returned dau id string in a Preference
• on subsequent launches of the app:
  -- if upload is enabled, retrieve the DAU id value from the preference and call Usage.profileId.set(id)
  -- if upload is disabled, unset the DAU id

When the DAU checkbox is toggled:

• ON: generate and set the dau id & store in preference
• OFF: unset the dau id

NB unsetting the dau id is achieved by setting the UUID to a canary value: Usage.profileId.set('beefbeef-beef-beef-beef-beeefbeefbee')

Comment 1

[Polly [:polly]]

Attachment: Bug 1923902: add focus glean usage profile id

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f2e5a05f5c2
add focus glean usage profile id r=android-reviewers,data-stewards,TravisLong,tthibaud

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/345b870dbfb0
Backed out changeset 4f2e5a05f5c2 for causing failures at GleanMetricsServiceTest. CLOSED TREE

Comment 4

[Atila Butkovits]

Backed out for causing failures at GleanMetricsServiceTest.

Backout link: https://hg.mozilla.org/integration/autoland/rev/345b870dbfb00e3c6e34403781acfa33d009b585

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=BgPBBTFnTdaCiimAJczgVQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=439155a1048e432785f4ee77eb510e27591ab218

Failure log: https://treeherder.mozilla.org/logviewer?job_id=484238827&repo=autoland&lineNumber=6779

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b81dcd11535
add focus glean usage profile id r=android-reviewers,data-stewards,TravisLong,tthibaud

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4b81dcd11535

Comment 7

[Polly [:polly]]

reopening because the ping is in but the switch part still needs doing

Comment 8

[Polly [:polly]]

Attachment: Bug 1923902: add fields into focus daily usage ping

Comment 9

[Polly [:polly]]

Attachment: Bug 1923902: set the values in the focus daily usage ping.

Set values for duration, os, os version, app display version and app channel.
Also pulled out the glean specific calls behind an interface for easier unit testing of the lifecycle observer actions.

Comment 10

[Polly [:polly]]

Attachment: Bug 1923902: add switch for focus daily usage ping.

This adds a new "daily usage ping" switch to the settings page and uses it to control whether or not the daily usage ping is sent. (Previously, the main telemetry switch was used.) The new switch's state defaults to the value of the main telemetry switch.

Comment 11

[Polly [:polly]]

Attachment: Bug 1923902: move focus usage profile id interactions into new separate usage reporting service.

This means the usage profile id will be set and unset when the usage reporting switch is toggled on and off.

Comment 12

[Polly [:polly]]

Attachment: Bug 1923902: send data deletion request when focus usage reporting switch is toggled off.

Comment 13

[Polly [:polly]]

Attachment: Bug 1923902: switch off general telemetry and studies

This has now been replaced by the daily usage ping.

Comment 14

[Polly [:polly]]

Attachment: Bug 1923902: update ui tests for new privacy settings

We want to look at the daily usage ping switch and not the old telemetry switch or the studies

Comment 15

[Polly [:polly]]

Attachment: Bug 1923902: tidy up a bit

Rename method, explain a bit more about the canary value in comments.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dca1626f36a0
add fields into focus daily usage ping r=android-reviewers,twhite
https://hg.mozilla.org/integration/autoland/rev/4d2054fbaad3
set the values in the focus daily usage ping. r=android-reviewers,twhite
https://hg.mozilla.org/integration/autoland/rev/4e3c8926f214
add switch for focus daily usage ping. r=android-reviewers,twhite
https://hg.mozilla.org/integration/autoland/rev/6f462603a57a
move focus usage profile id interactions into new separate usage reporting service. r=android-reviewers,twhite
https://hg.mozilla.org/integration/autoland/rev/4678448e8be6
send data deletion request when focus usage reporting switch is toggled off. r=android-reviewers,tthibaud
https://hg.mozilla.org/integration/autoland/rev/5621f33e354b
switch off general telemetry and studies r=android-reviewers,tthibaud
https://hg.mozilla.org/integration/autoland/rev/190dbb7e0dce
update ui tests for new privacy settings r=android-reviewers,tthibaud
https://hg.mozilla.org/integration/autoland/rev/53a5a50b2962
tidy up a bit r=android-reviewers,tthibaud

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/dca1626f36a0
https://hg.mozilla.org/mozilla-central/rev/4d2054fbaad3
https://hg.mozilla.org/mozilla-central/rev/4e3c8926f214
https://hg.mozilla.org/mozilla-central/rev/6f462603a57a
https://hg.mozilla.org/mozilla-central/rev/4678448e8be6
https://hg.mozilla.org/mozilla-central/rev/5621f33e354b
https://hg.mozilla.org/mozilla-central/rev/190dbb7e0dce
https://hg.mozilla.org/mozilla-central/rev/53a5a50b2962