[wpt-sync] Sync PR 48563 - Fix use of color channel keywords in calc() division denominators
Categories
(Core :: CSS Parsing and Computation, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox133 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Attachments
(7 files)
Sync web-platform-tests PR 48563 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/48563
Details from upstream follow.
Kevin Babbitt <kbabbitt@microsoft.com> wrote:
Fix use of color channel keywords in calc() division denominators
The calc expression parser was enforcing a restriction that the
denominator must be a number, and depending on this restriction to
simplify divisions at parse time. This restriction was specified in
css-values-3 but relaxed in css-values-4.Prior to crrev.com/c/371224775, when a color channel keyword was used
in a calc() expression, we would eagerly substitute in the numeric value
as soon as we encountered the keyword token. As a result, the parsed
expression would satisfy the restriction and the expression would be
accepted. As of that change, we now do the value substitution later in
order to preserve the originally specified form.The fix is to relax the type restriction in code, which necessitates
implementing support for Invert nodes in calculation expression trees
as specified in css-values-4.Bug: 371224775
Change-Id: Ia9b08030a08a64023b166abbd332e8c6db9043d0
Reviewed-on: https://chromium-review.googlesource.com/5909795
WPT-Export-Revision: 82b01b53c28d85704c17c8d37b954dfa8e8f0d5a
Assignee | ||
Updated•1 month ago
|
Assignee | ||
Comment 1•25 days ago
|
||
Assignee | ||
Comment 2•25 days ago
|
||
Assignee | ||
Comment 3•25 days ago
|
||
Assignee | ||
Comment 4•24 days ago
|
||
Assignee | ||
Comment 5•24 days ago
|
||
Assignee | ||
Comment 6•24 days ago
|
||
Assignee | ||
Comment 7•23 days ago
|
||
Assignee | ||
Comment 9•23 days ago
|
||
Assignee | ||
Comment 10•23 days ago
|
||
Comment 11•22 days ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/aecd41130e78
https://hg.mozilla.org/mozilla-central/rev/9cbd3bd10a43
Description
•