1923910 - [wpt-sync] Sync PR 48563 - Fix use of color channel keywords in calc() division denominators

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48563 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48563
Details from upstream follow.

Kevin Babbitt <[e-mail]> wrote:

Fix use of color channel keywords in calc() division denominators

The calc expression parser was enforcing a restriction that the
denominator must be a number, and depending on this restriction to
simplify divisions at parse time. This restriction was specified in
css-values-3 but relaxed in css-values-4.

Prior to crrev.com/c/371224775, when a color channel keyword was used
in a calc() expression, we would eagerly substitute in the numeric value
as soon as we encountered the keyword token. As a result, the parsed
expression would satisfy the restriction and the expression would be
accepted. As of that change, we now do the value substitution later in
order to preserve the originally specified form.

The fix is to relax the type restriction in code, which necessitates
implementing support for Invert nodes in calculation expression trees
as specified in css-values-4.

Bug: 371224775
Change-Id: Ia9b08030a08a64023b166abbd332e8c6db9043d0
Reviewed-on: https://chromium-review.googlesource.com/5909795
WPT-Export-Revision: 82b01b53c28d85704c17c8d37b954dfa8e8f0d5a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c11f0c9132d833b50f5134a9c0d21d341c795815

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1077 subtests

## Status Summary

### Firefox
`OK`  : 1
`PASS`: 12
`FAIL`: 1065

### Chrome
`OK`  : 1
`PASS`: 1061
`FAIL`: 16

### Safari
`OK`  : 1
`PASS`: 1077

## Links
[GitHub PR Head](https://wpt.fyi/results/?sha=9901ea4260c9374e8584ea5026d32269507a63b0&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=9901ea4260c9374e8584ea5026d32269507a63b0&label=pr_base)

## Details

(See attachment for full changes)

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1077 subtests

## Status Summary

### Firefox
`OK`  : 1
`PASS`: 12
`FAIL`: 1065

### Chrome
`OK`  : 1
`PASS`: 1061
`FAIL`: 16

### Safari
`OK`  : 1
`PASS`: 1077

## Links
[GitHub PR Head](https://wpt.fyi/results/?sha=9901ea4260c9374e8584ea5026d32269507a63b0&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=9901ea4260c9374e8584ea5026d32269507a63b0&label=pr_base)

## Details

(See attachment for full changes)

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1077 subtests

## Status Summary

### Firefox
`OK`  : 1
`PASS`: 12
`FAIL`: 1065

### Chrome
`OK`  : 1
`PASS`: 1061
`FAIL`: 16

### Safari
`OK`  : 1
`PASS`: 1077

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=c11f0c9132d833b50f5134a9c0d21d341c795815)
[GitHub PR Head](https://wpt.fyi/results/?sha=9901ea4260c9374e8584ea5026d32269507a63b0&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=9901ea4260c9374e8584ea5026d32269507a63b0&label=pr_base)

## Details

(See attachment for full changes)

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1077 subtests

## Status Summary

### Firefox
`OK`  : 1
`PASS`: 12
`FAIL`: 1065

### Chrome
`OK`  : 1
`PASS`: 1061
`FAIL`: 16

### Safari
`OK`  : 1
`PASS`: 1077

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=c11f0c9132d833b50f5134a9c0d21d341c795815)
[GitHub PR Head](https://wpt.fyi/results/?sha=9901ea4260c9374e8584ea5026d32269507a63b0&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=9901ea4260c9374e8584ea5026d32269507a63b0&label=pr_base)

## Details

(See attachment for full changes)

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1077 subtests

## Status Summary

### Firefox
`OK`  : 1
`PASS`: 12
`FAIL`: 1065

### Chrome
`OK`  : 1
`PASS`: 1061
`FAIL`: 16

### Safari
`OK`  : 1
`PASS`: 1077

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=c11f0c9132d833b50f5134a9c0d21d341c795815)
[GitHub PR Head](https://wpt.fyi/results/?sha=9901ea4260c9374e8584ea5026d32269507a63b0&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=9901ea4260c9374e8584ea5026d32269507a63b0&label=pr_base)

## Details

(See attachment for full changes)

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1077 subtests

## Status Summary

### Firefox
`OK`  : 1
`PASS`: 12
`FAIL`: 1065

### Chrome
`OK`  : 1
`PASS`: 1061
`FAIL`: 16

### Safari
`OK`  : 1
`PASS`: 1077

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=c11f0c9132d833b50f5134a9c0d21d341c795815)
[GitHub PR Head](https://wpt.fyi/results/?sha=9901ea4260c9374e8584ea5026d32269507a63b0&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=9901ea4260c9374e8584ea5026d32269507a63b0&label=pr_base)

## Details

(See attachment for full changes)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aecd41130e78
[wpt PR 48563] - Fix use of color channel keywords in calc() division denominators, a=testonly
https://hg.mozilla.org/integration/autoland/rev/9cbd3bd10a43
[wpt PR 48563] - Update wpt metadata, a=testonly

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1077 subtests

## Status Summary

### Firefox
`OK`  : 1
`PASS`: 12
`FAIL`: 1065

### Chrome
`OK`  : 1
`PASS`: 1061
`FAIL`: 16

### Safari
`OK`  : 1
`PASS`: 1077

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=c11f0c9132d833b50f5134a9c0d21d341c795815)
[GitHub PR Head](https://wpt.fyi/results/?sha=9901ea4260c9374e8584ea5026d32269507a63b0&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=9901ea4260c9374e8584ea5026d32269507a63b0&label=pr_base)

## Details

(See attachment for full changes)

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 11

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/aecd41130e78
https://hg.mozilla.org/mozilla-central/rev/9cbd3bd10a43