Closed Bug 1923911 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 48564 - [line-clamp] Hide from paint non-fixed-height abspos after clamp

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

Product:
Core
Component:
Layout: Scrolling and Overflow
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
133 Branch
Tracking Flags:
Tracking Status
firefox133 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48564 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48564
Details from upstream follow.

Andreu Botella <abotella@igalia.com> wrote:

[line-clamp] Hide from paint non-fixed-height abspos after clamp

With the continue: collapse variant of line-clamp, absolutely
positioned boxes that are after the clamp point in the layout tree
should be hidden from paint. However, abspos with an indefinite block
size were not always being hidden.

The reason for this was that for such abspos,
OutOfFlowLayoutPart::CalculateOffset performs an initial layout,
which can end up becoming the final layout of the abspos, which does
not happen for the fixed-height abspos that we had tested previously.
As it turns out, that layout was not checking the NodeInfo's
is_hidden_for_paint field to determine whether to hide the fragment.
This change fixes that.

Bug: 40336192
Change-Id: I5876c762d0d9957ea5785660c73528b83de99eb9
Reviewed-on: https://chromium-review.googlesource.com/5923076
WPT-Export-Revision: 3b192dae951fc5102129b8f7004ec14daf4e70e4

Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f699f28d1ad7 [wpt PR 48564] - [line-clamp] Hide from paint non-fixed-height abspos after clamp, a=testonly https://hg.mozilla.org/integration/autoland/rev/44d2dba0cded [wpt PR 48564] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f699f28d1ad7
https://hg.mozilla.org/mozilla-central/rev/44d2dba0cded

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox133: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 133 Branch
You need to log in before you can comment on or make changes to this bug.