1923946 - Update sidebar telemetry for resizing and panel toggling

Status: RESOLVED FIXED

(Firefox :: Sidebar, task)

Description

[Vanessa Sabino]

Resize:

The sidebar.resize telemetry event was intended to record user initiated sidebar resize, but it's currently firing for automatic resize as well, such as when the user switches from a narrower panel to the Chatbot one. I'm even seeing frequent events where previous and current are exactly the same. Would it be possible to either stop firing in that case?

Let's also truncate the numbers to the integer, I don't need any decimal points either on the percentage or pixel width.

Toggle

The sidebar_toggle events (under history, synced_tabs, bookmarks, and extension) are going to be used to estimate the duration a panel remained open, and therefore we need the close events (opened=False) for all cases when the panel is no longer visible. Right now I'm getting the close events when I close the sidebar, but not when I switch between panels, so I'd like that to be included. This follows the same behavior that is already implemented on the chatbot panel.

Comment 1

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1923946 - Update sidebar telemetry for resizing and panel toggling r?#sidebar-reviewers!

• Simplifies the resize tracking logic so that it hooks the splitter, rather than the browser. This removes the need to debounce and solves the issue of reporting automatic resizes.
• Rounds resize event data to the nearest integer.
• Records hide events whenever current panel is switched.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1f4297b441c
Update sidebar telemetry for resizing and panel toggling r=sidebar-reviewers,sclements

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d1f4297b441c