1923973 - [FOG] Infinite Loop while building Firefox Desktop

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Chris H-C :chutten|RustWeek (Back May 25)]

As before (in bug 1822477 where we bumped it to 512 and bug 1852098 where we bumped it to 1024) we're tickling the limit of PHF size for our JS-API-needed perfecthash.

Let's bump it to 2048.

Why is 1024 good enough for Legacy but not good enough for FOG? Because we're using a single hash across all metric names, not ones specific to each of hgrams (hello, use counters), scalars, and events.

Comment 1

[Chris H-C :chutten|RustWeek (Back May 25)]

Attachment: Bug 1923973 - Increase size of intermediate PHF table r?janerik

Why is 1024 big enough for Legacy Telemetry but not for FOG?
Because Legacy Telemetry splits its hashes by probe type
(hgram, scalar, event), where FOG puts them all in one so all metrics can be
reached on the same Glean global.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2b780b589be
Increase size of intermediate PHF table r=janerik

Comment 3

[Iulian Moraru]

Backed out for causing py3 failures on test_glean_parser_js.py.

• Push with failures

• Failure log

• Backout link

[task 2024-10-11T15:07:00.054Z] toolkit/components/glean/tests/pytest/test_no_expired_metrics.py::test_no_metrics_expired PASSED
[task 2024-10-11T15:07:00.054Z] 
[task 2024-10-11T15:07:00.054Z] ============================== 1 passed in 7.73s ===============================
[task 2024-10-11T15:07:00.054Z] 
[task 2024-10-11T15:07:00.054Z] 
[task 2024-10-11T15:07:00.054Z] Tests Completed: 100%|██████████| 7/7 [00:09<00:00,  2.06s/Test]
[task 2024-10-11T15:07:00.054Z]                                                                 
[task 2024-10-11T15:07:00.055Z] /builds/worker/checkouts/gecko/toolkit/components/glean/tests/pytest/test_glean_parser_js.py
[task 2024-10-11T15:07:00.055Z] ============================= test session starts ==============================
[task 2024-10-11T15:07:00.055Z] platform linux -- Python 3.8.10, pytest-7.0.1, pluggy-1.5.0 -- /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/python-test/bin/python
[task 2024-10-11T15:07:00.055Z] rootdir: /builds/worker/checkouts/gecko, configfile: config/mozunit/mozunit/pytest.ini
[task 2024-10-11T15:07:00.055Z] plugins: mock-3.12.0
[task 2024-10-11T15:07:00.055Z] collecting ... collected 2 items
[task 2024-10-11T15:07:00.055Z] 
[task 2024-10-11T15:07:00.055Z] toolkit/components/glean/tests/pytest/test_glean_parser_js.py::test_all_metric_types TEST-UNEXPECTED-FAIL
[task 2024-10-11T15:07:00.055Z] toolkit/components/glean/tests/pytest/test_glean_parser_js.py::test_fake_pings TEST-UNEXPECTED-FAIL
[task 2024-10-11T15:07:00.055Z] 
[task 2024-10-11T15:07:00.055Z] =================================== FAILURES ===================================
[task 2024-10-11T15:07:00.055Z] ____________________________ test_all_metric_types _____________________________
[task 2024-10-11T15:07:00.055Z] toolkit/components/glean/tests/pytest/test_glean_parser_js.py:47: in test_all_metric_types
[task 2024-10-11T15:07:00.055Z]     expect(
[task 2024-10-11T15:07:00.055Z] toolkit/components/glean/tests/pytest/expect_helper.py:34: in expect
[task 2024-10-11T15:07:00.055Z]     assert actual == expected, msg
[task 2024-10-11T15:07:00.055Z] E   AssertionError: Unexpected content in /builds/worker/checkouts/gecko/toolkit/components/glean/tests/pytest/metrics_test_output_js_cpp (at /builds/worker/checkouts/gecko/toolkit/components/glean/tests/pytest/test_glean_parser_js.py:47)
[task 2024-10-11T15:07:00.055Z] E
[task 2024-10-11T15:07:00.055Z] E   If the code generation was changed,
[task 2024-10-11T15:07:00.055Z] E   run the test suite again with `UPDATE_EXPECT=1` set to update the test files.
[task 2024-10-11T15:07:00.055Z] _______________________________ test_fake_pings ________________________________
[task 2024-10-11T15:07:00.055Z] toolkit/components/glean/tests/pytest/test_glean_parser_js.py:77: in test_fake_pings
[task 2024-10-11T15:07:00.055Z]     expect(
[task 2024-10-11T15:07:00.055Z] toolkit/components/glean/tests/pytest/expect_helper.py:34: in expect
[task 2024-10-11T15:07:00.055Z]     assert actual == expected, msg
[task 2024-10-11T15:07:00.055Z] E   AssertionError: Unexpected content in /builds/worker/checkouts/gecko/toolkit/components/glean/tests/pytest/pings_test_output_js_cpp (at /builds/worker/checkouts/gecko/toolkit/components/glean/tests/pytest/test_glean_parser_js.py:77)
[task 2024-10-11T15:07:00.055Z] E
[task 2024-10-11T15:07:00.055Z] E   If the code generation was changed,
[task 2024-10-11T15:07:00.055Z] E   run the test suite again with `UPDATE_EXPECT=1` set to update the test files.
[task 2024-10-11T15:07:00.055Z] ============================== 2 failed in 0.46s ===============================
[task 2024-10-11T15:07:00.055Z] 
[task 2024-10-11T15:07:00.056Z] 
[task 2024-10-11T15:07:00.056Z] Tests Completed: 100%|██████████| 7/7 [00:09<00:00,  1.42s/Test]Return code from mach python-test: 1
[task 2024-10-11T15:07:00.096Z] 
[taskcluster 2024-10-11 15:07:01.779Z] === Task Finished ===
[taskcluster 2024-10-11 15:07:01.780Z] Unsuccessful task run with exit code: 1 completed in 224.557 seconds

Comment 4

[Chris H-C :chutten|RustWeek (Back May 25)]

Ack, good grief, I keep getting tripped up by this. Taking shortcuts when submitting patches. Note to self (repeated): run the suite before submitting your patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e701c8188f5
Increase size of intermediate PHF table r=janerik

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4e701c8188f5