1924205 - Open recently closed tabs gets broken on HistoryFragment when device theme has changed.

Status: RESOLVED FIXED

(Firefox for Android :: History, defect, P2)

Description

[Nicholas Poon [:Nick]]

Attachment: Screen_recording_20241011_155720.mp4

Steps to reproduce

1. Go to history
2. Go to device settings and change device them (does not matter if it is dark or light)
3. Come back to fenix and try to open the recently closed tabs

Expected behavior

The recently closed menu opens

Actual behavior

Nothing happens

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1842249

:matt-tighe, since you are the author of the regressor, bug 1842249, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1842249

Comment 3

[Donal Meehan [:dmeehan]]

Adding the same comment as https://bugzilla.mozilla.org/show_bug.cgi?id=1924201#c3

:rsainani, pinging as Triage Owner, this was set as S2 but there's no priority or activity for the last couple of weeks.
Wondering if this has a priority and if we can expect a fix for Fx133?

Comment 4

[Nicholas Poon [:Nick]]

Hey :dmeehan,

Thanks for the follow up! I am going to pick this one up right now

Comment 5

[Nicholas Poon [:Nick]]

Attachment: Bug 1924205 - Fix navigation to Recently closed tabs when device theme has changed

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/385135f0aa1c
Fix navigation to Recently closed tabs when device theme has changed r=android-reviewers,rsainani

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/385135f0aa1c

Comment 8

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:npoon, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Nicholas Poon [:Nick]]

We will wait until QA verifies the fix before uplifting

Comment 10

[Delia Pop (Android QA)]

Attachment: media_20241106_173305_3829341460594949232.mp4

Verified as fixed in the latest Nightly 134.0a1 from 11/06 with Samsung Galaxy S22 Ultra (Android 14) and Lenovo Yoga Tab 11 (Android 12).

Comment 11

[Nicholas Poon [:Nick]]

Comment on attachment 9434631 [details]
Bug 1924205 - Fix navigation to Recently closed tabs when device theme has changed

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: After changing device theme, the recently closed tabs will not be functional from history
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It has already been verified by QA and history is even more broken without this fix
• String changes made/needed:
• Is Android affected?: Yes

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9434631 [details]
Bug 1924205 - Fix navigation to Recently closed tabs when device theme has changed

Adding the uplift request flag missed in comment 11

Comment 13

[Donal Meehan [:dmeehan]]

Comment on attachment 9434631 [details]
Bug 1924205 - Fix navigation to Recently closed tabs when device theme has changed

Approved for 133.0b6

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/09abd3424525