1924480 - [wpt-sync] Sync PR 48597 - [@container] Correctly match snapped on container-type changes

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48597 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48597
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

[@container] Correctly match snapped on container-type changes

Unlike for stuck queries, the snapshot client for snapped queries may
outlive a ContainerQueryEvaluator. If a container-type:scroll-state
which is snapped changes its container-type to 'none' and then back
again we may have a snapped state snapshot that does not need an update
when we re-create the ContainerQueryEvaluator.

Make sure the ContainerQueryEvaluator initializes the ContainerValues
with the snapshot state for snapped queries.

Added a test for the stuck feature to verify that works.

Bug: 40279568
Change-Id: I7ced76e4004e9ab7338c6b75b61fe88215438ff7
Reviewed-on: https://chromium-review.googlesource.com/5926649
WPT-Export-Revision: 64f73ddad71600b6e6b5dc5c172126d7041ab32e

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=40c0325f6712b86071187ddc059b0ec7c147a0f7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 5

Chrome

OK : 2
PASS: 4
FAIL: 1

Safari

OK : 2
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-conditional/container-queries/scroll-state-snapped-container-type-change.html [wpt.fyi]
  • Check scroll-state(snapped) initially matching: FAIL (Chrome: PASS, Safari: FAIL)
  • Check scroll-state(snapped) not matching when scroll-snap-align is removed: FAIL (Chrome: PASS, Safari: FAIL)
  • Check scroll-state(snapped) not matching when scroll-snap-type is removed: FAIL (Chrome: PASS, Safari: FAIL)
  • Check scroll-state(snapped) not matching when container-type is removed: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-conditional/container-queries/scroll-state-stuck-container-type-change.html [wpt.fyi]
  • Check that scroll-state(stuck: bottom) evaluation changes with container-type changes: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29cc4d9765c4
[wpt PR 48597] - [@container] Correctly match snapped on container-type changes, a=testonly
https://hg.mozilla.org/integration/autoland/rev/a5c66783b428
[wpt PR 48597] - Update wpt metadata, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/29cc4d9765c4
https://hg.mozilla.org/mozilla-central/rev/a5c66783b428