1924485 - [wpt-sync] Sync PR 48599 - Add WPTs that opus supports both mono and stereo signals.

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48599 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48599
Details from upstream follow.

Henrik Boström <[e-mail]> wrote:

Add WPTs that opus supports both mono and stereo signals.

Currently the first test passes (channelCount:1) but the second test
fails (channelCount:2) because today SDP must be modified to say
"stereo=1".

However the opus spec says that "stereo=1" is just an optional receiver
preference and should not be mandatory to do stereo. Even if it is
missing both mono and stereo should be supported.

The added tests negotiate opus and expect remote track's channel count
to match the local track's channel count in a simple loopback call in
the case that we don't SDP munge.

In a future CL we may want to also test the "stereo=1" SDP munging path
but here we are only concerned with default feature support.

Bug: webrtc:42233792
Change-Id: Ica97b30736d56117b260501e5ccd1c66f2d73fae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5925771
Reviewed-by: Ale Bzk \<[e-mail]>
Commit-Queue: Henrik Boström \<[e-mail]>
Reviewed-by: Harald Alvestrand \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1368159}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e7a4a48992a7ce1318bfa9c4858dfc252d4f1fb

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

TIMEOUT: 2
NOTRUN : 1

Chrome

OK : 1
PASS : 1
FAIL : 1

Safari

OK : 1
FAIL : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

• /webrtc/RTCRtpEncodingParameters-codec-opus-stereo.https.html [wpt.fyi]: TIMEOUT

New Tests That Don't Pass

• /webrtc/RTCRtpEncodingParameters-codec-opus-stereo.https.html [wpt.fyi]: TIMEOUT (Chrome: OK, Safari: OK)
  • Sending and receiving a mono track with opus: TIMEOUT (Chrome: PASS, Safari: FAIL)
  • Sending and receiving a stereo track with opus: NOTRUN (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c089dc048199
[wpt PR 48599] - Add WPTs that opus supports both mono and stereo signals., a=testonly
https://hg.mozilla.org/integration/autoland/rev/eb03872316f0
[wpt PR 48599] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c089dc048199
https://hg.mozilla.org/mozilla-central/rev/eb03872316f0