1924663 - Tracing values performance isn't tracked in DAMP

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

None of the existing test for the JavaScript Tracer in DAMP are enabling values tracing.
We should enable this feature as it comes with specific performance issues.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1924663 - [devtools] Track performance of tracing values in DAMP.

Enable recording JS values of function call arguments and returned values
for all the outputs.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5554edb63917
[devtools] Track performance of tracing values in DAMP. r=devtools-reviewers,perftest-reviewers,bomsy,sparky

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5554edb63917

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Perfherder has detected a devtools performance change from push 8d1d342fdb6432b6b6cb53ee61ad6ee0a6a51a0f.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
314%	damp jstracer.server-performance.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	1,625.09 -> 6,719.73
293%	damp jstracer.debugger-sidebar-performance.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	1,721.91 -> 6,772.00
237%	damp jstracer.webconsole-performance.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	2,059.65 -> 6,947.23
221%	damp jstracer.server-performance.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	2,089.54 -> 6,697.34
204%	damp jstracer.debugger-sidebar-performance.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	2,353.93 -> 7,162.01
184%	damp jstracer.webconsole-performance.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	2,572.54 -> 7,304.99
153%	damp jstracer.server-performance.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	800.54 -> 2,028.34
150%	damp jstracer.debugger-sidebar-performance.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	874.67 -> 2,190.42
103%	damp jstracer.webconsole-performance.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	1,128.48 -> 2,290.44

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 2516

For more information on performance sheriffing please see our FAQ.