1924664 - Huge number of "no edition set" from internal Cargo.toml files

Status: RESOLVED FIXED

(Firefox Build System :: General, task, P3)

Description

[Kagami Rosylight 🏳️‍🌈🏳️‍⚧️ [:saschanaz] (they/them)]

Should add edition = '2015' or consider migrating to 2021.

23:24.25 warning: D:\gecko\netwerk\base\mozurl\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.25 warning: D:\gecko\toolkit\components\uniffi-bindgen-gecko-js\components\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.25 warning: D:\gecko\toolkit\components\uniffi-bindgen-gecko-js\components\Cargo.toml: unused manifest key: lib.plugin
23:24.25 warning: D:\gecko\xpcom\rust\malloc_size_of_derive\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.25 warning: D:\gecko\dom\fs\parent\rust\mime-guess-ffi\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.26 warning: D:\gecko\netwerk\base\rust-helper\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.26 warning: D:\gecko\tools\profiler\rust-helper\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.26 warning: D:\gecko\js\src\fuzz-tests\gluesmith\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.26 warning: D:\gecko\toolkit\components\processtools\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.26 warning: D:\gecko\dom\fs\parent\rust\data-encoding-ffi\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.26 warning: D:\gecko\intl\encoding_glue\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.26 warning: D:\gecko\modules\libpref\parser\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.26 warning: D:\gecko\dom\media\gtest\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.26 warning: D:\gecko\toolkit\components\uniffi-bindgen-gecko-js\fixtures\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.27 warning: D:\gecko\toolkit\components\uniffi-bindgen-gecko-js\fixtures\Cargo.toml: unused manifest key: lib.plugin
23:24.27 warning: D:\gecko\toolkit\library\gtest\rust\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.28 warning: D:\gecko\toolkit\library\gtest\rust\Cargo.toml: unused manifest key: lib.plugin
23:24.31 warning: D:\gecko\toolkit\components\bitsdownload\bits_client\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.32 warning: D:\gecko\xpcom\rust\gtest\nsstring\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.36 warning: D:\gecko\toolkit\components\bitsdownload\bits_client\bits\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.40 warning: D:\gecko\toolkit\components\bitsdownload\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.42 warning: D:\gecko\xpcom\rust\gtest\bench-collections\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.44 warning: D:\gecko\storage\variant\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.46 warning: D:\gecko\js\src\rust\shared\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.48 warning: D:\gecko\dom\media\webrtc\sdp\rsdparsa_capi\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.49 warning: D:\gecko\xpcom\rust\gtest\xpcom\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.51 warning: D:\gecko\toolkit\components\glean\tests\gtest\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.53 warning: D:\gecko\js\src\rust\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.57 warning: D:\gecko\toolkit\library\rust\shared\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.59 warning: D:\gecko\toolkit\library\rust\shared\Cargo.toml: unused manifest key: lib.plugin
23:24.61 warning: D:\gecko\security\manager\ssl\cert_storage\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.63 warning: D:\gecko\toolkit\components\cascade_bloom_filter\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.65 warning: D:\gecko\toolkit\library\rust\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:24.66 warning: D:\gecko\toolkit\library\rust\Cargo.toml: unused manifest key: lib.plugin
23:26.51 security/manager/ssl/builtins/dynamic-library/nssckbi.dll.res
23:27.14 security/manager/ssl/builtins/dynamic-library/nssckbi.dll
23:27.96 warning: trait `HasFloat` is never used
23:27.96   --> third_party\rust\bindgen\ir\item.rs:89:18
23:27.96    |
23:27.96 89 | pub(crate) trait HasFloat {
23:27.96    |                  ^^^^^^^^
23:27.96    |
23:27.96    = note: `#[warn(dead_code)]` on by default
23:27.96 warning: `bindgen` (lib) generated 1 warning
23:27.96    Compiling rsclientcerts v0.1.0 (D:\gecko\security\manager\ssl\rsclientcerts)
23:27.97    Compiling mozilla-central-workspace-hack v0.1.0 (D:\gecko\build\workspace-hack)
23:28.44    Compiling ipcclientcerts-static v0.1.0 (D:\gecko\security\manager\ssl\ipcclientcerts)
23:29.38     Finished `release` profile [unoptimized] target(s) in 5.17s
23:29.80 security/manager/ssl/ipcclientcerts/ipcclientcerts_static.lib
23:29.99 warning: D:\gecko\toolkit\components\uniffi-bindgen-gecko-js\components\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:29.99 warning: D:\gecko\toolkit\components\uniffi-bindgen-gecko-js\components\Cargo.toml: unused manifest key: lib.plugin
23:29.99 warning: D:\gecko\toolkit\library\rust\shared\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:29.99 warning: D:\gecko\toolkit\library\rust\shared\Cargo.toml: unused manifest key: lib.plugin
23:30.00 warning: D:\gecko\xpcom\rust\gtest\bench-collections\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.00 warning: D:\gecko\js\src\rust\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.00 warning: D:\gecko\tools\profiler\rust-helper\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.00 warning: D:\gecko\dom\media\gtest\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.00 warning: D:\gecko\security\manager\ssl\cert_storage\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.00 warning: D:\gecko\toolkit\library\gtest\rust\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.00 warning: D:\gecko\toolkit\library\gtest\rust\Cargo.toml: unused manifest key: lib.plugin
23:30.00 warning: D:\gecko\toolkit\components\glean\tests\gtest\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.00 warning: D:\gecko\netwerk\base\mozurl\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.01 warning: D:\gecko\toolkit\components\bitsdownload\bits_client\bits\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.01 warning: D:\gecko\xpcom\rust\malloc_size_of_derive\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.01 warning: D:\gecko\xpcom\rust\gtest\nsstring\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.01 warning: D:\gecko\toolkit\library\rust\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.01 warning: D:\gecko\toolkit\library\rust\Cargo.toml: unused manifest key: lib.plugin
23:30.01 warning: D:\gecko\intl\encoding_glue\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.01 warning: D:\gecko\modules\libpref\parser\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.02 warning: D:\gecko\toolkit\components\uniffi-bindgen-gecko-js\fixtures\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.02 warning: D:\gecko\toolkit\components\uniffi-bindgen-gecko-js\fixtures\Cargo.toml: unused manifest key: lib.plugin
23:30.02 warning: D:\gecko\toolkit\components\cascade_bloom_filter\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.02 warning: D:\gecko\xpcom\rust\gtest\xpcom\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.02 warning: D:\gecko\toolkit\components\bitsdownload\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.02 warning: D:\gecko\storage\variant\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.02 warning: D:\gecko\dom\fs\parent\rust\data-encoding-ffi\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.02 warning: D:\gecko\dom\fs\parent\rust\mime-guess-ffi\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.02 warning: D:\gecko\js\src\fuzz-tests\gluesmith\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.03 warning: D:\gecko\dom\media\webrtc\sdp\rsdparsa_capi\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.03 warning: D:\gecko\toolkit\components\bitsdownload\bits_client\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.03 warning: D:\gecko\toolkit\components\processtools\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.03 warning: D:\gecko\js\src\rust\shared\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.03 warning: D:\gecko\netwerk\base\rust-helper\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:30.42 security/manager/ssl/ipcclientcerts/dynamic-library/ipcclientcerts.dll.res
23:31.10 security/manager/ssl/ipcclientcerts/dynamic-library/ipcclientcerts.dll
23:34.68 warning: trait `HasFloat` is never used
23:34.68   --> third_party\rust\bindgen\ir\item.rs:89:18
23:34.68    |
23:34.68 89 | pub(crate) trait HasFloat {
23:34.68    |                  ^^^^^^^^
23:34.68    |
23:34.68    = note: `#[warn(dead_code)]` on by default
23:34.69 warning: `bindgen` (lib) generated 1 warning
23:34.69    Compiling test-builtins-static v0.1.0 (D:\gecko\security\manager\ssl\tests\unit\test_builtins)
23:34.69    Compiling mozilla-central-workspace-hack v0.1.0 (D:\gecko\build\workspace-hack)
23:37.08     Finished `release` profile [unoptimized] target(s) in 7.12s
23:37.59 security/manager/ssl/tests/unit/test_builtins/test_builtins_static.lib
23:37.75 warning: D:\gecko\dom\fs\parent\rust\mime-guess-ffi\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.76 warning: D:\gecko\toolkit\components\bitsdownload\bits_client\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.76 warning: D:\gecko\toolkit\components\glean\tests\gtest\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.76 warning: D:\gecko\netwerk\base\rust-helper\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.76 warning: D:\gecko\js\src\fuzz-tests\gluesmith\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.76 warning: D:\gecko\netwerk\base\mozurl\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.76 warning: D:\gecko\tools\profiler\rust-helper\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.77 warning: D:\gecko\js\src\rust\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.77 warning: D:\gecko\toolkit\components\uniffi-bindgen-gecko-js\fixtures\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.77 warning: D:\gecko\toolkit\components\uniffi-bindgen-gecko-js\fixtures\Cargo.toml: unused manifest key: lib.plugin
23:37.77 warning: D:\gecko\toolkit\components\cascade_bloom_filter\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.77 warning: D:\gecko\toolkit\components\uniffi-bindgen-gecko-js\components\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.77 warning: D:\gecko\toolkit\components\uniffi-bindgen-gecko-js\components\Cargo.toml: unused manifest key: lib.plugin
23:37.77 warning: D:\gecko\xpcom\rust\gtest\bench-collections\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.77 warning: D:\gecko\xpcom\rust\gtest\xpcom\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.78 warning: D:\gecko\xpcom\rust\gtest\nsstring\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.78 warning: D:\gecko\js\src\rust\shared\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.78 warning: D:\gecko\storage\variant\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.78 warning: D:\gecko\intl\encoding_glue\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.78 warning: D:\gecko\toolkit\library\gtest\rust\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.78 warning: D:\gecko\toolkit\library\gtest\rust\Cargo.toml: unused manifest key: lib.plugin
23:37.78 warning: D:\gecko\dom\media\webrtc\sdp\rsdparsa_capi\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.79 warning: D:\gecko\toolkit\library\rust\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.79 warning: D:\gecko\toolkit\library\rust\Cargo.toml: unused manifest key: lib.plugin
23:37.79 warning: D:\gecko\toolkit\components\bitsdownload\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.79 warning: D:\gecko\security\manager\ssl\cert_storage\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.79 warning: D:\gecko\toolkit\components\bitsdownload\bits_client\bits\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.79 warning: D:\gecko\toolkit\components\processtools\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.79 warning: D:\gecko\modules\libpref\parser\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.79 warning: D:\gecko\toolkit\library\rust\shared\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.80 warning: D:\gecko\toolkit\library\rust\shared\Cargo.toml: unused manifest key: lib.plugin
23:37.80 warning: D:\gecko\dom\media\gtest\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.80 warning: D:\gecko\xpcom\rust\malloc_size_of_derive\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:37.80 warning: D:\gecko\dom\fs\parent\rust\data-encoding-ffi\Cargo.toml: no edition set: defaulting to the 2015 edition while the latest is 2021
23:38.32 security/manager/ssl/tests/unit/test_builtins/dynamic-library/test_builtins.dll.res
23:39.05 security/manager/ssl/tests/unit/test_builtins/dynamic-library/test_builtins.dll`

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1924664 - Fix Cargo.toml-related warnings from first-party crates.

The warnings are:

no edition set: defaulting to the 2015 edition while the latest is 2021
unused manifest key: lib.plugin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c23329830389
Fix Cargo.toml-related warnings from first-party crates. r=firefox-build-system-reviewers,necko-reviewers,profiler-reviewers,aabh,ahochheiden

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c23329830389